The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v3 0/3] arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A
@ 2026-08-18  9:35 Reza Kurniawan
  2026-08-18  9:35 ` [PATCH v3 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva) Reza Kurniawan
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Reza Kurniawan @ 2026-08-18  9:35 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Reza Kurniawan

Changes in v3:
- Add vcc-supply for vibrator

Changes in v2:
- Split the patch into multiple patches.
- Change name in Signed-off-by field.

v2: https://lore.kernel.org/r/20260810105337.855546-1-imkyufie@gmail.com
v1: https://lore.kernel.org/r/20260810062611.735673-2-imkyufie@gmail.com

Reza Kurniawan (3):
  arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva)
  arm64: dts: qcom: Add haptic vibrator support for Xiaomi Redmi 5A
    (riva)
  arm64: dts: qcom: Add notification LED support for Xiaomi Redmi 5A
    (riva)

 .../boot/dts/qcom/msm8917-xiaomi-riva.dts     | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)


base-commit: 6b8c8af514d739d0335f5579b585e02babe8a727
-- 
2.55.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva)
  2026-08-18  9:35 [PATCH v3 0/3] arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A Reza Kurniawan
@ 2026-08-18  9:35 ` Reza Kurniawan
  2026-08-18  9:38   ` Krzysztof Kozlowski
  2026-08-18  9:35 ` [PATCH v3 2/3] arm64: dts: qcom: Add haptic vibrator " Reza Kurniawan
  2026-08-18  9:35 ` [PATCH v3 3/3] arm64: dts: qcom: Add notification LED " Reza Kurniawan
  2 siblings, 1 reply; 5+ messages in thread
From: Reza Kurniawan @ 2026-08-18  9:35 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Reza Kurniawan

Signed-off-by: Reza Kurniawan <imkyufie@gmail.com>
---
 arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
index 4ea4fbdb5..abfaae502 100644
--- a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
+++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
@@ -13,6 +13,10 @@ / {
 
 	qcom,board-id = <0x1000b 1>, <0x1000b 2>;
 
+	chosen {
+		stdout-path = &blsp1_uart2;
+	};
+
 	battery: battery {
 		compatible = "simple-battery";
 		charge-full-design-microamp-hours = <3000000>;
@@ -25,6 +29,10 @@ battery: battery {
 	};
 };
 
+&blsp1_uart2 {
+	status = "okay";
+};
+
 &blsp2_i2c1 {
 	status = "okay";
 
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 2/3] arm64: dts: qcom: Add haptic vibrator support for Xiaomi Redmi 5A (riva)
  2026-08-18  9:35 [PATCH v3 0/3] arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A Reza Kurniawan
  2026-08-18  9:35 ` [PATCH v3 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva) Reza Kurniawan
@ 2026-08-18  9:35 ` Reza Kurniawan
  2026-08-18  9:35 ` [PATCH v3 3/3] arm64: dts: qcom: Add notification LED " Reza Kurniawan
  2 siblings, 0 replies; 5+ messages in thread
From: Reza Kurniawan @ 2026-08-18  9:35 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Reza Kurniawan

Signed-off-by: Reza Kurniawan <imkyufie@gmail.com>
---
v3:
- Add vcc-supply for vibrator

 arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
index abfaae502..a066d9d7a 100644
--- a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
+++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
@@ -27,6 +27,12 @@ battery: battery {
 		charge-term-current-microamp = <60000>;
 		voltage-min-design-microvolt = <3400000>;
 	};
+
+	vibrator {
+		compatible = "gpio-vibrator";
+		enable-gpios = <&tlmm 97 GPIO_ACTIVE_HIGH>;
+		vcc-supply = <&vph_pwr>;
+	};
 };
 
 &blsp1_uart2 {
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 3/3] arm64: dts: qcom: Add notification LED support for Xiaomi Redmi 5A (riva)
  2026-08-18  9:35 [PATCH v3 0/3] arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A Reza Kurniawan
  2026-08-18  9:35 ` [PATCH v3 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva) Reza Kurniawan
  2026-08-18  9:35 ` [PATCH v3 2/3] arm64: dts: qcom: Add haptic vibrator " Reza Kurniawan
@ 2026-08-18  9:35 ` Reza Kurniawan
  2 siblings, 0 replies; 5+ messages in thread
From: Reza Kurniawan @ 2026-08-18  9:35 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Reza Kurniawan

Signed-off-by: Reza Kurniawan <imkyufie@gmail.com>
---
 .../boot/dts/qcom/msm8917-xiaomi-riva.dts     | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
index a066d9d7a..3f63c2d03 100644
--- a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
+++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
@@ -5,6 +5,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/leds/common.h>
 #include "msm8917-xiaomi-wingtech.dtsi"
 
 / {
@@ -35,6 +36,28 @@ vibrator {
 	};
 };
 
+&blsp1_i2c2 {
+	status = "okay";
+
+	led-controller@45 {
+		compatible = "awinic,aw2013";
+		reg = <0x45>;
+		vcc-supply = <&pm8937_l10>;
+		vio-supply = <&pm8937_l5>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		status = "okay";
+
+		led@0 {
+			reg = <0>;
+			led-max-microamp = <5000>;
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_WHITE>;
+		};
+	};
+};
+
 &blsp1_uart2 {
 	status = "okay";
 };
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva)
  2026-08-18  9:35 ` [PATCH v3 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva) Reza Kurniawan
@ 2026-08-18  9:38   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-18  9:38 UTC (permalink / raw)
  To: Reza Kurniawan, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 18/08/2026 11:35, Reza Kurniawan wrote:
> Signed-off-by: Reza Kurniawan <imkyufie@gmail.com>

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Commit msg is where you explain why you are doing, what you want to
achieve, what is the point of this work etc.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-08-18  9:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-18  9:35 [PATCH v3 0/3] arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A Reza Kurniawan
2026-08-18  9:35 ` [PATCH v3 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva) Reza Kurniawan
2026-08-18  9:38   ` Krzysztof Kozlowski
2026-08-18  9:35 ` [PATCH v3 2/3] arm64: dts: qcom: Add haptic vibrator " Reza Kurniawan
2026-08-18  9:35 ` [PATCH v3 3/3] arm64: dts: qcom: Add notification LED " Reza Kurniawan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox