From: "Siratul Islam" <siratul.islam@linux.dev>
To: "Jorijn van der Graaf" <jorijnvdgraaf@catcrafts.net>,
"Jonathan Cameron" <jic23@kernel.org>
Cc: "Jorijn van der Graaf" <jorijnvdgraaf@catcrafts.net>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Luca Weiss" <luca.weiss@fairphone.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: magnetometer: add support for QST QMC6308
Date: Thu, 16 Jul 2026 14:45:57 +0000 [thread overview]
Message-ID: <bfe7d761f94fdd343a6ba5dfbfeccb724f74a87f@linux.dev> (raw)
In-Reply-To: <20260716141837.83326-1-jorijnvdgraaf@catcrafts.net>
July 16, 2026 at 8:18 PM, "Jorijn van der Graaf" <jorijnvdgraaf@catcrafts.net mailto:jorijnvdgraaf@catcrafts.net?to=%22Jorijn%20van%20der%20Graaf%22%20%3Cjorijnvdgraaf%40catcrafts.net%3E > wrote:
>
> Hi Sirat,
...
>
> >
> > Use reverse x-mas tree order.
> >
> The natural initializer order is fixed by the dependencies here (map
> comes from data, dev from map), so reverse xmas tree would need the
> assignments split from the declarations; I'd rather keep them
> together.
Yep. Of course. That was a dumb suggestion. Should rely less on my pattern
recognition. Though, you are only using "*map" it twice in that function, so I'm not sure
if extracting it into a variable is worth it. Specially considering it makes the declarations
look ugly.
That said, I have opinions about your other replies, but I'm a bit busy now so
I'll get back to them later.
>
...
>
> Thanks,
> Jorijn
>
--
Best regards,
Sirat
prev parent reply other threads:[~2026-07-16 14:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 20:28 [PATCH 0/2] iio: magnetometer: add support for QST QMC6308 Jorijn van der Graaf
2026-07-14 20:28 ` [PATCH 1/2] dt-bindings: iio: magnetometer: add " Jorijn van der Graaf
2026-07-15 18:32 ` Siratul Islam
2026-07-15 20:46 ` Jorijn van der Graaf
2026-07-15 22:16 ` Siratul Islam
2026-07-16 14:18 ` Jorijn van der Graaf
2026-07-14 20:28 ` [PATCH 2/2] iio: magnetometer: add support for " Jorijn van der Graaf
2026-07-14 21:21 ` Uwe Kleine-König
2026-07-15 20:46 ` Jorijn van der Graaf
2026-07-16 9:52 ` Siratul Islam
2026-07-16 10:11 ` Siratul Islam
2026-07-16 14:18 ` Jorijn van der Graaf
2026-07-16 14:45 ` Siratul Islam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfe7d761f94fdd343a6ba5dfbfeccb724f74a87f@linux.dev \
--to=siratul.islam@linux.dev \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jorijnvdgraaf@catcrafts.net \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox