* [PATCH 5/9] i2c: qcom-cci: Use dev_err_probe in probe function
2023-08-02 9:57 [PATCH v2 0/9] Use dev_err_probe in i2c " Liao Chang
@ 2023-08-02 9:57 ` Liao Chang
0 siblings, 0 replies; 3+ messages in thread
From: Liao Chang @ 2023-08-02 9:57 UTC (permalink / raw)
To: andi.shyti, florian.fainelli, bcm-kernel-feedback-list, rjui,
sbranden, yangyicong, aisheng.dong, shawnguo, s.hauer, kernel,
festevam, linux-imx, kblaiech, asmaa, loic.poulain, rfoss, ardb,
gcherian
Cc: linux-i2c, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
linux-arm-msm
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed messge includes the return value and also handles
-EPROBE_DEFER nicely.
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Liao Chang <liaochang1@huawei.com>
---
drivers/i2c/busses/i2c-qcom-cci.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
index 622dc14add9d..cf13abec05f1 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -588,10 +588,8 @@ static int cci_probe(struct platform_device *pdev)
/* Clocks */
ret = devm_clk_bulk_get_all(dev, &cci->clocks);
- if (ret < 1) {
- dev_err(dev, "failed to get clocks %d\n", ret);
- return ret;
- }
+ if (ret < 1)
+ return dev_err_probe(dev, ret, "failed to get clocks\n");
cci->nclocks = ret;
/* Retrieve CCI clock rate */
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5/9] i2c: qcom-cci: Use dev_err_probe in probe function
[not found] ` <e87b35f9-f585-4a3f-bd31-9ebeba52f66b@linaro.org>
@ 2023-08-21 20:37 ` Harshit Mogalapalli
2023-08-21 23:08 ` Dmitry Baryshkov
0 siblings, 1 reply; 3+ messages in thread
From: Harshit Mogalapalli @ 2023-08-21 20:37 UTC (permalink / raw)
To: Dmitry Baryshkov, Liao Chang, andi.shyti, florian.fainelli, rjui,
sbranden, bcm-kernel-feedback-list, yangyicong, aisheng.dong,
shawnguo, s.hauer, kernel, festevam, linux-imx, kblaiech, asmaa,
loic.poulain, rfoss, ardb, gcherian
Cc: linux-i2c, linux-rpi-kernel, linux-arm-kernel, linux-arm-msm,
Dan Carpenter, Vegard Nossum, LKML
Hi,
On 18/08/23 4:36 pm, Dmitry Baryshkov wrote:
> On 28/07/2023 04:31, Liao Chang wrote:
>> Use the dev_err_probe function instead of dev_err in the probe function
>> so that the printed messge includes the return value and also handles
>> -EPROBE_DEFER nicely.
>>
>> Signed-off-by: Liao Chang <liaochang1@huawei.com>
>> ---
>> drivers/i2c/busses/i2c-qcom-cci.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
>>
>> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c
>> b/drivers/i2c/busses/i2c-qcom-cci.c
>> index 622dc14add9d..cf13abec05f1 100644
>> --- a/drivers/i2c/busses/i2c-qcom-cci.c
>> +++ b/drivers/i2c/busses/i2c-qcom-cci.c
>> @@ -588,10 +588,8 @@ static int cci_probe(struct platform_device *pdev)
>> /* Clocks */
>> ret = devm_clk_bulk_get_all(dev, &cci->clocks);
>> - if (ret < 1) {
>> - dev_err(dev, "failed to get clocks %d\n", ret);
>> - return ret;
>> - }
>> + if (ret < 1)
>> + return dev_err_probe(dev, ret, "failed to get clocks\n");
Description:
-----------
* devm_clk_bulk_get_all - managed get multiple clk consumers
* @dev: device for clock "consumer"
* @clks: pointer to the clk_bulk_data table of consumer
*
* Returns a positive value for the number of clocks obtained while the
* clock references are stored in the clk_bulk_data table in @clks field.
* Returns 0 if there're none and a negative value if something failed.
-----------
When ret = 0;
"zero" is passed to dev_err_probe and we are returning success(zero)
from probe function.
Based on other instances of devm_clk_bulk_get_all() API, can we fix it
by changing condition like this?
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c
b/drivers/i2c/busses/i2c-qcom-cci.c
index cf13abec05f1..cea6f70d2b8d 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -588,7 +588,7 @@ static int cci_probe(struct platform_device *pdev)
/* Clocks */
ret = devm_clk_bulk_get_all(dev, &cci->clocks);
- if (ret < 1)
+ if (ret < 0)
return dev_err_probe(dev, ret, "failed to get clocks\n");
cci->nclocks = ret;
Thanks,
Harshit
>> cci->nclocks = ret;
>> /* Retrieve CCI clock rate */
>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5/9] i2c: qcom-cci: Use dev_err_probe in probe function
2023-08-21 20:37 ` [PATCH 5/9] i2c: qcom-cci: Use dev_err_probe in probe function Harshit Mogalapalli
@ 2023-08-21 23:08 ` Dmitry Baryshkov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-08-21 23:08 UTC (permalink / raw)
To: Harshit Mogalapalli
Cc: Liao Chang, andi.shyti, florian.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, yangyicong, aisheng.dong, shawnguo,
s.hauer, kernel, festevam, linux-imx, kblaiech, asmaa,
loic.poulain, rfoss, ardb, gcherian, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-arm-msm, Dan Carpenter, Vegard Nossum,
LKML
On Mon, 21 Aug 2023 at 23:39, Harshit Mogalapalli
<harshit.m.mogalapalli@oracle.com> wrote:
>
> Hi,
>
> On 18/08/23 4:36 pm, Dmitry Baryshkov wrote:
> > On 28/07/2023 04:31, Liao Chang wrote:
> >> Use the dev_err_probe function instead of dev_err in the probe function
> >> so that the printed messge includes the return value and also handles
> >> -EPROBE_DEFER nicely.
> >>
> >> Signed-off-by: Liao Chang <liaochang1@huawei.com>
> >> ---
> >> drivers/i2c/busses/i2c-qcom-cci.c | 6 ++----
> >> 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> >
> >>
> >> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c
> >> b/drivers/i2c/busses/i2c-qcom-cci.c
> >> index 622dc14add9d..cf13abec05f1 100644
> >> --- a/drivers/i2c/busses/i2c-qcom-cci.c
> >> +++ b/drivers/i2c/busses/i2c-qcom-cci.c
> >> @@ -588,10 +588,8 @@ static int cci_probe(struct platform_device *pdev)
> >> /* Clocks */
> >> ret = devm_clk_bulk_get_all(dev, &cci->clocks);
> >> - if (ret < 1) {
> >> - dev_err(dev, "failed to get clocks %d\n", ret);
> >> - return ret;
> >> - }
> >> + if (ret < 1)
> >> + return dev_err_probe(dev, ret, "failed to get clocks\n");
>
> Description:
> -----------
> * devm_clk_bulk_get_all - managed get multiple clk consumers
> * @dev: device for clock "consumer"
> * @clks: pointer to the clk_bulk_data table of consumer
> *
> * Returns a positive value for the number of clocks obtained while the
> * clock references are stored in the clk_bulk_data table in @clks field.
> * Returns 0 if there're none and a negative value if something failed.
> -----------
>
> When ret = 0;
>
> "zero" is passed to dev_err_probe and we are returning success(zero)
> from probe function.
>
> Based on other instances of devm_clk_bulk_get_all() API, can we fix it
> by changing condition like this?
>
> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c
> b/drivers/i2c/busses/i2c-qcom-cci.c
> index cf13abec05f1..cea6f70d2b8d 100644
> --- a/drivers/i2c/busses/i2c-qcom-cci.c
> +++ b/drivers/i2c/busses/i2c-qcom-cci.c
> @@ -588,7 +588,7 @@ static int cci_probe(struct platform_device *pdev)
> /* Clocks */
>
> ret = devm_clk_bulk_get_all(dev, &cci->clocks);
> - if (ret < 1)
> + if (ret < 0)
> return dev_err_probe(dev, ret, "failed to get clocks\n");
Only if it succeeded with something like:
if (!ret)
return dev_err_probe(dev, -EINVAL, "Not enough clocks in DT\n");
But it is a separate topic and should be a part of the separate patch.
> cci->nclocks = ret;
>
>
> Thanks,
> Harshit
>
> >> cci->nclocks = ret;
> >> /* Retrieve CCI clock rate */
> >
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-21 23:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230728013148.1720978-1-liaochang1@huawei.com>
[not found] ` <20230728013148.1720978-6-liaochang1@huawei.com>
[not found] ` <e87b35f9-f585-4a3f-bd31-9ebeba52f66b@linaro.org>
2023-08-21 20:37 ` [PATCH 5/9] i2c: qcom-cci: Use dev_err_probe in probe function Harshit Mogalapalli
2023-08-21 23:08 ` Dmitry Baryshkov
2023-08-02 9:57 [PATCH v2 0/9] Use dev_err_probe in i2c " Liao Chang
2023-08-02 9:57 ` [PATCH 5/9] i2c: qcom-cci: Use dev_err_probe in " Liao Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox