* [PATCH] irqchip: irq-bcm7120-l2: add missing put_device() call in bcm7120_l2_intc_probe()
@ 2021-12-09 12:21 Qing Wang
2021-12-09 16:58 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Qing Wang @ 2021-12-09 12:21 UTC (permalink / raw)
To: Florian Fainelli, Thomas Gleixner, Marc Zyngier,
bcm-kernel-feedback-list, linux-mips, linux-kernel
Cc: Wang Qing
From: Wang Qing <wangqing@vivo.com>
of_find_device_by_node() takes a reference to the embedded struct device
which needs to be dropped when error return.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/irqchip/irq-bcm7120-l2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c
index d80e67a..24573ca
--- a/drivers/irqchip/irq-bcm7120-l2.c
+++ b/drivers/irqchip/irq-bcm7120-l2.c
@@ -336,6 +336,7 @@ static int __init bcm7120_l2_intc_probe(struct device_node *dn,
if (data->map_base[idx])
iounmap(data->map_base[idx]);
}
+ put_device(&pdev->dev);
out_free_data:
kfree(data);
return ret;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irqchip: irq-bcm7120-l2: add missing put_device() call in bcm7120_l2_intc_probe()
2021-12-09 12:21 [PATCH] irqchip: irq-bcm7120-l2: add missing put_device() call in bcm7120_l2_intc_probe() Qing Wang
@ 2021-12-09 16:58 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2021-12-09 16:58 UTC (permalink / raw)
To: Qing Wang, Florian Fainelli, Thomas Gleixner, Marc Zyngier,
bcm-kernel-feedback-list, linux-mips, linux-kernel
On 12/9/21 4:21 AM, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
>
> of_find_device_by_node() takes a reference to the embedded struct device
> which needs to be dropped when error return.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
This has been submitted already with:
https://lore.kernel.org/lkml/20211109055958.130287-1-ye.guojin@zte.com.cn/
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-09 16:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-09 12:21 [PATCH] irqchip: irq-bcm7120-l2: add missing put_device() call in bcm7120_l2_intc_probe() Qing Wang
2021-12-09 16:58 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).