* [PATCH 2/2] dt-bindings: sound: cs35l35: fix typo 'overide' -> 'override'
2026-04-21 2:30 [PATCH 1/2] ASoC: cs35l35: fix typo 'overide' -> 'override' IRRatium
@ 2026-04-21 2:32 ` IRRatium
2026-04-21 9:50 ` Krzysztof Kozlowski
2026-04-21 9:48 ` [PATCH 1/2] ASoC: " Charles Keepax
2026-04-21 9:50 ` Krzysztof Kozlowski
2 siblings, 1 reply; 5+ messages in thread
From: IRRatium @ 2026-04-21 2:32 UTC (permalink / raw)
To: broonie
Cc: lgirdwood, robh, krzk+dt, conor+dt, david.rhodes, rf, linux-sound,
devicetree, linux-kernel, patches
Fix typo in property name 'cirrus,classh-bst-overide',
should be 'cirrus,classh-bst-override'.
Signed-off-by: IRRatium <majnkraftiigry7@gmail.com>
---
Documentation/devicetree/bindings/sound/cs35l35.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/cs35l35.txt
b/Documentation/devicetree/bindings/sound/cs35l35.txt
index e84f30c5c..1d364b3d3 100644
--- a/Documentation/devicetree/bindings/sound/cs35l35.txt
+++ b/Documentation/devicetree/bindings/sound/cs35l35.txt
@@ -82,7 +82,7 @@ Optional H/G Algorithm sub-node:
Optional properties for the "cirrus,classh-internal-algo" Sub-node
Section 7.29 Class H Control
- - cirrus,classh-bst-overide : Boolean
+ - cirrus,classh-bst-override : Boolean
- cirrus,classh-bst-max-limit
- cirrus,classh-mem-depth
@@ -155,7 +155,7 @@ cs35l35: cs35l35@20 {
cirrus,shared-boost;
cirrus,classh-internal-algo {
- cirrus,classh-bst-overide;
+ cirrus,classh-bst-override;
cirrus,classh-bst-max-limit = <0x01>;
cirrus,classh-mem-depth = <0x01>;
cirrus,classh-release-rate = <0x08>;
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] dt-bindings: sound: cs35l35: fix typo 'overide' -> 'override'
2026-04-21 2:32 ` [PATCH 2/2] dt-bindings: sound: " IRRatium
@ 2026-04-21 9:50 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-21 9:50 UTC (permalink / raw)
To: IRRatium, broonie
Cc: lgirdwood, robh, krzk+dt, conor+dt, david.rhodes, rf, linux-sound,
devicetree, linux-kernel, patches
On 21/04/2026 04:32, IRRatium wrote:
> Fix typo in property name 'cirrus,classh-bst-overide',
> should be 'cirrus,classh-bst-override'.
>
> Signed-off-by: IRRatium <majnkraftiigry7@gmail.com>
> ---
> Documentation/devicetree/bindings/sound/cs35l35.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/cs35l35.txt
> b/Documentation/devicetree/bindings/sound/cs35l35.txt
> index e84f30c5c..1d364b3d3 100644
> --- a/Documentation/devicetree/bindings/sound/cs35l35.txt
> +++ b/Documentation/devicetree/bindings/sound/cs35l35.txt
> @@ -82,7 +82,7 @@ Optional H/G Algorithm sub-node:
> Optional properties for the "cirrus,classh-internal-algo" Sub-node
>
> Section 7.29 Class H Control
> - - cirrus,classh-bst-overide : Boolean
> + - cirrus,classh-bst-override : Boolean
> - cirrus,classh-bst-max-limit
NAK, ABI break.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ASoC: cs35l35: fix typo 'overide' -> 'override'
2026-04-21 2:30 [PATCH 1/2] ASoC: cs35l35: fix typo 'overide' -> 'override' IRRatium
2026-04-21 2:32 ` [PATCH 2/2] dt-bindings: sound: " IRRatium
@ 2026-04-21 9:48 ` Charles Keepax
2026-04-21 9:50 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Charles Keepax @ 2026-04-21 9:48 UTC (permalink / raw)
To: IRRatium
Cc: broonie, lgirdwood, robh, krzk+dt, conor+dt, david.rhodes, rf,
linux-sound, devicetree, linux-kernel, patches
On Tue, Apr 21, 2026 at 05:30:27AM +0300, IRRatium wrote:
> Fix typo in property name 'cirrus,classh-bst-overide',
> should be 'cirrus,classh-bst-override'.
>
> Signed-off-by: IRRatium <majnkraftiigry7@gmail.com>
> ---
> sound/soc/codecs/cs35l35.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 7a01b1d9f..7d9b42c5a 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1311,7 +1311,7 @@ static int cs35l35_handle_of_data(struct i2c_client
> *i2c_client,
>
> if (classh_config->classh_algo_enable) {
> classh_config->classh_bst_override =
> - of_property_read_bool(np, "cirrus,classh-bst-overide");
> + of_property_read_bool(np, "cirrus,classh-bst-override");
This would need to check both properties. The problem is as this
is a device tree thing and has been in the wild for some time,
we can't be sure there aren't device trees out there depending
on the misspelling.
Thanks,
Charles
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] ASoC: cs35l35: fix typo 'overide' -> 'override'
2026-04-21 2:30 [PATCH 1/2] ASoC: cs35l35: fix typo 'overide' -> 'override' IRRatium
2026-04-21 2:32 ` [PATCH 2/2] dt-bindings: sound: " IRRatium
2026-04-21 9:48 ` [PATCH 1/2] ASoC: " Charles Keepax
@ 2026-04-21 9:50 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-21 9:50 UTC (permalink / raw)
To: IRRatium, broonie
Cc: lgirdwood, robh, krzk+dt, conor+dt, david.rhodes, rf, linux-sound,
devicetree, linux-kernel, patches
On 21/04/2026 04:30, IRRatium wrote:
> Fix typo in property name 'cirrus,classh-bst-overide',
> should be 'cirrus,classh-bst-override'.
>
> Signed-off-by: IRRatium <majnkraftiigry7@gmail.com>
We don't take anonymous contributions.
> ---
> sound/soc/codecs/cs35l35.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 7a01b1d9f..7d9b42c5a 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1311,7 +1311,7 @@ static int cs35l35_handle_of_data(struct
> i2c_client *i2c_client,
>
> if (classh_config->classh_algo_enable) {
> classh_config->classh_bst_override =
> - of_property_read_bool(np, "cirrus,classh-bst-overide");
> + of_property_read_bool(np, "cirrus,classh-bst-override");
ABI break, so that's a strong no.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread