* [PATCH v2] perf/x86/intel/uncore: Convert comma to semicolon
@ 2026-01-14 2:36 Chen Ni
2026-01-14 5:25 ` Mi, Dapeng
2026-01-15 21:43 ` [tip: perf/core] " tip-bot2 for Chen Ni
0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2026-01-14 2:36 UTC (permalink / raw)
To: nichen, peterz, mingo, acme, namhyung, mark.rutland,
alexander.shishkin, jolsa, irogers, adrian.hunter, james.clark,
tglx, bp, dave.hansen, x86, hpa, zide.chen, dapeng1.mi
Cc: linux-perf-users, linux-kernel
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Fixes: e7d5f2ea0923 ("perf/x86/intel/uncore: Add Nova Lake support")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
Changelog:
v1 -> v2:
- Add Fixes tag.
---
arch/x86/events/intel/uncore_snb.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/events/intel/uncore_snb.c b/arch/x86/events/intel/uncore_snb.c
index e8e44741200e..3dbc6bacbd9d 100644
--- a/arch/x86/events/intel/uncore_snb.c
+++ b/arch/x86/events/intel/uncore_snb.c
@@ -2005,11 +2005,11 @@ static struct intel_uncore_type *nvl_msr_uncores[] = {
void nvl_uncore_cpu_init(void)
{
mtl_uncore_cbox.num_boxes = 12;
- mtl_uncore_cbox.perf_ctr = NVL_UNC_CBOX_PER_CTR0,
- mtl_uncore_cbox.event_ctl = NVL_UNC_CBOX_PERFEVTSEL0,
+ mtl_uncore_cbox.perf_ctr = NVL_UNC_CBOX_PER_CTR0;
+ mtl_uncore_cbox.event_ctl = NVL_UNC_CBOX_PERFEVTSEL0;
- ptl_uncore_santa.perf_ctr = NVL_UNC_SANTA_CTR0,
- ptl_uncore_santa.event_ctl = NVL_UNC_SANTA_CTRL0,
+ ptl_uncore_santa.perf_ctr = NVL_UNC_SANTA_CTR0;
+ ptl_uncore_santa.event_ctl = NVL_UNC_SANTA_CTRL0;
mtl_uncore_cncu.box_ctl = NVL_UNC_CNCU_BOX_CTL;
mtl_uncore_cncu.fixed_ctr = NVL_UNC_CNCU_FIXED_CTR;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] perf/x86/intel/uncore: Convert comma to semicolon
2026-01-14 2:36 [PATCH v2] perf/x86/intel/uncore: Convert comma to semicolon Chen Ni
@ 2026-01-14 5:25 ` Mi, Dapeng
2026-01-15 21:43 ` [tip: perf/core] " tip-bot2 for Chen Ni
1 sibling, 0 replies; 3+ messages in thread
From: Mi, Dapeng @ 2026-01-14 5:25 UTC (permalink / raw)
To: Chen Ni, peterz, mingo, acme, namhyung, mark.rutland,
alexander.shishkin, jolsa, irogers, adrian.hunter, james.clark,
tglx, bp, dave.hansen, x86, hpa, zide.chen
Cc: linux-perf-users, linux-kernel
On 1/14/2026 10:36 AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Fixes: e7d5f2ea0923 ("perf/x86/intel/uncore: Add Nova Lake support")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> - Add Fixes tag.
> ---
> arch/x86/events/intel/uncore_snb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/events/intel/uncore_snb.c b/arch/x86/events/intel/uncore_snb.c
> index e8e44741200e..3dbc6bacbd9d 100644
> --- a/arch/x86/events/intel/uncore_snb.c
> +++ b/arch/x86/events/intel/uncore_snb.c
> @@ -2005,11 +2005,11 @@ static struct intel_uncore_type *nvl_msr_uncores[] = {
> void nvl_uncore_cpu_init(void)
> {
> mtl_uncore_cbox.num_boxes = 12;
> - mtl_uncore_cbox.perf_ctr = NVL_UNC_CBOX_PER_CTR0,
> - mtl_uncore_cbox.event_ctl = NVL_UNC_CBOX_PERFEVTSEL0,
> + mtl_uncore_cbox.perf_ctr = NVL_UNC_CBOX_PER_CTR0;
> + mtl_uncore_cbox.event_ctl = NVL_UNC_CBOX_PERFEVTSEL0;
>
> - ptl_uncore_santa.perf_ctr = NVL_UNC_SANTA_CTR0,
> - ptl_uncore_santa.event_ctl = NVL_UNC_SANTA_CTRL0,
> + ptl_uncore_santa.perf_ctr = NVL_UNC_SANTA_CTR0;
> + ptl_uncore_santa.event_ctl = NVL_UNC_SANTA_CTRL0;
>
> mtl_uncore_cncu.box_ctl = NVL_UNC_CNCU_BOX_CTL;
> mtl_uncore_cncu.fixed_ctr = NVL_UNC_CNCU_FIXED_CTR;
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip: perf/core] perf/x86/intel/uncore: Convert comma to semicolon
2026-01-14 2:36 [PATCH v2] perf/x86/intel/uncore: Convert comma to semicolon Chen Ni
2026-01-14 5:25 ` Mi, Dapeng
@ 2026-01-15 21:43 ` tip-bot2 for Chen Ni
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Chen Ni @ 2026-01-15 21:43 UTC (permalink / raw)
To: linux-tip-commits
Cc: Chen Ni, Peter Zijlstra (Intel), Dapeng Mi, x86, linux-kernel
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 10d6d2416db2137a5a0ef9162662e5b7fee56dd4
Gitweb: https://git.kernel.org/tip/10d6d2416db2137a5a0ef9162662e5b7fee56dd4
Author: Chen Ni <nichen@iscas.ac.cn>
AuthorDate: Wed, 14 Jan 2026 10:36:52 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Thu, 15 Jan 2026 10:04:28 +01:00
perf/x86/intel/uncore: Convert comma to semicolon
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Fixes: e7d5f2ea0923 ("perf/x86/intel/uncore: Add Nova Lake support")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Link: https://patch.msgid.link/20260114023652.3926117-1-nichen@iscas.ac.cn
---
arch/x86/events/intel/uncore_snb.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/events/intel/uncore_snb.c b/arch/x86/events/intel/uncore_snb.c
index e8e4474..3dbc6ba 100644
--- a/arch/x86/events/intel/uncore_snb.c
+++ b/arch/x86/events/intel/uncore_snb.c
@@ -2005,11 +2005,11 @@ static struct intel_uncore_type *nvl_msr_uncores[] = {
void nvl_uncore_cpu_init(void)
{
mtl_uncore_cbox.num_boxes = 12;
- mtl_uncore_cbox.perf_ctr = NVL_UNC_CBOX_PER_CTR0,
- mtl_uncore_cbox.event_ctl = NVL_UNC_CBOX_PERFEVTSEL0,
+ mtl_uncore_cbox.perf_ctr = NVL_UNC_CBOX_PER_CTR0;
+ mtl_uncore_cbox.event_ctl = NVL_UNC_CBOX_PERFEVTSEL0;
- ptl_uncore_santa.perf_ctr = NVL_UNC_SANTA_CTR0,
- ptl_uncore_santa.event_ctl = NVL_UNC_SANTA_CTRL0,
+ ptl_uncore_santa.perf_ctr = NVL_UNC_SANTA_CTR0;
+ ptl_uncore_santa.event_ctl = NVL_UNC_SANTA_CTRL0;
mtl_uncore_cncu.box_ctl = NVL_UNC_CNCU_BOX_CTL;
mtl_uncore_cncu.fixed_ctr = NVL_UNC_CNCU_FIXED_CTR;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-15 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-14 2:36 [PATCH v2] perf/x86/intel/uncore: Convert comma to semicolon Chen Ni
2026-01-14 5:25 ` Mi, Dapeng
2026-01-15 21:43 ` [tip: perf/core] " tip-bot2 for Chen Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox