* [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
@ 2023-07-26 23:49 Randy Dunlap
2023-07-27 20:06 ` Sohil Mehta
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2023-07-26 23:49 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Jiri Kosina, x86
This source file already includes <linux/miscdevice.h>, which contains
the same macro. It doesn't need to be defined here again.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: x86@kernel.org
---
arch/x86/kernel/apm_32.c | 6 ------
1 file changed, 6 deletions(-)
diff -- a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
--- a/arch/x86/kernel/apm_32.c
+++ b/arch/x86/kernel/apm_32.c
@@ -239,12 +239,6 @@ extern int (*console_blank_hook)(int);
#endif
/*
- * The apm_bios device is one of the misc char devices.
- * This is its minor number.
- */
-#define APM_MINOR_DEV 134
-
-/*
* Various options can be changed at boot time as follows:
* (We allow underscores for compatibility with the modules code)
* apm=on/off enable/disable APM
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
2023-07-26 23:49 [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro Randy Dunlap
@ 2023-07-27 20:06 ` Sohil Mehta
2023-07-27 21:21 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Sohil Mehta @ 2023-07-27 20:06 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel; +Cc: Jiri Kosina, x86
s/drop/Drop
On 7/26/2023 4:49 PM, Randy Dunlap wrote:
> This source file already includes <linux/miscdevice.h>, which contains
> the same macro. It doesn't need to be defined here again.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: x86@kernel.org
> ---
I am not sure if a Fixes tag is really needed for a redundant macro
definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
move APM_MINOR_DEV to include/linux/miscdevice.h") ?
Either way,
Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
2023-07-27 20:06 ` Sohil Mehta
@ 2023-07-27 21:21 ` Randy Dunlap
2023-07-27 22:05 ` Sohil Mehta
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2023-07-27 21:21 UTC (permalink / raw)
To: Sohil Mehta, linux-kernel; +Cc: Jiri Kosina, x86
Hi Sohil,
On 7/27/23 13:06, Sohil Mehta wrote:
> s/drop/Drop
>
> On 7/26/2023 4:49 PM, Randy Dunlap wrote:
>> This source file already includes <linux/miscdevice.h>, which contains
>> the same macro. It doesn't need to be defined here again.
>>
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Jiri Kosina <jikos@kernel.org>
>> Cc: x86@kernel.org
>> ---
>
> I am not sure if a Fixes tag is really needed for a redundant macro
> definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
> move APM_MINOR_DEV to include/linux/miscdevice.h") ?
I don't see any need for this patch to be backported.
Should it be commit 874bcd00f520c? Maybe. That one certainly
missed moving this macro.
> Either way,
> Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
2023-07-27 21:21 ` Randy Dunlap
@ 2023-07-27 22:05 ` Sohil Mehta
2023-07-27 22:41 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Sohil Mehta @ 2023-07-27 22:05 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel; +Cc: Jiri Kosina, x86
On 7/27/2023 2:21 PM, Randy Dunlap wrote:
> On 7/27/23 13:06, Sohil Mehta wrote:
>> I am not sure if a Fixes tag is really needed for a redundant macro
>> definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
>> move APM_MINOR_DEV to include/linux/miscdevice.h") ?
>
> I don't see any need for this patch to be backported.
>
> Should it be commit 874bcd00f520c? Maybe. That one certainly
> missed moving this macro.
>
Also, applying this patch anytime before 874bcd00f520c will cause a
compilation issue unless 874bcd00f520c is applied as well.
-Sohil
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
2023-07-27 22:05 ` Sohil Mehta
@ 2023-07-27 22:41 ` Randy Dunlap
2023-07-28 0:58 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2023-07-27 22:41 UTC (permalink / raw)
To: Sohil Mehta, linux-kernel; +Cc: Jiri Kosina, x86
On 7/27/23 15:05, Sohil Mehta wrote:
> On 7/27/2023 2:21 PM, Randy Dunlap wrote:
>> On 7/27/23 13:06, Sohil Mehta wrote:
>>> I am not sure if a Fixes tag is really needed for a redundant macro
>>> definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
>>> move APM_MINOR_DEV to include/linux/miscdevice.h") ?
>>
>> I don't see any need for this patch to be backported.
>>
>> Should it be commit 874bcd00f520c? Maybe. That one certainly
>> missed moving this macro.
>>
>
> Also, applying this patch anytime before 874bcd00f520c will cause a
> compilation issue unless 874bcd00f520c is applied as well.
Yeah, that's a good point. Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
2023-07-27 22:41 ` Randy Dunlap
@ 2023-07-28 0:58 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2023-07-28 0:58 UTC (permalink / raw)
To: Sohil Mehta, linux-kernel; +Cc: Jiri Kosina, x86
On 7/27/23 15:41, Randy Dunlap wrote:
>
>
> On 7/27/23 15:05, Sohil Mehta wrote:
>> On 7/27/2023 2:21 PM, Randy Dunlap wrote:
>>> On 7/27/23 13:06, Sohil Mehta wrote:
>>>> I am not sure if a Fixes tag is really needed for a redundant macro
>>>> definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
>>>> move APM_MINOR_DEV to include/linux/miscdevice.h") ?
>>>
>>> I don't see any need for this patch to be backported.
>>>
>>> Should it be commit 874bcd00f520c? Maybe. That one certainly
>>> missed moving this macro.
>>>
>>
>> Also, applying this patch anytime before 874bcd00f520c will cause a
>> compilation issue unless 874bcd00f520c is applied as well.
>
> Yeah, that's a good point. Thanks.
>
I'll send a v2 with the Fixes: tag changed.
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-28 0:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 23:49 [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro Randy Dunlap
2023-07-27 20:06 ` Sohil Mehta
2023-07-27 21:21 ` Randy Dunlap
2023-07-27 22:05 ` Sohil Mehta
2023-07-27 22:41 ` Randy Dunlap
2023-07-28 0:58 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox