The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Coccinelle <cocci@systeme.lip6.fr>,
	LKML <linux-kernel@vger.kernel.org>,
	Cheng Shengyu <cheng.shengyu@zte.com.cn>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Ma Jiang <ma.jiang@zte.com.cn>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Wen Yang <wen.yang99@zte.com.cn>, Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [3/3] Coccinelle: pci_free_consistent: Extend when constraints for two SmPL ellipses
Date: Wed, 15 May 2019 11:40:45 +0200	[thread overview]
Message-ID: <c53d5a80-7f80-535c-8394-a3289399feba@web.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1905151119070.3231@hadrien>

>>> On the other hand, I do care about causing false negatives.
>>
>> Do you find the missing warning after the addition of such an exclusion
>> specification interesting?
>
> I already suggested how to improve the code.

I find that the idea “e2->fld” needs further clarification.
Such a SmPL specification will be resolved also to an expression,
won't it?

I guess that it can fit better to other analysis approaches.
Will any script variants become more interesting?

Is it still unclear which detail (besides the added SmPL filter)
will hinder the warning display for Wen's test case?

Regards,
Markus

  parent reply	other threads:[~2019-05-15  9:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201905151043340243098@zte.com.cn>
2019-05-15  6:10 ` [PATCH 3/3] Coccinelle: pci_free_consistent: Extend whenconstraints for two SmPL ellipses Julia Lawall
2019-05-15  8:36   ` [3/3] Coccinelle: pci_free_consistent: Extend when constraints " Markus Elfring
     [not found]     ` <alpine.DEB.2.20.1905151119070.3231@hadrien>
2019-05-15  9:40       ` Markus Elfring [this message]
2019-05-15 10:19         ` Julia Lawall
2019-05-15 11:18           ` Markus Elfring
2019-05-15  6:48 ` Markus Elfring
2019-05-15  6:48 ` Markus Elfring
2019-05-15  7:48   ` Markus Elfring
2019-05-15 12:48 ` Markus Elfring
     [not found] <201905151538552354689@zte.com.cn>
2019-05-15  8:06 ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c53d5a80-7f80-535c-8394-a3289399feba@web.de \
    --to=markus.elfring@web.de \
    --cc=Gilles.Muller@lip6.fr \
    --cc=cheng.shengyu@zte.com.cn \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ma.jiang@zte.com.cn \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=wang.yi59@zte.com.cn \
    --cc=wen.yang99@zte.com.cn \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox