The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>, Julia Lawall <julia.lawall@lip6.fr>
Cc: Gilles Muller <Gilles.Muller@lip6.fr>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Yi Wang <wang.yi59@zte.com.cn>,
	Cheng Shengyu <cheng.shengyu@zte.com.cn>,
	Ma Jiang <ma.jiang@zte.com.cn>,
	Coccinelle <cocci@systeme.lip6.fr>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [3/3] Coccinelle: pci_free_consistent: Extend when constraints for two SmPL ellipses
Date: Wed, 15 May 2019 14:48:48 +0200	[thread overview]
Message-ID: <e7db2c6b-645d-e82b-9d79-f64d7c5edfc5@web.de> (raw)
In-Reply-To: <201905151043340243098@zte.com.cn>

> 2,  If you really plan to add the two restrictions above,
> you may need to consider this further than simply adding a "when != id = (T2)(e)" statement.
> I constructed the flollowing code snippet as a test case:
> Using the original SmPL, we can find a bug.
> But with your modified SmPL, we can't find the bug.

The difference is the possible exclusion of a reassignment to a local variable
in which a pointer was stored for a resource allocation.

Would you like to adjust corresponding case distinctions any further?

How many script variants will become relevant here?

Regards,
Markus

  parent reply	other threads:[~2019-05-15 12:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201905151043340243098@zte.com.cn>
2019-05-15  6:10 ` [PATCH 3/3] Coccinelle: pci_free_consistent: Extend whenconstraints for two SmPL ellipses Julia Lawall
2019-05-15  8:36   ` [3/3] Coccinelle: pci_free_consistent: Extend when constraints " Markus Elfring
     [not found]     ` <alpine.DEB.2.20.1905151119070.3231@hadrien>
2019-05-15  9:40       ` Markus Elfring
2019-05-15 10:19         ` Julia Lawall
2019-05-15 11:18           ` Markus Elfring
2019-05-15  6:48 ` Markus Elfring
2019-05-15  7:48   ` Markus Elfring
2019-05-15  6:48 ` Markus Elfring
2019-05-15 12:48 ` Markus Elfring [this message]
     [not found] <201905151538552354689@zte.com.cn>
2019-05-15  8:06 ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7db2c6b-645d-e82b-9d79-f64d7c5edfc5@web.de \
    --to=markus.elfring@web.de \
    --cc=Gilles.Muller@lip6.fr \
    --cc=cheng.shengyu@zte.com.cn \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ma.jiang@zte.com.cn \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=wang.yi59@zte.com.cn \
    --cc=wen.yang99@zte.com.cn \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox