From: "Moger, Babu" <bmoger@amd.com>
To: "Luck, Tony" <tony.luck@intel.com>,
Aaron Tomlin <atomlin@atomlin.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"Dave.Martin@arm.com" <Dave.Martin@arm.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"babu.moger@amd.com" <babu.moger@amd.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc: "sean@ashe.io" <sean@ashe.io>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: RE: [PATCH v2 3/3] x86/resctrl: Add "*" shorthand to set minimum io_alloc CBM for all domains
Date: Thu, 18 Dec 2025 15:56:24 -0600 [thread overview]
Message-ID: <c60e32da-7935-439e-9f24-fd637512757d@amd.com> (raw)
In-Reply-To: <SJ1PR11MB6083CCA2A7904E459B1AA35DFCA8A@SJ1PR11MB6083.namprd11.prod.outlook.com>
On 12/18/2025 3:49 PM, Luck, Tony wrote:
>> + if (id && *id == '*') {
>
> That will accept arbitrary chars after the "*".
>
> if (id && !strcmp(id, "*"))
oh.ok. Thanks
>
>> What do you think?
>
> Why is io_alloc special? The same simple change could apply to parse_line() to allow
> setting all domains in a resource to be set to the same value:
>
Yes. I am fine with that approach. Treat "*" equivalent for all the
resources not just io_alloc.
> # echo "L3:*=fff" > schemata
>
> # echo "MB:*=50" > schemata
>
> -Tony
>
>
next prev parent reply other threads:[~2025-12-18 21:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 23:02 [PATCH v2 0/3] x86/resctrl: Add "*" shorthand to set minimum io_alloc CBM for all domains Aaron Tomlin
2025-12-15 23:02 ` [PATCH v2 1/3] fs/resctrl: Add helpers to check io_alloc support and enabled state Aaron Tomlin
2025-12-17 5:01 ` Reinette Chatre
2025-12-18 23:22 ` Aaron Tomlin
2025-12-19 17:05 ` Reinette Chatre
2025-12-25 22:23 ` Aaron Tomlin
2025-12-15 23:02 ` [PATCH v2 2/3] fs/resctrl: Return -EINVAL for a missing seq_show implementation Aaron Tomlin
2025-12-17 5:02 ` Reinette Chatre
2025-12-18 23:12 ` Aaron Tomlin
2025-12-15 23:02 ` [PATCH v2 3/3] x86/resctrl: Add "*" shorthand to set minimum io_alloc CBM for all domains Aaron Tomlin
2025-12-17 5:53 ` Reinette Chatre
2025-12-19 0:21 ` Aaron Tomlin
2025-12-18 21:32 ` Moger, Babu
2025-12-18 21:49 ` Luck, Tony
2025-12-18 21:56 ` Moger, Babu [this message]
2025-12-19 0:31 ` Aaron Tomlin
2025-12-19 0:40 ` Moger, Babu
2025-12-18 22:59 ` Reinette Chatre
2025-12-19 0:44 ` Aaron Tomlin
2025-12-19 18:28 ` Reinette Chatre
2025-12-19 20:42 ` Luck, Tony
2025-12-19 22:00 ` Reinette Chatre
2025-12-19 23:05 ` Luck, Tony
2025-12-25 22:50 ` Aaron Tomlin
2025-12-25 22:33 ` Aaron Tomlin
2025-12-19 0:26 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c60e32da-7935-439e-9f24-fd637512757d@amd.com \
--to=bmoger@amd.com \
--cc=Dave.Martin@arm.com \
--cc=atomlin@atomlin.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=sean@ashe.io \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox