From: Reinette Chatre <reinette.chatre@intel.com>
To: Aaron Tomlin <atomlin@atomlin.com>, <tony.luck@intel.com>,
<Dave.Martin@arm.com>, <james.morse@arm.com>,
<babu.moger@amd.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
<bp@alien8.de>, <dave.hansen@linux.intel.com>
Cc: <sean@ashe.io>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] fs/resctrl: Return -EINVAL for a missing seq_show implementation
Date: Tue, 16 Dec 2025 21:02:27 -0800 [thread overview]
Message-ID: <cf6b025b-cdbf-4d15-b56d-9f8434a57da4@intel.com> (raw)
In-Reply-To: <20251215230257.1798865-3-atomlin@atomlin.com>
Hi Aaron,
How is this change required to support the feature of enabling user to
set CBM across domains?
On 12/15/25 3:02 PM, Aaron Tomlin wrote:
> The rdtgroup_seqfile_show() function, which is the sequence file handler
> for reading data from resctrl files, previously returned 0 (success) if
> the file's associated rftype did not define a .seq_show implementation.
>
> This behavior is incorrect and confusing, as a read operation that
> does not define a display function should be treated as an error.
Why should it be treated as an error? Not having rftype::seq_show() set when
user is intended to be able to see data when reading from the file is a kernel
bug. Otherwise it seems fine to return nothing when there is nothing to show
and doing so be successful.
Reinette
next prev parent reply other threads:[~2025-12-17 5:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 23:02 [PATCH v2 0/3] x86/resctrl: Add "*" shorthand to set minimum io_alloc CBM for all domains Aaron Tomlin
2025-12-15 23:02 ` [PATCH v2 1/3] fs/resctrl: Add helpers to check io_alloc support and enabled state Aaron Tomlin
2025-12-17 5:01 ` Reinette Chatre
2025-12-18 23:22 ` Aaron Tomlin
2025-12-19 17:05 ` Reinette Chatre
2025-12-25 22:23 ` Aaron Tomlin
2025-12-15 23:02 ` [PATCH v2 2/3] fs/resctrl: Return -EINVAL for a missing seq_show implementation Aaron Tomlin
2025-12-17 5:02 ` Reinette Chatre [this message]
2025-12-18 23:12 ` Aaron Tomlin
2025-12-15 23:02 ` [PATCH v2 3/3] x86/resctrl: Add "*" shorthand to set minimum io_alloc CBM for all domains Aaron Tomlin
2025-12-17 5:53 ` Reinette Chatre
2025-12-19 0:21 ` Aaron Tomlin
2025-12-18 21:32 ` Moger, Babu
2025-12-18 21:49 ` Luck, Tony
2025-12-18 21:56 ` Moger, Babu
2025-12-19 0:31 ` Aaron Tomlin
2025-12-19 0:40 ` Moger, Babu
2025-12-18 22:59 ` Reinette Chatre
2025-12-19 0:44 ` Aaron Tomlin
2025-12-19 18:28 ` Reinette Chatre
2025-12-19 20:42 ` Luck, Tony
2025-12-19 22:00 ` Reinette Chatre
2025-12-19 23:05 ` Luck, Tony
2025-12-25 22:50 ` Aaron Tomlin
2025-12-25 22:33 ` Aaron Tomlin
2025-12-19 0:26 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf6b025b-cdbf-4d15-b56d-9f8434a57da4@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=atomlin@atomlin.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sean@ashe.io \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox