* [PATCH] clk: imx: set imx_clk_gpr_mux_ops storage-class-specifier to static
@ 2023-02-05 3:01 Tom Rix
2023-02-10 21:58 ` Stephen Boyd
2023-02-13 12:46 ` Peng Fan
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-02-05 3:01 UTC (permalink / raw)
To: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam,
linux-imx
Cc: linux-clk, linux-arm-kernel, linux-kernel, Tom Rix
smatch reports
drivers/clk/imx/clk-gpr-mux.c:73:22: warning: symbol 'imx_clk_gpr_mux_ops' was not declared. Should it be static?
imx_clk_gpr_mux_ops is only used in clk-gpr-mux.c, so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/clk/imx/clk-gpr-mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-gpr-mux.c b/drivers/clk/imx/clk-gpr-mux.c
index 47a3e3cdcc82..c8d6090f15d6 100644
--- a/drivers/clk/imx/clk-gpr-mux.c
+++ b/drivers/clk/imx/clk-gpr-mux.c
@@ -70,7 +70,7 @@ static int imx_clk_gpr_mux_determine_rate(struct clk_hw *hw,
return clk_mux_determine_rate_flags(hw, req, 0);
}
-const struct clk_ops imx_clk_gpr_mux_ops = {
+static const struct clk_ops imx_clk_gpr_mux_ops = {
.get_parent = imx_clk_gpr_mux_get_parent,
.set_parent = imx_clk_gpr_mux_set_parent,
.determine_rate = imx_clk_gpr_mux_determine_rate,
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: imx: set imx_clk_gpr_mux_ops storage-class-specifier to static
2023-02-05 3:01 [PATCH] clk: imx: set imx_clk_gpr_mux_ops storage-class-specifier to static Tom Rix
@ 2023-02-10 21:58 ` Stephen Boyd
2023-02-13 12:46 ` Peng Fan
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2023-02-10 21:58 UTC (permalink / raw)
To: Tom Rix, abelvesa, festevam, kernel, linux-imx, mturquette,
s.hauer, shawnguo
Cc: linux-clk, linux-arm-kernel, linux-kernel, Tom Rix
Quoting Tom Rix (2023-02-04 19:01:38)
> smatch reports
> drivers/clk/imx/clk-gpr-mux.c:73:22: warning: symbol 'imx_clk_gpr_mux_ops' was not declared. Should it be static?
>
> imx_clk_gpr_mux_ops is only used in clk-gpr-mux.c, so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: imx: set imx_clk_gpr_mux_ops storage-class-specifier to static
2023-02-05 3:01 [PATCH] clk: imx: set imx_clk_gpr_mux_ops storage-class-specifier to static Tom Rix
2023-02-10 21:58 ` Stephen Boyd
@ 2023-02-13 12:46 ` Peng Fan
1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2023-02-13 12:46 UTC (permalink / raw)
To: Tom Rix, abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel,
festevam, linux-imx
Cc: linux-clk, linux-arm-kernel, linux-kernel
On 2/5/2023 11:01 AM, Tom Rix wrote:
> smatch reports
> drivers/clk/imx/clk-gpr-mux.c:73:22: warning: symbol 'imx_clk_gpr_mux_ops' was not declared. Should it be static?
>
> imx_clk_gpr_mux_ops is only used in clk-gpr-mux.c, so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/clk/imx/clk-gpr-mux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-gpr-mux.c b/drivers/clk/imx/clk-gpr-mux.c
> index 47a3e3cdcc82..c8d6090f15d6 100644
> --- a/drivers/clk/imx/clk-gpr-mux.c
> +++ b/drivers/clk/imx/clk-gpr-mux.c
> @@ -70,7 +70,7 @@ static int imx_clk_gpr_mux_determine_rate(struct clk_hw *hw,
> return clk_mux_determine_rate_flags(hw, req, 0);
> }
>
> -const struct clk_ops imx_clk_gpr_mux_ops = {
> +static const struct clk_ops imx_clk_gpr_mux_ops = {
> .get_parent = imx_clk_gpr_mux_get_parent,
> .set_parent = imx_clk_gpr_mux_set_parent,
> .determine_rate = imx_clk_gpr_mux_determine_rate,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-13 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-05 3:01 [PATCH] clk: imx: set imx_clk_gpr_mux_ops storage-class-specifier to static Tom Rix
2023-02-10 21:58 ` Stephen Boyd
2023-02-13 12:46 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox