public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: "Adam J. Sypniewski" <ajsyp@syptech.net>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Arec Kao <arec.kao@intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: ov13b10: Add ACPI ID for ASUS Z13 Flow laptop
Date: Tue, 21 Oct 2025 17:49:27 +0200	[thread overview]
Message-ID: <c6b73659-bf0f-4967-ae21-c9f1a1401edb@kernel.org> (raw)
In-Reply-To: <aPeqy11m-TxwbzJV@garrus>

Hi,

On 21-Oct-25 17:46, Adam J. Sypniewski wrote:
> The ASUS ROG Flow Z13 2025 (GZ302) laptop uses an OV13B10 sensor with a
> non-standard ACPI ID of OMNI13B1 instead of the expected OVTI13B1.
> 
> Add this ACPI ID to the driver to make the front-facing camera work on
> these laptops.
> 
> Signed-off-by: Adam J. Sypniewski <ajsyp@syptech.net>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Regards,

Hans



> ---
> Changes in v2:
>  - Added comment explaining the ASUS-specific ACPI ID (Sakari)
> 
>  drivers/media/i2c/ov13b10.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c
> index 869bc78ed792..5421874732bc 100644
> --- a/drivers/media/i2c/ov13b10.c
> +++ b/drivers/media/i2c/ov13b10.c
> @@ -1693,6 +1693,7 @@ static DEFINE_RUNTIME_DEV_PM_OPS(ov13b10_pm_ops, ov13b10_suspend,
>  static const struct acpi_device_id ov13b10_acpi_ids[] = {
>  	{"OVTIDB10"},
>  	{"OVTI13B1"},
> +	{"OMNI13B1"},   /* ASUS ROG Flow Z13 (GZ302) uses this ACPI ID */
>  	{ /* sentinel */ }
>  };
>  
> 
> base-commit: 1fdb55ed40fa5ebe6934bd6b93036c714ebb5ef8


      reply	other threads:[~2025-10-21 15:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 14:44 [PATCH] media: ov13b10: Add ACPI ID for ASUS Z13 Flow laptop Adam J. Sypniewski
2025-10-21 14:54 ` Sakari Ailus
2025-10-21 15:46   ` [PATCH v2] " Adam J. Sypniewski
2025-10-21 15:49     ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6b73659-bf0f-4967-ae21-c9f1a1401edb@kernel.org \
    --to=hansg@kernel.org \
    --cc=ajsyp@syptech.net \
    --cc=arec.kao@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox