* [PATCH] media: ov13b10: Add ACPI ID for ASUS Z13 Flow laptop
@ 2025-10-21 14:44 Adam J. Sypniewski
2025-10-21 14:54 ` Sakari Ailus
0 siblings, 1 reply; 4+ messages in thread
From: Adam J. Sypniewski @ 2025-10-21 14:44 UTC (permalink / raw)
To: Sakari Ailus; +Cc: Arec Kao, Mauro Carvalho Chehab, linux-media, linux-kernel
The ASUS ROG Flow Z13 2025 (GZ302) laptop uses an OV13B10 sensor with a
non-standard ACPI ID of OMNI13B1 instead of the expected OVTI13B1.
Add this ACPI ID to the driver to make the front-facing camera work on
these laptops.
Signed-off-by: Adam J. Sypniewski <ajsyp@syptech.net>
---
drivers/media/i2c/ov13b10.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c
index 869bc78ed792..6ecd77d02b78 100644
--- a/drivers/media/i2c/ov13b10.c
+++ b/drivers/media/i2c/ov13b10.c
@@ -1693,6 +1693,7 @@ static DEFINE_RUNTIME_DEV_PM_OPS(ov13b10_pm_ops, ov13b10_suspend,
static const struct acpi_device_id ov13b10_acpi_ids[] = {
{"OVTIDB10"},
{"OVTI13B1"},
+ {"OMNI13B1"},
{ /* sentinel */ }
};
base-commit: 1fdb55ed40fa5ebe6934bd6b93036c714ebb5ef8
--
2.50.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: ov13b10: Add ACPI ID for ASUS Z13 Flow laptop
2025-10-21 14:44 [PATCH] media: ov13b10: Add ACPI ID for ASUS Z13 Flow laptop Adam J. Sypniewski
@ 2025-10-21 14:54 ` Sakari Ailus
2025-10-21 15:46 ` [PATCH v2] " Adam J. Sypniewski
0 siblings, 1 reply; 4+ messages in thread
From: Sakari Ailus @ 2025-10-21 14:54 UTC (permalink / raw)
To: Adam J. Sypniewski
Cc: Arec Kao, Mauro Carvalho Chehab, linux-media, linux-kernel
Hi Adam,
On Tue, Oct 21, 2025 at 10:44:05AM -0400, Adam J. Sypniewski wrote:
> The ASUS ROG Flow Z13 2025 (GZ302) laptop uses an OV13B10 sensor with a
> non-standard ACPI ID of OMNI13B1 instead of the expected OVTI13B1.
>
> Add this ACPI ID to the driver to make the front-facing camera work on
> these laptops.
>
> Signed-off-by: Adam J. Sypniewski <ajsyp@syptech.net>
> ---
> drivers/media/i2c/ov13b10.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c
> index 869bc78ed792..6ecd77d02b78 100644
> --- a/drivers/media/i2c/ov13b10.c
> +++ b/drivers/media/i2c/ov13b10.c
> @@ -1693,6 +1693,7 @@ static DEFINE_RUNTIME_DEV_PM_OPS(ov13b10_pm_ops, ov13b10_suspend,
> static const struct acpi_device_id ov13b10_acpi_ids[] = {
> {"OVTIDB10"},
> {"OVTI13B1"},
> + {"OMNI13B1"},
Can you include a comment for this line, explaining why this ID is here?
> { /* sentinel */ }
> };
>
>
> base-commit: 1fdb55ed40fa5ebe6934bd6b93036c714ebb5ef8
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] media: ov13b10: Add ACPI ID for ASUS Z13 Flow laptop
2025-10-21 14:54 ` Sakari Ailus
@ 2025-10-21 15:46 ` Adam J. Sypniewski
2025-10-21 15:49 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Adam J. Sypniewski @ 2025-10-21 15:46 UTC (permalink / raw)
To: Sakari Ailus; +Cc: Arec Kao, Mauro Carvalho Chehab, linux-media, linux-kernel
The ASUS ROG Flow Z13 2025 (GZ302) laptop uses an OV13B10 sensor with a
non-standard ACPI ID of OMNI13B1 instead of the expected OVTI13B1.
Add this ACPI ID to the driver to make the front-facing camera work on
these laptops.
Signed-off-by: Adam J. Sypniewski <ajsyp@syptech.net>
---
Changes in v2:
- Added comment explaining the ASUS-specific ACPI ID (Sakari)
drivers/media/i2c/ov13b10.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c
index 869bc78ed792..5421874732bc 100644
--- a/drivers/media/i2c/ov13b10.c
+++ b/drivers/media/i2c/ov13b10.c
@@ -1693,6 +1693,7 @@ static DEFINE_RUNTIME_DEV_PM_OPS(ov13b10_pm_ops, ov13b10_suspend,
static const struct acpi_device_id ov13b10_acpi_ids[] = {
{"OVTIDB10"},
{"OVTI13B1"},
+ {"OMNI13B1"}, /* ASUS ROG Flow Z13 (GZ302) uses this ACPI ID */
{ /* sentinel */ }
};
base-commit: 1fdb55ed40fa5ebe6934bd6b93036c714ebb5ef8
--
2.50.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] media: ov13b10: Add ACPI ID for ASUS Z13 Flow laptop
2025-10-21 15:46 ` [PATCH v2] " Adam J. Sypniewski
@ 2025-10-21 15:49 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2025-10-21 15:49 UTC (permalink / raw)
To: Adam J. Sypniewski, Sakari Ailus
Cc: Arec Kao, Mauro Carvalho Chehab, linux-media, linux-kernel
Hi,
On 21-Oct-25 17:46, Adam J. Sypniewski wrote:
> The ASUS ROG Flow Z13 2025 (GZ302) laptop uses an OV13B10 sensor with a
> non-standard ACPI ID of OMNI13B1 instead of the expected OVTI13B1.
>
> Add this ACPI ID to the driver to make the front-facing camera work on
> these laptops.
>
> Signed-off-by: Adam J. Sypniewski <ajsyp@syptech.net>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hansg@kernel.org>
Regards,
Hans
> ---
> Changes in v2:
> - Added comment explaining the ASUS-specific ACPI ID (Sakari)
>
> drivers/media/i2c/ov13b10.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c
> index 869bc78ed792..5421874732bc 100644
> --- a/drivers/media/i2c/ov13b10.c
> +++ b/drivers/media/i2c/ov13b10.c
> @@ -1693,6 +1693,7 @@ static DEFINE_RUNTIME_DEV_PM_OPS(ov13b10_pm_ops, ov13b10_suspend,
> static const struct acpi_device_id ov13b10_acpi_ids[] = {
> {"OVTIDB10"},
> {"OVTI13B1"},
> + {"OMNI13B1"}, /* ASUS ROG Flow Z13 (GZ302) uses this ACPI ID */
> { /* sentinel */ }
> };
>
>
> base-commit: 1fdb55ed40fa5ebe6934bd6b93036c714ebb5ef8
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-21 15:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-21 14:44 [PATCH] media: ov13b10: Add ACPI ID for ASUS Z13 Flow laptop Adam J. Sypniewski
2025-10-21 14:54 ` Sakari Ailus
2025-10-21 15:46 ` [PATCH v2] " Adam J. Sypniewski
2025-10-21 15:49 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox