* [PATCH] ftrace: Fix function name for trampoline
@ 2024-10-10 13:02 Tatsuya S
2024-10-10 15:02 ` Steven Rostedt
2024-10-10 15:03 ` Masami Hiramatsu
0 siblings, 2 replies; 5+ messages in thread
From: Tatsuya S @ 2024-10-10 13:02 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers
Cc: Tatsuya S, linux-kernel, linux-trace-kernel
The issue that unrelated function name is shown on stack trace like
following even though it should be trampoline code address is caused by
the creation of trampoline code in the area where .init.text section
of module was freed after module is loaded.
bash-1344 [002] ..... 43.644608: <stack trace>
=> (MODULE INIT FUNCTION)
=> vfs_write
=> ksys_write
=> do_syscall_64
=> entry_SYSCALL_64_after_hwframe
To resolve this, when function address of stack trace entry is in
trampoline, output without looking up symbol name.
Signed-off-by: Tatsuya S <tatsuya.s2862@gmail.com>
---
kernel/trace/trace_output.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 868f2f912f28..32a0858373e2 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -1246,6 +1246,11 @@ static enum print_line_t trace_stack_print(struct trace_iterator *iter,
break;
trace_seq_puts(s, " => ");
+ if (is_ftrace_trampoline((*p) + delta)) {
+ trace_seq_printf(s, "0x%08lx", (*p) + delta);
+ trace_seq_putc(s, '\n');
+ continue;
+ }
seq_print_ip_sym(s, (*p) + delta, flags);
trace_seq_putc(s, '\n');
}
--
2.46.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ftrace: Fix function name for trampoline
2024-10-10 13:02 [PATCH] ftrace: Fix function name for trampoline Tatsuya S
@ 2024-10-10 15:02 ` Steven Rostedt
2024-10-11 7:34 ` Tatsuya S
2024-10-10 15:03 ` Masami Hiramatsu
1 sibling, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2024-10-10 15:02 UTC (permalink / raw)
To: Tatsuya S
Cc: Masami Hiramatsu, Mathieu Desnoyers, linux-kernel,
linux-trace-kernel
On Thu, 10 Oct 2024 22:02:59 +0900
Tatsuya S <tatsuya.s2862@gmail.com> wrote:
> The issue that unrelated function name is shown on stack trace like
> following even though it should be trampoline code address is caused by
> the creation of trampoline code in the area where .init.text section
> of module was freed after module is loaded.
>
> bash-1344 [002] ..... 43.644608: <stack trace>
> => (MODULE INIT FUNCTION)
> => vfs_write
> => ksys_write
> => do_syscall_64
> => entry_SYSCALL_64_after_hwframe
>
> To resolve this, when function address of stack trace entry is in
> trampoline, output without looking up symbol name.
>
> Signed-off-by: Tatsuya S <tatsuya.s2862@gmail.com>
> ---
> kernel/trace/trace_output.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
> index 868f2f912f28..32a0858373e2 100644
> --- a/kernel/trace/trace_output.c
> +++ b/kernel/trace/trace_output.c
> @@ -1246,6 +1246,11 @@ static enum print_line_t trace_stack_print(struct trace_iterator *iter,
> break;
>
> trace_seq_puts(s, " => ");
> + if (is_ftrace_trampoline((*p) + delta)) {
This is not reliable. The output is called when the user reads the trace
file and the ops may no longer exist.
The only way to test this is if you call it during the trace. Yes it may
slow things down a little, but it will be accurate.
-- Steve
> + trace_seq_printf(s, "0x%08lx", (*p) + delta);
> + trace_seq_putc(s, '\n');
> + continue;
> + }
> seq_print_ip_sym(s, (*p) + delta, flags);
> trace_seq_putc(s, '\n');
> }
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ftrace: Fix function name for trampoline
2024-10-10 15:02 ` Steven Rostedt
@ 2024-10-11 7:34 ` Tatsuya S
0 siblings, 0 replies; 5+ messages in thread
From: Tatsuya S @ 2024-10-11 7:34 UTC (permalink / raw)
To: Steven Rostedt
Cc: Masami Hiramatsu, Mathieu Desnoyers, linux-kernel,
linux-trace-kernel
On 10/11/24 12:02 AM, Steven Rostedt wrote:
> On Thu, 10 Oct 2024 22:02:59 +0900
> Tatsuya S <tatsuya.s2862@gmail.com> wrote:
>
>> The issue that unrelated function name is shown on stack trace like
>> following even though it should be trampoline code address is caused by
>> the creation of trampoline code in the area where .init.text section
>> of module was freed after module is loaded.
>>
>> bash-1344 [002] ..... 43.644608: <stack trace>
>> => (MODULE INIT FUNCTION)
>> => vfs_write
>> => ksys_write
>> => do_syscall_64
>> => entry_SYSCALL_64_after_hwframe
>>
>> To resolve this, when function address of stack trace entry is in
>> trampoline, output without looking up symbol name.
>>
>> Signed-off-by: Tatsuya S <tatsuya.s2862@gmail.com>
>> ---
>> kernel/trace/trace_output.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
>> index 868f2f912f28..32a0858373e2 100644
>> --- a/kernel/trace/trace_output.c
>> +++ b/kernel/trace/trace_output.c
>> @@ -1246,6 +1246,11 @@ static enum print_line_t trace_stack_print(struct trace_iterator *iter,
>> break;
>>
>> trace_seq_puts(s, " => ");
>> + if (is_ftrace_trampoline((*p) + delta)) {
Thank you for review.
>
> This is not reliable. The output is called when the user reads the trace
> file and the ops may no longer exist.
>
> The only way to test this is if you call it during the trace. Yes it may
> slow things down a little, but it will be accurate.
OK, I will do it.
>
> -- Steve
>
>
>> + trace_seq_printf(s, "0x%08lx", (*p) + delta);
>> + trace_seq_putc(s, '\n');
>> + continue;
>> + }
>> seq_print_ip_sym(s, (*p) + delta, flags);
>> trace_seq_putc(s, '\n');
>> }
>
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftrace: Fix function name for trampoline
2024-10-10 13:02 [PATCH] ftrace: Fix function name for trampoline Tatsuya S
2024-10-10 15:02 ` Steven Rostedt
@ 2024-10-10 15:03 ` Masami Hiramatsu
2024-10-11 6:34 ` Tatsuya S
1 sibling, 1 reply; 5+ messages in thread
From: Masami Hiramatsu @ 2024-10-10 15:03 UTC (permalink / raw)
To: Tatsuya S
Cc: Steven Rostedt, Mathieu Desnoyers, linux-kernel,
linux-trace-kernel
On Thu, 10 Oct 2024 22:02:59 +0900
Tatsuya S <tatsuya.s2862@gmail.com> wrote:
> The issue that unrelated function name is shown on stack trace like
> following even though it should be trampoline code address is caused by
> the creation of trampoline code in the area where .init.text section
> of module was freed after module is loaded.
>
> bash-1344 [002] ..... 43.644608: <stack trace>
> => (MODULE INIT FUNCTION)
> => vfs_write
> => ksys_write
> => do_syscall_64
> => entry_SYSCALL_64_after_hwframe
>
> To resolve this, when function address of stack trace entry is in
> trampoline, output without looking up symbol name.
>
> Signed-off-by: Tatsuya S <tatsuya.s2862@gmail.com>
> ---
> kernel/trace/trace_output.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
> index 868f2f912f28..32a0858373e2 100644
> --- a/kernel/trace/trace_output.c
> +++ b/kernel/trace/trace_output.c
> @@ -1246,6 +1246,11 @@ static enum print_line_t trace_stack_print(struct trace_iterator *iter,
> break;
>
> trace_seq_puts(s, " => ");
> + if (is_ftrace_trampoline((*p) + delta)) {
> + trace_seq_printf(s, "0x%08lx", (*p) + delta);
If we know that address is the ftrace trampoline, we'd better show something
like "[FTRACE TRAMPOLINE]"
> + trace_seq_putc(s, '\n');
And this is not needed. So for example,
trace_seq_puts(s, "[FTRACE TRAMPOLINE]\n");
is enough.
> + continue;
> + }
> seq_print_ip_sym(s, (*p) + delta, flags);
> trace_seq_putc(s, '\n');
> }
Thank you,
> --
> 2.46.2
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ftrace: Fix function name for trampoline
2024-10-10 15:03 ` Masami Hiramatsu
@ 2024-10-11 6:34 ` Tatsuya S
0 siblings, 0 replies; 5+ messages in thread
From: Tatsuya S @ 2024-10-11 6:34 UTC (permalink / raw)
To: Masami Hiramatsu (Google)
Cc: Steven Rostedt, Mathieu Desnoyers, linux-kernel,
linux-trace-kernel
On 10/11/24 12:03 AM, Masami Hiramatsu (Google) wrote:
> On Thu, 10 Oct 2024 22:02:59 +0900
> Tatsuya S <tatsuya.s2862@gmail.com> wrote:
>
>> The issue that unrelated function name is shown on stack trace like
>> following even though it should be trampoline code address is caused by
>> the creation of trampoline code in the area where .init.text section
>> of module was freed after module is loaded.
>>
>> bash-1344 [002] ..... 43.644608: <stack trace>
>> => (MODULE INIT FUNCTION)
>> => vfs_write
>> => ksys_write
>> => do_syscall_64
>> => entry_SYSCALL_64_after_hwframe
>>
>> To resolve this, when function address of stack trace entry is in
>> trampoline, output without looking up symbol name.
>>
>> Signed-off-by: Tatsuya S <tatsuya.s2862@gmail.com>
>> ---
>> kernel/trace/trace_output.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
>> index 868f2f912f28..32a0858373e2 100644
>> --- a/kernel/trace/trace_output.c
>> +++ b/kernel/trace/trace_output.c
>> @@ -1246,6 +1246,11 @@ static enum print_line_t trace_stack_print(struct trace_iterator *iter,
>> break;
>>
>> trace_seq_puts(s, " => ");
>> + if (is_ftrace_trampoline((*p) + delta)) {
>> + trace_seq_printf(s, "0x%08lx", (*p) + delta);
>
> If we know that address is the ftrace trampoline, we'd better show something
> like "[FTRACE TRAMPOLINE]"
>
>> + trace_seq_putc(s, '\n');
>
> And this is not needed. So for example,
>
> trace_seq_puts(s, "[FTRACE TRAMPOLINE]\n");
>
> is enough.
Thanks for review. OK.
>
>> + continue;
>> + }
>> seq_print_ip_sym(s, (*p) + delta, flags);
>> trace_seq_putc(s, '\n');
>> }
>
> Thank you,
>
>> --
>> 2.46.2
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-11 7:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-10 13:02 [PATCH] ftrace: Fix function name for trampoline Tatsuya S
2024-10-10 15:02 ` Steven Rostedt
2024-10-11 7:34 ` Tatsuya S
2024-10-10 15:03 ` Masami Hiramatsu
2024-10-11 6:34 ` Tatsuya S
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox