* [PATCH -next] drm/ast: make ast_modeset static
@ 2022-09-26 2:32 ruanjinjie
2022-09-26 7:16 ` Thomas Zimmermann
0 siblings, 1 reply; 3+ messages in thread
From: ruanjinjie @ 2022-09-26 2:32 UTC (permalink / raw)
To: airlied, tzimmermann, airlied, daniel, dri-devel, linux-kernel; +Cc: ruanjinjie
The symbol is not used outside of the file, so mark it static.
Fixes the following warning:
drivers/gpu/drm/ast/ast_drv.c:42:5: warning: symbol 'ast_modeset'
was not declared. Should it be static?
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
---
drivers/gpu/drm/ast/ast_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index 760b27971557..b9392f31e629 100644
--- a/drivers/gpu/drm/ast/ast_drv.c
+++ b/drivers/gpu/drm/ast/ast_drv.c
@@ -39,7 +39,7 @@
#include "ast_drv.h"
-int ast_modeset = -1;
+static int ast_modeset = -1;
MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
module_param_named(modeset, ast_modeset, int, 0400);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/ast: make ast_modeset static
2022-09-26 2:32 [PATCH -next] drm/ast: make ast_modeset static ruanjinjie
@ 2022-09-26 7:16 ` Thomas Zimmermann
2022-09-26 7:38 ` Ruan Jinjie
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Zimmermann @ 2022-09-26 7:16 UTC (permalink / raw)
To: ruanjinjie, airlied, airlied, daniel, dri-devel, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1122 bytes --]
Hi
Am 26.09.22 um 04:32 schrieb ruanjinjie:
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> drivers/gpu/drm/ast/ast_drv.c:42:5: warning: symbol 'ast_modeset'
> was not declared. Should it be static?
>
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Thank you. Added to drm-misc-next.
Best regards
Thomas
> ---
> drivers/gpu/drm/ast/ast_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
> index 760b27971557..b9392f31e629 100644
> --- a/drivers/gpu/drm/ast/ast_drv.c
> +++ b/drivers/gpu/drm/ast/ast_drv.c
> @@ -39,7 +39,7 @@
>
> #include "ast_drv.h"
>
> -int ast_modeset = -1;
> +static int ast_modeset = -1;
>
> MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
> module_param_named(modeset, ast_modeset, int, 0400);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/ast: make ast_modeset static
2022-09-26 7:16 ` Thomas Zimmermann
@ 2022-09-26 7:38 ` Ruan Jinjie
0 siblings, 0 replies; 3+ messages in thread
From: Ruan Jinjie @ 2022-09-26 7:38 UTC (permalink / raw)
To: Thomas Zimmermann, airlied, airlied, daniel, dri-devel,
linux-kernel
Thank you very much!
On 2022/9/26 15:16, Thomas Zimmermann wrote:
> Hi
>
> Am 26.09.22 um 04:32 schrieb ruanjinjie:
>> The symbol is not used outside of the file, so mark it static.
>>
>> Fixes the following warning:
>>
>> drivers/gpu/drm/ast/ast_drv.c:42:5: warning: symbol 'ast_modeset'
>> was not declared. Should it be static?
>>
>> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
>
> Thank you. Added to drm-misc-next.
>
> Best regards
> Thomas
>
>> ---
>> drivers/gpu/drm/ast/ast_drv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_drv.c
>> b/drivers/gpu/drm/ast/ast_drv.c
>> index 760b27971557..b9392f31e629 100644
>> --- a/drivers/gpu/drm/ast/ast_drv.c
>> +++ b/drivers/gpu/drm/ast/ast_drv.c
>> @@ -39,7 +39,7 @@
>> #include "ast_drv.h"
>> -int ast_modeset = -1;
>> +static int ast_modeset = -1;
>> MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>> module_param_named(modeset, ast_modeset, int, 0400);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-26 7:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-26 2:32 [PATCH -next] drm/ast: make ast_modeset static ruanjinjie
2022-09-26 7:16 ` Thomas Zimmermann
2022-09-26 7:38 ` Ruan Jinjie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox