The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] regulator: mcp16502: add enum MCP16502_REG_HPM description
@ 2023-01-17  7:01 Randy Dunlap
  2023-01-17  8:32 ` Claudiu.Beznea
  2023-01-18 14:55 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-01-17  7:01 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Andrei Stefanescu, Claudiu Beznea, Mark Brown,
	linux-arm-kernel

Add description for MCP16502_REG_HPM to prevent a kernel-doc warning:

drivers/regulator/mcp16502.c:90: warning: Enum value 'MCP16502_REG_HPM' not described in enum 'mcp16502_reg'

Fixes: 3e5532a011b0 ("regulator: mcp16502: adapt for get/set on other registers")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrei Stefanescu <andrei.stefanescu@microchip.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/regulator/mcp16502.c |    1 +
 1 file changed, 1 insertion(+)

diff -- a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c
--- a/drivers/regulator/mcp16502.c
+++ b/drivers/regulator/mcp16502.c
@@ -77,6 +77,7 @@
  * @MCP16502_REG_A: active state register
  * @MCP16502_REG_LPM: low power mode state register
  * @MCP16502_REG_HIB: hibernate state register
+ * @MCP16502_REG_HPM: high-performance mode register
  * @MCP16502_REG_SEQ: startup sequence register
  * @MCP16502_REG_CFG: configuration register
  */

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: mcp16502: add enum MCP16502_REG_HPM description
  2023-01-17  7:01 [PATCH] regulator: mcp16502: add enum MCP16502_REG_HPM description Randy Dunlap
@ 2023-01-17  8:32 ` Claudiu.Beznea
  2023-01-18 14:55 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Claudiu.Beznea @ 2023-01-17  8:32 UTC (permalink / raw)
  To: rdunlap, linux-kernel; +Cc: andrei.stefanescu, broonie, linux-arm-kernel

On 17.01.2023 09:01, Randy Dunlap wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Add description for MCP16502_REG_HPM to prevent a kernel-doc warning:
> 
> drivers/regulator/mcp16502.c:90: warning: Enum value 'MCP16502_REG_HPM' not described in enum 'mcp16502_reg'
> 
> Fixes: 3e5532a011b0 ("regulator: mcp16502: adapt for get/set on other registers")

Fixes tag could be removed as this isn't a functional fix.

With that addressed:
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andrei Stefanescu <andrei.stefanescu@microchip.com>
> Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  drivers/regulator/mcp16502.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c
> --- a/drivers/regulator/mcp16502.c
> +++ b/drivers/regulator/mcp16502.c
> @@ -77,6 +77,7 @@
>   * @MCP16502_REG_A: active state register
>   * @MCP16502_REG_LPM: low power mode state register
>   * @MCP16502_REG_HIB: hibernate state register
> + * @MCP16502_REG_HPM: high-performance mode register
>   * @MCP16502_REG_SEQ: startup sequence register
>   * @MCP16502_REG_CFG: configuration register
>   */


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: mcp16502: add enum MCP16502_REG_HPM description
  2023-01-17  7:01 [PATCH] regulator: mcp16502: add enum MCP16502_REG_HPM description Randy Dunlap
  2023-01-17  8:32 ` Claudiu.Beznea
@ 2023-01-18 14:55 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2023-01-18 14:55 UTC (permalink / raw)
  To: linux-kernel, Randy Dunlap
  Cc: Andrei Stefanescu, Claudiu Beznea, linux-arm-kernel

On Mon, 16 Jan 2023 23:01:39 -0800, Randy Dunlap wrote:
> Add description for MCP16502_REG_HPM to prevent a kernel-doc warning:
> 
> drivers/regulator/mcp16502.c:90: warning: Enum value 'MCP16502_REG_HPM' not described in enum 'mcp16502_reg'
> 
> 

Applied to

   broonie/regulator.git for-next

Thanks!

[1/1] regulator: mcp16502: add enum MCP16502_REG_HPM description
      commit: 84c13763f2a22acc31472dccde8b6130b8f2e9c2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-18 15:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-17  7:01 [PATCH] regulator: mcp16502: add enum MCP16502_REG_HPM description Randy Dunlap
2023-01-17  8:32 ` Claudiu.Beznea
2023-01-18 14:55 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox