The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Manush Prajwal <manushprajwal555@gmail.com>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Angelo Gioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	"Jason-JH.Lin" <jason-jh.lin@mediatek.com>,
	Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH] mailbox: mtk-cmdq: fix runtime PM usage counter leak in cmdq_mbox_flush
Date: Mon, 24 Aug 2026 07:43:36 +0200	[thread overview]
Message-ID: <caa6ad68-9f9a-45b0-81ce-cdbeceb8d454@web.de> (raw)
In-Reply-To: <20260823112321.2039-1-manushprajwal555@gmail.com>

…
> Fix it by calling pm_runtime_put_noidle() before returning, matching
> the pattern used by other pm_runtime_get_sync() callers in the same
> subsystem (e.g. …).

How do you think about to use the function “pm_runtime_resume_and_get” instead?
https://elixir.bootlin.com/linux/v7.2/source/include/linux/pm_runtime.h#L530-L540

https://elixir.bootlin.com/linux/v7.2/source/drivers/mailbox/mtk-cmdq-mailbox.c#L557-L611

Regards,
Markus

      reply	other threads:[~2026-08-24  5:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 11:23 [PATCH] mailbox: mtk-cmdq: fix runtime PM usage counter leak in cmdq_mbox_flush manushprajwal
2026-08-24  5:43 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=caa6ad68-9f9a-45b0-81ce-cdbeceb8d454@web.de \
    --to=markus.elfring@web.de \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=jason-jh.lin@mediatek.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=jaswinder.singh@linaro.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=manushprajwal555@gmail.com \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox