* [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"
@ 2026-04-19 17:08 Ninad Naik
2026-04-19 22:10 ` Mark Pearson
0 siblings, 1 reply; 5+ messages in thread
From: Ninad Naik @ 2026-04-19 17:08 UTC (permalink / raw)
To: mpearson-lenovo, derekjohn.clark, W_Armin, corbet, skhan
Cc: platform-driver-x86, linux-doc, linux-kernel, me,
linux-kernel-mentees, Ninad Naik
There is a spelling mistake in Documentation/wmi/devices/lenovo-wmi-other.rst.
Fixing it.
Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
---
Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst b/Documentation/wmi/devices/lenovo-wmi-other.rst
index 01d471156738..1d0410500d3f 100644
--- a/Documentation/wmi/devices/lenovo-wmi-other.rst
+++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
@@ -144,5 +144,5 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
[WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
[WmiDataId(2), read, Description("Fan ID."), WmiSizeIs("NumOfFans")] uint32 FanId[];
[WmiDataId(3), read, Description("Maximum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
- [WmiDataId(4), read, Description("Minumum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
+ [WmiDataId(4), read, Description("Minimum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
};
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"
2026-04-19 17:08 [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum" Ninad Naik
@ 2026-04-19 22:10 ` Mark Pearson
2026-04-19 22:24 ` Derek J. Clark
0 siblings, 1 reply; 5+ messages in thread
From: Mark Pearson @ 2026-04-19 22:10 UTC (permalink / raw)
To: Ninad Naik, Derek J . Clark, Armin Wolf, Jonathan Corbet, skhan
Cc: platform-driver-x86@vger.kernel.org, linux-doc, linux-kernel, me,
linux-kernel-mentees
On Sun, Apr 19, 2026, at 1:08 PM, Ninad Naik wrote:
> There is a spelling mistake in Documentation/wmi/devices/lenovo-wmi-other.rst.
> Fixing it.
>
> Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
> ---
> Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst
> b/Documentation/wmi/devices/lenovo-wmi-other.rst
> index 01d471156738..1d0410500d3f 100644
> --- a/Documentation/wmi/devices/lenovo-wmi-other.rst
> +++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
> @@ -144,5 +144,5 @@ data using the `bmfdec
> <https://github.com/pali/bmfdec>`_ utility:
> [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
> [WmiDataId(2), read, Description("Fan ID."),
> WmiSizeIs("NumOfFans")] uint32 FanId[];
> [WmiDataId(3), read, Description("Maximum Fan Speed."),
> WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
> - [WmiDataId(4), read, Description("Minumum Fan Speed."),
> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
> + [WmiDataId(4), read, Description("Minimum Fan Speed."),
> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
> };
> --
> 2.53.0
Looks good.
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"
2026-04-19 22:10 ` Mark Pearson
@ 2026-04-19 22:24 ` Derek J. Clark
2026-04-20 6:47 ` Jonathan Corbet
0 siblings, 1 reply; 5+ messages in thread
From: Derek J. Clark @ 2026-04-19 22:24 UTC (permalink / raw)
To: Mark Pearson, Ninad Naik, Armin Wolf, Jonathan Corbet, skhan
Cc: platform-driver-x86@vger.kernel.org, linux-doc, linux-kernel, me,
linux-kernel-mentees
On April 19, 2026 3:10:08 PM PDT, Mark Pearson <mpearson-lenovo@squebb.ca> wrote:
>
>
>On Sun, Apr 19, 2026, at 1:08 PM, Ninad Naik wrote:
>> There is a spelling mistake in Documentation/wmi/devices/lenovo-wmi-other.rst.
>> Fixing it.
>>
>> Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
>> ---
>> Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst
>> b/Documentation/wmi/devices/lenovo-wmi-other.rst
>> index 01d471156738..1d0410500d3f 100644
>> --- a/Documentation/wmi/devices/lenovo-wmi-other.rst
>> +++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
>> @@ -144,5 +144,5 @@ data using the `bmfdec
>> <https://github.com/pali/bmfdec>`_ utility:
>> [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
>> [WmiDataId(2), read, Description("Fan ID."),
>> WmiSizeIs("NumOfFans")] uint32 FanId[];
>> [WmiDataId(3), read, Description("Maximum Fan Speed."),
>> WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
>> - [WmiDataId(4), read, Description("Minumum Fan Speed."),
>> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
>> + [WmiDataId(4), read, Description("Minimum Fan Speed."),
>> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
>> };
>> --
>> 2.53.0
>Looks good.
>Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Hi gents,
The MOF spelling mistakes are well known. We've left them is as to ensure match with what the hardware actually reports.
See: https://lore.kernel.org/platform-driver-x86/cfd7977e-d612-4e08-a68a-65fed8e164b6@gmx.de
I suppose if we're going to continue getting these types or PR I should add a note to the documentation. I'll add that soon.
Thanks,
Derek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"
2026-04-19 22:24 ` Derek J. Clark
@ 2026-04-20 6:47 ` Jonathan Corbet
2026-04-20 18:07 ` Mark Pearson
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Corbet @ 2026-04-20 6:47 UTC (permalink / raw)
To: Derek J. Clark, Mark Pearson, Ninad Naik, Armin Wolf, skhan
Cc: platform-driver-x86@vger.kernel.org, linux-doc, linux-kernel, me,
linux-kernel-mentees
"Derek J. Clark" <derekjohn.clark@gmail.com> writes:
> The MOF spelling mistakes are well known. We've left them is as to
> ensure match with what the hardware actually reports.
>
> See: https://lore.kernel.org/platform-driver-x86/cfd7977e-d612-4e08-a68a-65fed8e164b6@gmx.de
>
> I suppose if we're going to continue getting these types or PR I
> should add a note to the documentation. I'll add that soon.
Perhaps worth adding, but I'm not sure I would expect it to help. The
people generating these patches aren't putting much attention into the
context surrounding them.
Thanks,
jon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"
2026-04-20 6:47 ` Jonathan Corbet
@ 2026-04-20 18:07 ` Mark Pearson
0 siblings, 0 replies; 5+ messages in thread
From: Mark Pearson @ 2026-04-20 18:07 UTC (permalink / raw)
To: Jonathan Corbet, Derek J . Clark, Ninad Naik, Armin Wolf, skhan
Cc: platform-driver-x86@vger.kernel.org, linux-doc, linux-kernel, me,
linux-kernel-mentees
On Mon, Apr 20, 2026, at 2:47 AM, Jonathan Corbet wrote:
> "Derek J. Clark" <derekjohn.clark@gmail.com> writes:
>
>> The MOF spelling mistakes are well known. We've left them is as to
>> ensure match with what the hardware actually reports.
>>
>> See: https://lore.kernel.org/platform-driver-x86/cfd7977e-d612-4e08-a68a-65fed8e164b6@gmx.de
>>
>> I suppose if we're going to continue getting these types or PR I
>> should add a note to the documentation. I'll add that soon.
>
> Perhaps worth adding, but I'm not sure I would expect it to help. The
> people generating these patches aren't putting much attention into the
> context surrounding them.
>
I'd forgotten that previous discussion - sorry.
Part of the problem (I know I had this many years ago when I got started) is being told the best way to get involved in kernel development and learn the process is to find small things to fix (spelling mistakes, documentation, comments etc). I suspect that's accelerated with AI identifying them too :)
What if we fix the typo, and add a comment highlighting that the vendor documentation/MOF/whatever is wrong? Then everybody is 'happy'? (or at least we'll get less emails about it)
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-20 18:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-19 17:08 [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum" Ninad Naik
2026-04-19 22:10 ` Mark Pearson
2026-04-19 22:24 ` Derek J. Clark
2026-04-20 6:47 ` Jonathan Corbet
2026-04-20 18:07 ` Mark Pearson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox