* [PATCH] greybus: BeaglePlay driver needs CRC_CCITT
@ 2023-10-31 4:09 Randy Dunlap
2023-10-31 6:01 ` Ayush Singh
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-10-31 4:09 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Ayush Singh, Greg Kroah-Hartman, Johan Hovold,
Alex Elder, greybus-dev
The gb-beagleplay driver uses crc_ccitt(), so it should select
CRC_CCITT to make sure that the function is available.
Fixes these build errors:
s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
gb-beagleplay.c:(.text+0x2c0): undefined reference to `crc_ccitt'
s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_rx_frame':
gb-beagleplay.c:(.text+0x6a0): undefined reference to `crc_ccitt'
Fixes: ec558bbfea67 ("greybus: Add BeaglePlay Linux Driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Ayush Singh <ayushdevel1325@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>
Cc: Alex Elder <elder@kernel.org>
Cc: greybus-dev@lists.linaro.org
---
drivers/greybus/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
--- a/drivers/greybus/Kconfig
+++ b/drivers/greybus/Kconfig
@@ -20,6 +20,7 @@ if GREYBUS
config GREYBUS_BEAGLEPLAY
tristate "Greybus BeaglePlay driver"
depends on SERIAL_DEV_BUS
+ select CRC_CCITT
help
Select this option if you have a BeaglePlay where CC1352
co-processor acts as Greybus SVC.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] greybus: BeaglePlay driver needs CRC_CCITT
2023-10-31 4:09 [PATCH] greybus: BeaglePlay driver needs CRC_CCITT Randy Dunlap
@ 2023-10-31 6:01 ` Ayush Singh
0 siblings, 0 replies; 2+ messages in thread
From: Ayush Singh @ 2023-10-31 6:01 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Greg Kroah-Hartman, Johan Hovold, Alex Elder, greybus-dev
On 10/31/23 09:39, Randy Dunlap wrote:
> The gb-beagleplay driver uses crc_ccitt(), so it should select
> CRC_CCITT to make sure that the function is available.
>
> Fixes these build errors:
>
> s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
> gb-beagleplay.c:(.text+0x2c0): undefined reference to `crc_ccitt'
> s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_rx_frame':
> gb-beagleplay.c:(.text+0x6a0): undefined reference to `crc_ccitt'
>
> Fixes: ec558bbfea67 ("greybus: Add BeaglePlay Linux Driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Ayush Singh <ayushdevel1325@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: greybus-dev@lists.linaro.org
> ---
> drivers/greybus/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
> --- a/drivers/greybus/Kconfig
> +++ b/drivers/greybus/Kconfig
> @@ -20,6 +20,7 @@ if GREYBUS
> config GREYBUS_BEAGLEPLAY
> tristate "Greybus BeaglePlay driver"
> depends on SERIAL_DEV_BUS
> + select CRC_CCITT
> help
> Select this option if you have a BeaglePlay where CC1352
> co-processor acts as Greybus SVC.
Thanks.
Reviewed-by: Ayush Singh <ayushdevel1325@gmail.com>
Ayush Singh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-31 6:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-31 4:09 [PATCH] greybus: BeaglePlay driver needs CRC_CCITT Randy Dunlap
2023-10-31 6:01 ` Ayush Singh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox