From: Mario Limonciello <superm1@kernel.org>
To: Lizhi Hou <lizhi.hou@amd.com>,
ogabbay@kernel.org, quic_jhugo@quicinc.com,
dri-devel@lists.freedesktop.org,
maciej.falkowski@linux.intel.com
Cc: Nishad Saraf <nishads@amd.com>,
linux-kernel@vger.kernel.org, max.zhen@amd.com,
sonal.santan@amd.com
Subject: Re: [PATCH V1 3/3] accel/amdxdna: Set the system efficiency factor to 2
Date: Fri, 24 Apr 2026 08:30:19 -0500 [thread overview]
Message-ID: <cdd649b8-db85-4bfb-8c0f-2a099201f89a@kernel.org> (raw)
In-Reply-To: <20260424040824.2253607-3-lizhi.hou@amd.com>
On 4/23/26 23:08, Lizhi Hou wrote:
> From: Nishad Saraf <nishads@amd.com>
>
> The system efficiency factor is used for QoS calculation. Change it to 2
> to account for the efficiency overhead.
>
> Signed-off-by: Nishad Saraf <nishads@amd.com>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
> drivers/accel/amdxdna/aie2_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c
> index a07e453a1721..f0ddb843eb21 100644
> --- a/drivers/accel/amdxdna/aie2_pci.c
> +++ b/drivers/accel/amdxdna/aie2_pci.c
> @@ -595,7 +595,7 @@ static int aie2_init(struct amdxdna_dev *xdna)
> xrs_cfg.clk_list.num_levels = ndev->max_dpm_level + 1;
> for (i = 0; i < xrs_cfg.clk_list.num_levels; i++)
> xrs_cfg.clk_list.cu_clk_list[i] = ndev->priv->dpm_clk_tbl[i].hclk;
> - xrs_cfg.sys_eff_factor = 1;
> + xrs_cfg.sys_eff_factor = 2;
> xrs_cfg.ddev = &xdna->ddev;
> xrs_cfg.actions = &aie2_xrs_actions;
> xrs_cfg.total_col = ndev->total_col;
next prev parent reply other threads:[~2026-04-24 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 4:08 [PATCH V1 1/3] accel/amdxdna: Set default DPM level based on QoS for temporal-only mode Lizhi Hou
2026-04-24 4:08 ` [PATCH V1 2/3] accel/amdxdna: Add configuring low and medium power mode Lizhi Hou
2026-04-24 13:29 ` Mario Limonciello
2026-04-24 4:08 ` [PATCH V1 3/3] accel/amdxdna: Set the system efficiency factor to 2 Lizhi Hou
2026-04-24 13:30 ` Mario Limonciello [this message]
2026-04-24 13:28 ` [PATCH V1 1/3] accel/amdxdna: Set default DPM level based on QoS for temporal-only mode Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdd649b8-db85-4bfb-8c0f-2a099201f89a@kernel.org \
--to=superm1@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=maciej.falkowski@linux.intel.com \
--cc=max.zhen@amd.com \
--cc=nishads@amd.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=sonal.santan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox