* [PATCH] drivers: iio: adc: ad7124: remove __ad7124_set_channel()
@ 2025-09-16 21:39 David Lechner
2025-09-17 7:05 ` Nuno Sá
2025-09-17 21:52 ` David Lechner
0 siblings, 2 replies; 4+ messages in thread
From: David Lechner @ 2025-09-16 21:39 UTC (permalink / raw)
To: Michael Hennerich, Jonathan Cameron, Nuno Sá,
Andy Shevchenko
Cc: linux-iio, linux-kernel, David Lechner
Remove __ad7124_set_channel() wrapper function. This just added an
unnecessary layer of indirection with an extra call to container_of().
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
Just a small cleanup while I continue to work on this driver.
---
drivers/iio/adc/ad7124.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
index 910b40393f77de84afc77d406c17c6e5051a02cd..c24f3d5127cb83eeab0cf37882446fc994173274 100644
--- a/drivers/iio/adc/ad7124.c
+++ b/drivers/iio/adc/ad7124.c
@@ -657,20 +657,13 @@ static int ad7124_prepare_read(struct ad7124_state *st, int address)
return ad7124_enable_channel(st, &st->channels[address]);
}
-static int __ad7124_set_channel(struct ad_sigma_delta *sd, unsigned int channel)
-{
- struct ad7124_state *st = container_of(sd, struct ad7124_state, sd);
-
- return ad7124_prepare_read(st, channel);
-}
-
static int ad7124_set_channel(struct ad_sigma_delta *sd, unsigned int channel)
{
struct ad7124_state *st = container_of(sd, struct ad7124_state, sd);
int ret;
mutex_lock(&st->cfgs_lock);
- ret = __ad7124_set_channel(sd, channel);
+ ret = ad7124_prepare_read(st, channel);
mutex_unlock(&st->cfgs_lock);
return ret;
@@ -965,7 +958,7 @@ static int ad7124_update_scan_mode(struct iio_dev *indio_dev,
for (i = 0; i < st->num_channels; i++) {
bit_set = test_bit(i, scan_mask);
if (bit_set)
- ret = __ad7124_set_channel(&st->sd, i);
+ ret = ad7124_prepare_read(st, i);
else
ret = ad7124_spi_write_mask(st, AD7124_CHANNEL(i), AD7124_CHANNEL_ENABLE,
0, 2);
---
base-commit: df76e03e8127f756f314418d683bad24b460c61f
change-id: 20250916-iio-adc-ad7124-remove-__ad7124_set_channel-d8e5c30ec7c6
Best regards,
--
David Lechner <dlechner@baylibre.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: iio: adc: ad7124: remove __ad7124_set_channel()
2025-09-16 21:39 [PATCH] drivers: iio: adc: ad7124: remove __ad7124_set_channel() David Lechner
@ 2025-09-17 7:05 ` Nuno Sá
2025-09-17 21:52 ` David Lechner
1 sibling, 0 replies; 4+ messages in thread
From: Nuno Sá @ 2025-09-17 7:05 UTC (permalink / raw)
To: David Lechner, Michael Hennerich, Jonathan Cameron, Nuno Sá,
Andy Shevchenko
Cc: linux-iio, linux-kernel
On Tue, 2025-09-16 at 16:39 -0500, David Lechner wrote:
> Remove __ad7124_set_channel() wrapper function. This just added an
> unnecessary layer of indirection with an extra call to container_of().
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> Just a small cleanup while I continue to work on this driver.
> ---
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> drivers/iio/adc/ad7124.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index
> 910b40393f77de84afc77d406c17c6e5051a02cd..c24f3d5127cb83eeab0cf37882446fc99417
> 3274 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -657,20 +657,13 @@ static int ad7124_prepare_read(struct ad7124_state *st,
> int address)
> return ad7124_enable_channel(st, &st->channels[address]);
> }
>
> -static int __ad7124_set_channel(struct ad_sigma_delta *sd, unsigned int
> channel)
> -{
> - struct ad7124_state *st = container_of(sd, struct ad7124_state, sd);
> -
> - return ad7124_prepare_read(st, channel);
> -}
> -
> static int ad7124_set_channel(struct ad_sigma_delta *sd, unsigned int
> channel)
> {
> struct ad7124_state *st = container_of(sd, struct ad7124_state, sd);
> int ret;
>
> mutex_lock(&st->cfgs_lock);
> - ret = __ad7124_set_channel(sd, channel);
> + ret = ad7124_prepare_read(st, channel);
> mutex_unlock(&st->cfgs_lock);
>
> return ret;
> @@ -965,7 +958,7 @@ static int ad7124_update_scan_mode(struct iio_dev
> *indio_dev,
> for (i = 0; i < st->num_channels; i++) {
> bit_set = test_bit(i, scan_mask);
> if (bit_set)
> - ret = __ad7124_set_channel(&st->sd, i);
> + ret = ad7124_prepare_read(st, i);
> else
> ret = ad7124_spi_write_mask(st, AD7124_CHANNEL(i),
> AD7124_CHANNEL_ENABLE,
> 0, 2);
>
> ---
> base-commit: df76e03e8127f756f314418d683bad24b460c61f
> change-id: 20250916-iio-adc-ad7124-remove-__ad7124_set_channel-d8e5c30ec7c6
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: iio: adc: ad7124: remove __ad7124_set_channel()
2025-09-16 21:39 [PATCH] drivers: iio: adc: ad7124: remove __ad7124_set_channel() David Lechner
2025-09-17 7:05 ` Nuno Sá
@ 2025-09-17 21:52 ` David Lechner
2025-09-20 11:08 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: David Lechner @ 2025-09-17 21:52 UTC (permalink / raw)
To: Michael Hennerich, Jonathan Cameron, Nuno Sá,
Andy Shevchenko
Cc: linux-iio, linux-kernel
For some reason I put drivers: in the subject, which should not be there.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: iio: adc: ad7124: remove __ad7124_set_channel()
2025-09-17 21:52 ` David Lechner
@ 2025-09-20 11:08 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2025-09-20 11:08 UTC (permalink / raw)
To: David Lechner
Cc: Michael Hennerich, Nuno Sá, Andy Shevchenko, linux-iio,
linux-kernel
On Wed, 17 Sep 2025 16:52:41 -0500
David Lechner <dlechner@baylibre.com> wrote:
> For some reason I put drivers: in the subject, which should not be there.
>
Tweaked that and applied to iio.git/testing
thanks,
Jonathan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-20 11:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-16 21:39 [PATCH] drivers: iio: adc: ad7124: remove __ad7124_set_channel() David Lechner
2025-09-17 7:05 ` Nuno Sá
2025-09-17 21:52 ` David Lechner
2025-09-20 11:08 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox