The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Fenglin Wu <quic_fenglinw@quicinc.com>, Mark Brown <broonie@kernel.org>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org,
	lgirdwood@gmail.com, quic_collinsd@quicinc.com,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: qcom-rpmh: Fix pm8010 pmic5_pldo502ln minimum voltage
Date: Wed, 21 Feb 2024 09:58:23 +0000	[thread overview]
Message-ID: <cf3a2def-4c41-4ca9-abdc-477d79ca396a@linaro.org> (raw)
In-Reply-To: <6b36bdc2-0ffb-491f-a1ae-93a20822e6f0@quicinc.com>

On 21/02/2024 9:11 a.m., Fenglin Wu wrote:
> 
> So, programming it to either 1.8V or 1.808V, the HW will output 1.8V. I 
> understand there is a problem for x1e801000 because its AOP side limits 
> the voltage range to [1.808V, 1.808V] for LDO3/4/6 power rails, it won't 
> work if linux side updates to use 1.8V. Actually the same issue applies 
> to SM8550 and SM8650 if you simply update the voltage level to 1.808V, 
> because their AOP side limits the voltage ranges for some of these LDOs 
> to [1.8V, 1.8V].

Hmm.

We have no use case for 1.808 to my knowledge - the sensors take 
voltages in the range 1.7 to 1.9 volts.

TBH I think it should work just fine at 1.8v bang on.

I'll test this theory on the reference hardware and repost either a 
patch or further discussion.

But I think we should probably just leave what you've upstreamed and 
request 1.8 v in the dts honestly.

Thanks

---
bod

      reply	other threads:[~2024-02-21  9:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14 12:16 [PATCH] regulator: qcom-rpmh: Fix pm8010 pmic5_pldo502ln minimum voltage Bryan O'Donoghue
2024-02-14 13:22 ` Abel Vesa
2024-02-14 13:25 ` Mark Brown
2024-02-14 14:07   ` Bryan O'Donoghue
2024-02-14 14:13     ` Mark Brown
2024-02-14 14:44       ` Bryan O'Donoghue
2024-02-14 14:52         ` Mark Brown
2024-02-14 22:47           ` Bryan O'Donoghue
2024-02-14 22:48             ` Bryan O'Donoghue
2024-02-19  3:06             ` Fenglin Wu
2024-02-20  8:20               ` Bryan O'Donoghue
2024-02-21  9:11                 ` Fenglin Wu
2024-02-21  9:58                   ` Bryan O'Donoghue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf3a2def-4c41-4ca9-abdc-477d79ca396a@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_collinsd@quicinc.com \
    --cc=quic_fenglinw@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox