From: Mark Brown <broonie@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org,
lgirdwood@gmail.com, quic_fenglinw@quicinc.com,
quic_collinsd@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: qcom-rpmh: Fix pm8010 pmic5_pldo502ln minimum voltage
Date: Wed, 14 Feb 2024 14:13:11 +0000 [thread overview]
Message-ID: <dcce3fa9-ecf3-42be-adf6-ca653a79ba2e@sirena.org.uk> (raw)
In-Reply-To: <f38468b4-8b16-4180-9738-0a2b557651a1@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
On Wed, Feb 14, 2024 at 02:07:13PM +0000, Bryan O'Donoghue wrote:
> On 14/02/2024 13:25, Mark Brown wrote:
> > On Wed, Feb 14, 2024 at 12:16:14PM +0000, Bryan O'Donoghue wrote:
> > > .voltage_ranges = (struct linear_range[]) {
> > > - REGULATOR_LINEAR_RANGE(1800000, 0, 2, 200000),
> > > + REGULATOR_LINEAR_RANGE(1808000, 0, 2, 200000),
> > This will also offset all other voltages that get set, is that expected
> > and desired?
> Yep, looks typo in the original submission.
> ldo3, ldo4 and ldo6 should all be 1.808.
Not just that but also note that every voltage step in the range will
have the 8mV offset added.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-02-14 14:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 12:16 [PATCH] regulator: qcom-rpmh: Fix pm8010 pmic5_pldo502ln minimum voltage Bryan O'Donoghue
2024-02-14 13:22 ` Abel Vesa
2024-02-14 13:25 ` Mark Brown
2024-02-14 14:07 ` Bryan O'Donoghue
2024-02-14 14:13 ` Mark Brown [this message]
2024-02-14 14:44 ` Bryan O'Donoghue
2024-02-14 14:52 ` Mark Brown
2024-02-14 22:47 ` Bryan O'Donoghue
2024-02-14 22:48 ` Bryan O'Donoghue
2024-02-19 3:06 ` Fenglin Wu
2024-02-20 8:20 ` Bryan O'Donoghue
2024-02-21 9:11 ` Fenglin Wu
2024-02-21 9:58 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcce3fa9-ecf3-42be-adf6-ca653a79ba2e@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_collinsd@quicinc.com \
--cc=quic_fenglinw@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox