The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Tomeu Vizoso <tomeu@tomeuvizoso.net>,
	dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linaro-mm-sig@lists.linaro.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-doc@vger.kernel.org, "Andrei Aldea" <a-aldea@ti.com>,
	"Andrew F. Davis" <afd@ti.com>,
	"Chirag Shilwant" <c-shilwant@ti.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"David Airlie" <airlied@gmail.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Jonathan Humphreys" <j-humphreys@ti.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Nishanth Menon" <nm@ti.com>, "Oded Gabbay" <ogabbay@kernel.org>,
	"Randolph Sapp" <rs@ti.com>, "Rob Herring" <robh@kernel.org>,
	"Robert Nelson" <robertcnelson@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Tero Kristo" <kristo@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Subject: Re: [PATCH v2 3/5] accel/thames: Add IOCTLs for BO creation and mapping
Date: Wed, 14 Jan 2026 16:56:19 +0100	[thread overview]
Message-ID: <cfba57a6-01c1-4f47-80e2-9db4d5013986@web.de> (raw)
In-Reply-To: <20260114-thames-v2-3-e94a6636e050@tomeuvizoso.net>

…
> Buffers belong to a context, which is used by the DSP to switch to the
> page table that mapped the buffers for the user of the job to execute.
> 
> v2:
> - Add thames_accel.h UAPI header (Robert Nelson).

* Please move patch version descriptions behind the marker line.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n785

* See also once more:
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n94> +++ b/drivers/accel/thames/thames_gem.c
> @@ -0,0 +1,353 @@
> +static void thames_free_vaddr(struct thames_device *tdev, struct thames_gem_object *bo)
> +{
> +	mutex_lock(&tdev->mm_lock);
> +	drm_mm_remove_node(&bo->mm);
> +	mutex_unlock(&tdev->mm_lock);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&tdev->mm_lock);”?
https://elixir.bootlin.com/linux/v6.19-rc5/source/include/linux/mutex.h#L253

Regards,
Markus

  reply	other threads:[~2026-01-14 15:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14  8:46 [PATCH v2 0/5] New DRM accel driver for Texas Instruments' C7x DSPs Tomeu Vizoso
2026-01-14  8:46 ` [PATCH v2 1/5] arm64: dts: ti: k3-j722s-ti-ipc-firmware: Add memory pool for DSP i/o buffers Tomeu Vizoso
2026-01-14 17:53   ` Andrew Davis
2026-01-14  8:46 ` [PATCH v2 2/5] accel/thames: Add driver for the C7x DSPs in TI SoCs Tomeu Vizoso
2026-01-14 17:02   ` Markus Elfring
2026-01-14 18:01   ` Andrew Davis
2026-01-14 18:54   ` Randy Dunlap
2026-01-14  8:46 ` [PATCH v2 3/5] accel/thames: Add IOCTLs for BO creation and mapping Tomeu Vizoso
2026-01-14 15:56   ` Markus Elfring [this message]
2026-01-14  8:46 ` [PATCH v2 4/5] accel/thames: Add IOCTL for job submission Tomeu Vizoso
2026-01-14 17:51   ` Markus Elfring
2026-01-14 19:06   ` Randy Dunlap
2026-01-19 13:26   ` Tvrtko Ursulin
2026-01-14  8:46 ` [PATCH v2 5/5] accel/thames: Add IOCTL for memory synchronization Tomeu Vizoso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfba57a6-01c1-4f47-80e2-9db4d5013986@web.de \
    --to=markus.elfring@web.de \
    --cc=a-aldea@ti.com \
    --cc=afd@ti.com \
    --cc=airlied@gmail.com \
    --cc=c-shilwant@ti.com \
    --cc=christian.koenig@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=j-humphreys@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nm@ti.com \
    --cc=ogabbay@kernel.org \
    --cc=robertcnelson@gmail.com \
    --cc=robh@kernel.org \
    --cc=rs@ti.com \
    --cc=simona@ffwll.ch \
    --cc=sumit.semwal@linaro.org \
    --cc=tomeu@tomeuvizoso.net \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox