The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: "Tomeu Vizoso" <tomeu@tomeuvizoso.net>,
	"Nishanth Menon" <nm@ti.com>, "Randolph Sapp" <rs@ti.com>,
	"Jonathan Humphreys" <j-humphreys@ti.com>,
	"Andrei Aldea" <a-aldea@ti.com>,
	"Chirag Shilwant" <c-shilwant@ti.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Tero Kristo" <kristo@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Oded Gabbay" <ogabbay@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Robert Nelson" <robertcnelson@gmail.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>, <linux-doc@vger.kernel.org>,
	<linux-media@vger.kernel.org>, <linaro-mm-sig@lists.linaro.org>
Subject: Re: [PATCH v2 1/5] arm64: dts: ti: k3-j722s-ti-ipc-firmware: Add memory pool for DSP i/o buffers
Date: Wed, 14 Jan 2026 11:53:05 -0600	[thread overview]
Message-ID: <d9b0d6d5-6f1a-4cb0-a8ab-5e3fdaf33fa5@ti.com> (raw)
In-Reply-To: <20260114-thames-v2-1-e94a6636e050@tomeuvizoso.net>

On 1/14/26 2:46 AM, Tomeu Vizoso wrote:
> This memory region is used by the DRM/accel driver to allocate addresses
> for buffers that are used for communication with the DSP cores and for
> their intermediate results.
> 
> Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
> ---
>   arch/arm64/boot/dts/ti/k3-j722s-ti-ipc-firmware.dtsi | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-ti-ipc-firmware.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-ti-ipc-firmware.dtsi
> index 3fbff927c4c08bce741555aa2753a394b751144f..b80d2a5a157ad59eaed8e57b22f1f4bce4765a85 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-ti-ipc-firmware.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-ti-ipc-firmware.dtsi
> @@ -42,6 +42,11 @@ c7x_0_memory_region: memory@a3100000 {
>   		no-map;
>   	};
>   
> +	c7x_iova_pool: iommu-pool@a7000000 {
> +		reg = <0x00 0xa7000000 0x00 0x18200000>;
> +		no-map;

Could you expand on why this carveout is needed? The C7 NPU has a full
MMU and should be able to work with any buffer Linux allocates from any
address, even non-contiguous buffers too.

Communication should already happen over the existing RPMSG channels
without needing extra buffers. And space for intermediate results
should be provided dynamically by the drivers (I believe that would
match how GPUs without dedicated memory handle getting intermediate
buffers space from system memory these days, but do correct me if
I'm wrong about that one).

Andrew

> +	};
> +
>   	c7x_1_dma_memory_region: memory@a4000000 {
>   		compatible = "shared-dma-pool";
>   		reg = <0x00 0xa4000000 0x00 0x100000>;
> @@ -151,13 +156,15 @@ &main_r5fss0_core0 {
>   &c7x_0 {
>   	mboxes = <&mailbox0_cluster2 &mbox_c7x_0>;
>   	memory-region = <&c7x_0_dma_memory_region>,
> -			<&c7x_0_memory_region>;
> +			<&c7x_0_memory_region>,
> +			<&c7x_iova_pool>;
>   	status = "okay";
>   };
>   
>   &c7x_1 {
>   	mboxes = <&mailbox0_cluster3 &mbox_c7x_1>;
>   	memory-region = <&c7x_1_dma_memory_region>,
> -			<&c7x_1_memory_region>;
> +			<&c7x_1_memory_region>,
> +			<&c7x_iova_pool>;
>   	status = "okay";
>   };
> 


  reply	other threads:[~2026-01-14 17:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14  8:46 [PATCH v2 0/5] New DRM accel driver for Texas Instruments' C7x DSPs Tomeu Vizoso
2026-01-14  8:46 ` [PATCH v2 1/5] arm64: dts: ti: k3-j722s-ti-ipc-firmware: Add memory pool for DSP i/o buffers Tomeu Vizoso
2026-01-14 17:53   ` Andrew Davis [this message]
2026-01-14  8:46 ` [PATCH v2 2/5] accel/thames: Add driver for the C7x DSPs in TI SoCs Tomeu Vizoso
2026-01-14 17:02   ` Markus Elfring
2026-01-14 18:01   ` Andrew Davis
2026-01-14 18:54   ` Randy Dunlap
2026-01-14  8:46 ` [PATCH v2 3/5] accel/thames: Add IOCTLs for BO creation and mapping Tomeu Vizoso
2026-01-14 15:56   ` Markus Elfring
2026-01-14  8:46 ` [PATCH v2 4/5] accel/thames: Add IOCTL for job submission Tomeu Vizoso
2026-01-14 17:51   ` Markus Elfring
2026-01-14 19:06   ` Randy Dunlap
2026-01-19 13:26   ` Tvrtko Ursulin
2026-01-14  8:46 ` [PATCH v2 5/5] accel/thames: Add IOCTL for memory synchronization Tomeu Vizoso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9b0d6d5-6f1a-4cb0-a8ab-5e3fdaf33fa5@ti.com \
    --to=afd@ti.com \
    --cc=a-aldea@ti.com \
    --cc=airlied@gmail.com \
    --cc=c-shilwant@ti.com \
    --cc=christian.koenig@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=j-humphreys@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nm@ti.com \
    --cc=ogabbay@kernel.org \
    --cc=robertcnelson@gmail.com \
    --cc=robh@kernel.org \
    --cc=rs@ti.com \
    --cc=simona@ffwll.ch \
    --cc=sumit.semwal@linaro.org \
    --cc=tomeu@tomeuvizoso.net \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox