* [PATCH] selftests/mm: fix line buffer leak in mremap_test is_range_mapped()
@ 2026-08-26 6:13 Anshuman
2026-08-26 7:37 ` David Hildenbrand (Arm)
0 siblings, 1 reply; 2+ messages in thread
From: Anshuman @ 2026-08-26 6:13 UTC (permalink / raw)
To: Andrew Morton, David Hildenbrand
Cc: Lorenzo Stoakes, Liam R . Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Shuah Khan, linux-mm,
linux-kselftest, linux-kernel, Anshuman
is_range_mapped() uses getline() to read /proc/self/maps line by
line, but never frees the buffer it allocates. Every exit path
(parse failure, match found, or reaching EOF) returns without
calling free(line), leaking the buffer on each call. The function
is called multiple times in this test, so the leak accumulates
across calls.
Free line before returning.
Signed-off-by: Anshuman <anshumantewari123@gmail.com>
---
tools/testing/selftests/mm/mremap_test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c
index 131d9d6db..779ef2d5f 100644
--- a/tools/testing/selftests/mm/mremap_test.c
+++ b/tools/testing/selftests/mm/mremap_test.c
@@ -156,6 +156,7 @@ static bool is_range_mapped(FILE *maps_fp, unsigned long start,
}
}
+ free(line);
return success;
}
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/mm: fix line buffer leak in mremap_test is_range_mapped()
2026-08-26 6:13 [PATCH] selftests/mm: fix line buffer leak in mremap_test is_range_mapped() Anshuman
@ 2026-08-26 7:37 ` David Hildenbrand (Arm)
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand (Arm) @ 2026-08-26 7:37 UTC (permalink / raw)
To: Anshuman, Andrew Morton
Cc: Lorenzo Stoakes, Liam R . Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Shuah Khan, linux-mm,
linux-kselftest, linux-kernel
On 8/26/26 08:13, Anshuman wrote:
> is_range_mapped() uses getline() to read /proc/self/maps line by
> line, but never frees the buffer it allocates. Every exit path
> (parse failure, match found, or reaching EOF) returns without
> calling free(line), leaking the buffer on each call. The function
> is called multiple times in this test, so the leak accumulates
> across calls.
>
> Free line before returning.
>
> Signed-off-by: Anshuman <anshumantewari123@gmail.com>
> ---
Looks good, I don't think Fixes is needed (even though called multiple times,
the effective waste should not be relevant on any realistic system).
Thanks!
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-26 7:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-26 6:13 [PATCH] selftests/mm: fix line buffer leak in mremap_test is_range_mapped() Anshuman
2026-08-26 7:37 ` David Hildenbrand (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox