[PATCH 0/2] selftests/intel_pstate: fix arithmetic expression and cpupower

[PATCH 0/2] selftests/intel_pstate: fix arithmetic expression and cpupower

[Alessandro Zanni]

Address issues related to arithmetic expression compatibility and
cpupower operand expected.

Command to test:
	make kselftest TARGETS=intel_pstate

Alessandro Zanni (2):
  selftests/intel_pstate: fix operand expected
  selftests/intel_pstate: cpupower command not found

 tools/testing/selftests/intel_pstate/run.sh | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

-- 
2.43.0

[PATCH 1/2] selftests/intel_pstate: fix operand expected

[Alessandro Zanni]

Running "make kselftest TARGETS=intel_pstate" results in
the following errors:
- ./run.sh: line 90: / 1000: syntax error: operand expected
(error token is "/ 1000")
- ./run.sh: line 92: / 1000: syntax error: operand expected
(error token is "/ 1000")

This fix allows to have cross-platform compatibility when
using arithmetic expression with command substitutions.

Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
---
 tools/testing/selftests/intel_pstate/run.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
index e7008f614ad7..0c1b6c1308a4 100755
--- a/tools/testing/selftests/intel_pstate/run.sh
+++ b/tools/testing/selftests/intel_pstate/run.sh
@@ -87,9 +87,9 @@ mkt_freq=${_mkt_freq}0
 
 # Get the ranges from cpupower
 _min_freq=$(cpupower frequency-info -l | tail -1 | awk ' { print $1 } ')
-min_freq=$(($_min_freq / 1000))
+min_freq=$((_min_freq / 1000))
 _max_freq=$(cpupower frequency-info -l | tail -1 | awk ' { print $2 } ')
-max_freq=$(($_max_freq / 1000))
+max_freq=$((_max_freq / 1000))
 
 
 [ $EVALUATE_ONLY -eq 0 ] && for freq in `seq $max_freq -100 $min_freq`
-- 
2.43.0

[PATCH 2/2] selftests/intel_pstate: cpupower command not found

[Alessandro Zanni]

Running "make kselftest TARGETS=intel_pstate" results in the
following errors:
- ./run.sh: line 89: cpupower: command not found
- ./run.sh: line 91: cpupower: command not found
if the cpupower is not installed.

Since the test depends on cpupower, this patch stops the test if the
cpupower is not installed.

Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
---
 tools/testing/selftests/intel_pstate/run.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
index 0c1b6c1308a4..6a3b8503264e 100755
--- a/tools/testing/selftests/intel_pstate/run.sh
+++ b/tools/testing/selftests/intel_pstate/run.sh
@@ -44,6 +44,11 @@ if [ $UID != 0 ] && [ $EVALUATE_ONLY == 0 ]; then
     exit $ksft_skip
 fi
 
+if ! command -v cpupower &> /dev/null; then
+	echo $msg cpupower could not be found, please install it >&2
+	exit $ksft_skip
+fi
+
 max_cpus=$(($(nproc)-1))
 
 function run_test () {
-- 
2.43.0

Re: [PATCH 0/2] selftests/intel_pstate: fix arithmetic expression and cpupower

[Shuah Khan]

On 10/28/24 13:08, Alessandro Zanni wrote:
> Address issues related to arithmetic expression compatibility and
> cpupower operand expected.
> 
> Command to test:
> 	make kselftest TARGETS=intel_pstate
> 
> Alessandro Zanni (2):
>    selftests/intel_pstate: fix operand expected
>    selftests/intel_pstate: cpupower command not found
> 
>   tools/testing/selftests/intel_pstate/run.sh | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 

Thank you. Applied fixing the short logs for next rc.

thanks,
-- Shuah