* [PATCH v2 2/2] power: supply: Add driver for TI BQ25630 charger
2026-06-18 13:37 [PATCH v2 0/2] Add driver for TI BQ25630 charger Waqar Hameed
@ 2026-06-18 13:37 ` Waqar Hameed
2026-06-18 13:37 ` [PATCH v2 1/2] dt-bindings: power: supply: Add " Waqar Hameed
1 sibling, 0 replies; 3+ messages in thread
From: Waqar Hameed @ 2026-06-18 13:37 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: kernel, linux-kernel, linux-pm
TI BQ25630 is a battery charger that is I2C controlled. Despite its
model name, it is rather different from the other devices in the BQ256xx
family; it has a completely different register layout and some other
additional functionality (see the datasheet for more details [1]).
The most "annoying" thing is that it has two different register lengths:
8-bit and 16-bit. Moreover, the 16-bit registers are further partitioned
into either being little- or big-endian... Luckily, `regmap` has support
for multiple `regmap_config`s (by setting unique names). Therefore, use
three different `regmap_config`s for the corresponding registers. ADC
functionality has been left out, due to it not having any real-world
use-cases.
The `enum power_supply_property` values are straightforward to map. Some
properties are clamped (e.g. voltage/current ranges). Common
`bq25630_read/write_limit()` functions for this are therefore suitable.
Interrupts are sent whenever a state change is detected. Save the state
status registers in `bq25630_data` and `memcmp()` this in order to
decide if `power_supply_changed()` should be called or not. The actual
state values are in (and fetched from) the other
`power_supply_property`-mapped registers.
[1] https://www.ti.com/lit/gpn/bq25630
Change-Id: I286c7a2f279cc28375a0c611a490fe7c8f77c08a
Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
drivers/power/supply/Kconfig | 7 +
drivers/power/supply/Makefile | 1 +
drivers/power/supply/bq25630_charger.c | 1073 ++++++++++++++++++++++++
3 files changed, 1081 insertions(+)
create mode 100644 drivers/power/supply/bq25630_charger.c
diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
index 83392ed6a8da9..0466bec6cddcd 100644
--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -839,6 +839,13 @@ config CHARGER_BQ25980
Say Y to enable support for the TI BQ25980, BQ25975 and BQ25960
series of fast battery chargers.
+config CHARGER_BQ25630
+ tristate "TI BQ25630 battery charger driver"
+ depends on I2C
+ select REGMAP_I2C
+ help
+ Say Y to enable support for the TI BQ25630 battery charger.
+
config CHARGER_BQ256XX
tristate "TI BQ256XX battery charger driver"
depends on I2C
diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile
index 7ee839dca7f33..8d9381366ceb6 100644
--- a/drivers/power/supply/Makefile
+++ b/drivers/power/supply/Makefile
@@ -105,6 +105,7 @@ obj-$(CONFIG_CHARGER_BQ2515X) += bq2515x_charger.o
obj-$(CONFIG_CHARGER_BQ257XX) += bq257xx_charger.o
obj-$(CONFIG_CHARGER_BQ25890) += bq25890_charger.o
obj-$(CONFIG_CHARGER_BQ25980) += bq25980_charger.o
+obj-$(CONFIG_CHARGER_BQ25630) += bq25630_charger.o
obj-$(CONFIG_CHARGER_BQ256XX) += bq256xx_charger.o
obj-$(CONFIG_CHARGER_RK817) += rk817_charger.o
obj-$(CONFIG_CHARGER_SMB347) += smb347-charger.o
diff --git a/drivers/power/supply/bq25630_charger.c b/drivers/power/supply/bq25630_charger.c
new file mode 100644
index 0000000000000..4b65172f7b30e
--- /dev/null
+++ b/drivers/power/supply/bq25630_charger.c
@@ -0,0 +1,1073 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Driver for TI BQ25630 charger.
+ *
+ * Copyright (C) 2026 Axis Communications AB
+ */
+
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/regmap.h>
+
+#include <linux/power_supply.h>
+
+#define BQ25630_DRV_NAME "bq25630-charger"
+
+/* Registers. */
+#define BQ25630_REG_CHARGE_CURRENT_LIMIT 0x02
+#define BQ25630_REG_CHARGE_VOLTAGE_LIMIT 0x04
+#define BQ25630_REG_INPUT_CURRENT_LIMIT 0x06
+#define BQ25630_REG_INPUT_VOLTAGE_LIMIT 0x08
+#define BQ25630_REG_IOTG_REGULATION 0x0a
+#define BQ25630_REG_VOTG_REGULATION 0x0c
+#define BQ25630_REG_MINIMAL_SYSTEM_VOLTAGE 0x0e
+#define BQ25630_REG_PRECHARGE_CONTROL 0x10
+#define BQ25630_REG_TERMINATION_CONTROL 0x12
+#define BQ25630_REG_CHARGE_TIMER_CONTROL 0x14
+#define BQ25630_REG_CHARGER_CONTROL_0 0x15
+#define BQ25630_REG_CHARGER_CONTROL_1 0x16
+#define BQ25630_REG_CHARGER_CONTROL_2 0x17
+#define BQ25630_REG_CHARGER_CONTROL_3 0x18
+#define BQ25630_REG_CHARGER_CONTROL_4 0x19
+#define BQ25630_REG_CHARGER_CONTROL_5 0x1a
+#define BQ25630_REG_NTC_CONTROL_0 0x1b
+#define BQ25630_REG_NTC_CONTROL_1 0x1c
+#define BQ25630_REG_NTC_CONTROL_2 0x1d
+#define BQ25630_REG_NTC_CONTROL_3 0x1e
+#define BQ25630_REG_CHARGER_STATUS_0 0x1f
+#define BQ25630_REG_CHARGER_STATUS_1 0x20
+#define BQ25630_REG_CHARGER_STATUS_2 0x21
+#define BQ25630_REG_FAULT_STATUS 0x22
+#define BQ25630_REG_CHARGER_FLAG_0 0x23
+#define BQ25630_REG_CHARGER_FLAG_1 0x24
+#define BQ25630_REG_FAULT_FLAG 0x25
+#define BQ25630_REG_CHARGER_MASK_0 0x26
+#define BQ25630_REG_CHARGER_MASK_1 0x27
+#define BQ25630_REG_FAULT_MASK 0x28
+#define BQ25630_REG_ICO_CURRENT_LIMIT 0x29
+#define BQ25630_REG_ADC_CONTROL 0x2b
+#define BQ25630_REG_ADC_CHANNEL_DISABLE_1 0x2c
+#define BQ25630_REG_IBUS_ADC 0x32
+#define BQ25630_REG_IBAT_ADC 0x34
+#define BQ25630_REG_VBUS_ADC 0x36
+#define BQ25630_REG_VPMID_ADC 0x38
+#define BQ25630_REG_VBAT_ADC 0x3a
+#define BQ25630_REG_VSYS_ADC 0x3c
+#define BQ25630_REG_TS_ADC 0x3e
+#define BQ25630_REG_TDIE_ADC 0x40
+#define BQ25630_REG_USB_C_CONTROL_0 0x44
+#define BQ25630_REG_USB_C_CONTROL_1 0x45
+#define BQ25630_REG_LIQUID_CONTROL_0 0x46
+#define BQ25630_REG_LIQUID_CONTROL_1 0x47
+#define BQ25630_REG_USB_C_INFORMATION_0 0x48
+#define BQ25630_REG_USB_C_INFORMATION_1 0x49
+#define BQ25630_REG_USB_DAC_CONTROL_0 0x4a
+#define BQ25630_REG_USB_DAC_CONTROL_1 0x4b
+#define BQ25630_REG_PART_INFORMATION 0x4d
+
+#define BQ25630_NR_STAT_REGS \
+ (BQ25630_REG_FAULT_FLAG - BQ25630_REG_CHARGER_STATUS_0 + 1)
+
+/* Charge current limits. */
+#define BQ25630_ICHG_MIN_REGVAL 0x04
+#define BQ25630_ICHG_MIN 80000
+#define BQ25630_ICHG_MAX 5040000
+#define BQ25630_ICHG_STEP 20000
+
+/* Charge voltage limits. */
+#define BQ25630_VREG_MIN_REGVAL 0x15e
+#define BQ25630_VREG_MIN 3500000
+#define BQ25630_VREG_MAX 4800000
+#define BQ25630_VREG_STEP 10000
+
+/* Input current limits. */
+#define BQ25630_IINDPM_MIN_REGVAL 0x0a
+#define BQ25630_IINDPM_MIN 100000
+#define BQ25630_IINDPM_MAX 3200000
+#define BQ25630_IINDPM_STEP 10000
+
+/* Input voltage limits. */
+#define BQ25630_VINDPM_MIN_REGVAL 0x5f
+#define BQ25630_VINDPM_MIN 3800000
+#define BQ25630_VINDPM_MAX 16800000
+#define BQ25630_VINDPM_STEP 40000
+
+/* Minimal system voltage limits. */
+#define BQ25630_VSYSMIN_MIN_REGVAL 0x20
+#define BQ25630_VSYSMIN_MIN 2560000
+#define BQ25630_VSYSMIN_MAX 4000000
+#define BQ25630_VSYSMIN_STEP 80000
+
+/* Pre-charge current limits. */
+#define BQ25630_IPRECHG_MIN_REGVAL 0x02
+#define BQ25630_IPRECHG_MIN 40000
+#define BQ25630_IPRECHG_MAX 1000000
+#define BQ25630_IPRECHG_STEP 20000
+
+/* Termination current limits. */
+#define BQ25630_ITERM_MIN_REGVAL 0x03
+#define BQ25630_ITERM_MIN 30000
+#define BQ25630_ITERM_MAX 1000000
+#define BQ25630_ITERM_STEP 10000
+
+/* Charge types. */
+#define BQ25630_CHG_STAT_NOT_CHARGING 0x00
+#define BQ25630_CHG_STAT_TRICKLE_CHARGE 0x01
+#define BQ25630_CHG_STAT_PRE_CHARGE 0x02
+#define BQ25630_CHG_STAT_FAST_CHARGE 0x03
+#define BQ25630_CHG_STAT_TAPER_CHARGE 0x04
+#define BQ25630_CHG_STAT_TERMINATION 0x07
+
+/* USB types (VBUS). */
+#define BQ25630_VBUS_STAT_NONE 0x00
+#define BQ25630_VBUS_STAT_SDP 0x01
+#define BQ25630_VBUS_STAT_CDP 0x02
+#define BQ25630_VBUS_STAT_DCP 0x03
+#define BQ25630_VBUS_STAT_HVDCP 0x06
+#define BQ25630_VBUS_STAT_BOOST_OTG 0x07
+#define BQ25630_VBUS_STAT_USB_C_DEFAULT 0x08
+#define BQ25630_VBUS_STAT_USB_C_MEDIUM 0x09
+#define BQ25630_VBUS_STAT_USB_C_HIGH 0x0a
+
+/* Temperature status. */
+#define BQ25630_TS_STAT_NORMAL 0x00
+#define BQ25630_TS_STAT_COLD 0x01
+#define BQ25630_TS_STAT_HOT 0x02
+#define BQ25630_TS_STAT_COOL 0x03
+#define BQ25630_TS_STAT_WARM 0x04
+#define BQ25630_TS_STAT_PRECOOL 0x05
+#define BQ25630_TS_STAT_PREWARM 0x06
+
+/* Register fields. */
+enum bq25630_regfield {
+ /* Charge current limit. */
+ BQ25630_REGF_ICHG,
+ /* Charge voltage limit. */
+ BQ25630_REGF_VREG,
+ /* Input current limit. */
+ BQ25630_REGF_IINDPM,
+ /* Input voltage limit. */
+ BQ25630_REGF_VINDPM,
+ /* Minimal system voltage. */
+ BQ25630_REGF_VSYSMIN,
+ /* Pre-charge current limit. */
+ BQ25630_REGF_IPRECHG,
+ /* Termination current threshold. */
+ BQ25630_REGF_ITERM,
+
+ /* IBUS ADC reading. */
+ BQ25630_REGF_IBUS_ADC,
+ /* VBUS ADC reading. */
+ BQ25630_REGF_VBUS_ADC,
+
+ /* Watchdog timer. */
+ BQ25630_REGF_WATCHDOG,
+ /* Enable charger. */
+ BQ25630_REGF_EN_CHG,
+ /* Register reset. */
+ BQ25630_REGF_REG_RST,
+ /* BATFET control. */
+ BQ25630_REGF_BATFET_CTRL,
+ /* Power good indicator. */
+ BQ25630_REGF_PG_STAT,
+ /* Charge status. */
+ BQ25630_REGF_CHG_STAT,
+ /* VBUS status. */
+ BQ25630_REGF_VBUS_STAT,
+
+ /* Temperature zone. */
+ BQ25630_REGF_TS_STAT,
+ /* Temperature shutdwon. */
+ BQ25630_REGF_TSHUT_STAT,
+ /* OTG fault. */
+ BQ25630_REGF_OTG_FAULT_STAT,
+ /* System voltage fault. */
+ BQ25630_REGF_VSYS_FAULT_STAT,
+ /* Battery fault. */
+ BQ25630_REGF_BAT_FAULT_STAT,
+ /* VBUS fault. */
+ BQ25630_REGF_VBUS_FAULT_STAT,
+
+ /* Sentinel value. */
+ BQ25630_REGF_MAX
+};
+
+static const struct reg_field bq25630_regfields[] = {
+ [BQ25630_REGF_ICHG] =
+ REG_FIELD(BQ25630_REG_CHARGE_CURRENT_LIMIT, 4, 11),
+ [BQ25630_REGF_VREG] =
+ REG_FIELD(BQ25630_REG_CHARGE_VOLTAGE_LIMIT, 3, 11),
+ [BQ25630_REGF_IINDPM] =
+ REG_FIELD(BQ25630_REG_INPUT_CURRENT_LIMIT, 3, 11),
+ [BQ25630_REGF_VINDPM] =
+ REG_FIELD(BQ25630_REG_INPUT_VOLTAGE_LIMIT, 5, 13),
+
+ [BQ25630_REGF_VSYSMIN] =
+ REG_FIELD(BQ25630_REG_MINIMAL_SYSTEM_VOLTAGE, 6, 11),
+
+ [BQ25630_REGF_IPRECHG] =
+ REG_FIELD(BQ25630_REG_PRECHARGE_CONTROL, 4, 9),
+ [BQ25630_REGF_ITERM] =
+ REG_FIELD(BQ25630_REG_TERMINATION_CONTROL, 3, 9),
+
+ [BQ25630_REGF_IBUS_ADC] = REG_FIELD(BQ25630_REG_IBUS_ADC, 1, 15),
+ [BQ25630_REGF_VBUS_ADC] = REG_FIELD(BQ25630_REG_VBUS_ADC, 2, 14),
+
+ [BQ25630_REGF_WATCHDOG] =
+ REG_FIELD(BQ25630_REG_CHARGER_CONTROL_1, 0, 1),
+ [BQ25630_REGF_EN_CHG] =
+ REG_FIELD(BQ25630_REG_CHARGER_CONTROL_1, 5, 5),
+ [BQ25630_REGF_REG_RST] =
+ REG_FIELD(BQ25630_REG_CHARGER_CONTROL_2, 7, 7),
+ [BQ25630_REGF_BATFET_CTRL] =
+ REG_FIELD(BQ25630_REG_CHARGER_CONTROL_3, 0, 1),
+ [BQ25630_REGF_PG_STAT] =
+ REG_FIELD(BQ25630_REG_CHARGER_STATUS_0, 7, 7),
+ [BQ25630_REGF_CHG_STAT] =
+ REG_FIELD(BQ25630_REG_CHARGER_STATUS_1, 3, 5),
+ [BQ25630_REGF_VBUS_STAT] =
+ REG_FIELD(BQ25630_REG_CHARGER_STATUS_2, 4, 7),
+
+ [BQ25630_REGF_TS_STAT] =
+ REG_FIELD(BQ25630_REG_FAULT_STATUS, 0, 2),
+ [BQ25630_REGF_TSHUT_STAT] =
+ REG_FIELD(BQ25630_REG_FAULT_STATUS, 3, 3),
+ [BQ25630_REGF_OTG_FAULT_STAT] =
+ REG_FIELD(BQ25630_REG_FAULT_STATUS, 4, 4),
+ [BQ25630_REGF_VSYS_FAULT_STAT] =
+ REG_FIELD(BQ25630_REG_FAULT_STATUS, 5, 5),
+ [BQ25630_REGF_BAT_FAULT_STAT] =
+ REG_FIELD(BQ25630_REG_FAULT_STATUS, 6, 6),
+ [BQ25630_REGF_VBUS_FAULT_STAT] =
+ REG_FIELD(BQ25630_REG_FAULT_STATUS, 7, 7),
+};
+
+/* 8-bit value regmap. */
+static const struct regmap_range bq25630_read_reg_range8[] = {
+ regmap_reg_range(BQ25630_REG_CHARGE_TIMER_CONTROL,
+ BQ25630_REG_FAULT_MASK),
+ regmap_reg_range(BQ25630_REG_ADC_CONTROL,
+ BQ25630_REG_ADC_CHANNEL_DISABLE_1),
+ regmap_reg_range(BQ25630_REG_USB_C_CONTROL_0,
+ BQ25630_REG_PART_INFORMATION),
+};
+
+static const struct regmap_range bq25630_write_reg_range8[] = {
+ regmap_reg_range(BQ25630_REG_CHARGE_TIMER_CONTROL,
+ BQ25630_REG_NTC_CONTROL_3),
+ regmap_reg_range(BQ25630_REG_CHARGER_MASK_0,
+ BQ25630_REG_FAULT_MASK),
+ regmap_reg_range(BQ25630_REG_ADC_CONTROL,
+ BQ25630_REG_ADC_CHANNEL_DISABLE_1),
+ regmap_reg_range(BQ25630_REG_USB_C_CONTROL_0,
+ BQ25630_REG_LIQUID_CONTROL_1),
+ regmap_reg_range(BQ25630_REG_USB_DAC_CONTROL_0,
+ BQ25630_REG_USB_DAC_CONTROL_1),
+};
+
+static const struct regmap_access_table bq25630_read_reg_access_table8 = {
+ .yes_ranges = bq25630_read_reg_range8,
+ .n_yes_ranges = ARRAY_SIZE(bq25630_read_reg_range8),
+};
+
+static const struct regmap_access_table bq25630_write_reg_access_table8 = {
+ .yes_ranges = bq25630_write_reg_range8,
+ .n_yes_ranges = ARRAY_SIZE(bq25630_write_reg_range8),
+};
+
+static const struct regmap_config bq25630_regmap_config8 = {
+ .name = BQ25630_DRV_NAME "-8bit",
+ .reg_bits = 8,
+ .val_bits = 8,
+ .max_register = BQ25630_REG_PART_INFORMATION,
+ .rd_table = &bq25630_read_reg_access_table8,
+ .wr_table = &bq25630_write_reg_access_table8,
+};
+
+/* 16-bit little-endian value regmap. */
+static const struct regmap_range bq25630_read_reg_range16le[] = {
+ regmap_reg_range(BQ25630_REG_CHARGE_CURRENT_LIMIT,
+ BQ25630_REG_TERMINATION_CONTROL),
+ regmap_reg_range(BQ25630_REG_ICO_CURRENT_LIMIT,
+ BQ25630_REG_ICO_CURRENT_LIMIT),
+};
+
+static const struct regmap_range bq25630_write_reg_range16le[] = {
+ regmap_reg_range(BQ25630_REG_CHARGE_CURRENT_LIMIT,
+ BQ25630_REG_TERMINATION_CONTROL),
+ regmap_reg_range(BQ25630_REG_ICO_CURRENT_LIMIT,
+ BQ25630_REG_ICO_CURRENT_LIMIT),
+};
+
+static const struct regmap_access_table bq25630_read_reg_access_table16le = {
+ .yes_ranges = bq25630_read_reg_range16le,
+ .n_yes_ranges = ARRAY_SIZE(bq25630_read_reg_range16le),
+};
+
+static const struct regmap_access_table bq25630_write_reg_access_table16le = {
+ .yes_ranges = bq25630_write_reg_range16le,
+ .n_yes_ranges = ARRAY_SIZE(bq25630_write_reg_range16le),
+};
+
+static const struct regmap_config bq25630_regmap_config16le = {
+ .name = BQ25630_DRV_NAME "-16bit-le",
+ .reg_bits = 8,
+ .val_bits = 16,
+ .reg_stride = 2,
+ .val_format_endian = REGMAP_ENDIAN_LITTLE,
+ /*
+ * Datasheet doesn't mention that this register is little-endian, but it
+ * looks like it?
+ */
+ .max_register = BQ25630_REG_TERMINATION_CONTROL,
+ .rd_table = &bq25630_read_reg_access_table16le,
+ .wr_table = &bq25630_write_reg_access_table16le,
+};
+
+/* 16-bit big-endian value regmap. */
+static const struct regmap_range bq25630_read_reg_range16be[] = {
+ regmap_reg_range(BQ25630_REG_IBUS_ADC,
+ BQ25630_REG_TDIE_ADC),
+};
+
+static const struct regmap_access_table bq25630_read_reg_access_table16be = {
+ .yes_ranges = bq25630_read_reg_range16be,
+ .n_yes_ranges = ARRAY_SIZE(bq25630_read_reg_range16be),
+};
+
+static const struct regmap_config bq25630_regmap_config16be = {
+ .name = BQ25630_DRV_NAME "-16bit-be",
+ .reg_bits = 8,
+ .val_bits = 16,
+ .reg_stride = 2,
+ .val_format_endian = REGMAP_ENDIAN_BIG,
+ .max_register = BQ25630_REG_TDIE_ADC,
+ .rd_table = &bq25630_read_reg_access_table16be,
+ .wr_table = NULL,
+};
+
+struct bq25630_data {
+ struct device *dev;
+ struct regmap *regmap8;
+ struct regmap *regmap16le;
+ struct regmap *regmap16be;
+ struct regmap_field *regfields[BQ25630_REGF_MAX];
+
+ struct power_supply *psy;
+ struct power_supply_battery_info *batinfo;
+
+ /* State status from IRQs. */
+ u8 statregs[BQ25630_NR_STAT_REGS];
+};
+
+static int bq25630_alloc_regfield_range(struct bq25630_data *data,
+ const enum bq25630_regfield from,
+ const enum bq25630_regfield to,
+ struct regmap *regmap)
+{
+ int i;
+
+ for (i = from; i <= to; ++i) {
+ data->regfields[i] = devm_regmap_field_alloc(
+ data->dev, regmap, bq25630_regfields[i]);
+ if (IS_ERR(data->regfields[i]))
+ return dev_err_probe(
+ data->dev, PTR_ERR(data->regfields[i]),
+ "Could not allocate register field %d\n", i);
+ }
+
+ return 0;
+}
+
+static irqreturn_t bq25630_irq_thread(int irq, void *dev_id)
+{
+ struct bq25630_data *data = dev_id;
+ u8 regbuf[BQ25630_NR_STAT_REGS];
+ int ret;
+
+ BUILD_BUG_ON(ARRAY_SIZE(regbuf) != ARRAY_SIZE(data->statregs));
+
+ ret = regmap_bulk_read(data->regmap8, BQ25630_REG_CHARGER_STATUS_0,
+ regbuf, ARRAY_SIZE(regbuf));
+ if (ret) {
+ dev_err(data->dev, "Could not bulk read IRQ registers (%d)\n",
+ ret);
+ goto out;
+ }
+
+ if (memcmp(data->statregs, regbuf, ARRAY_SIZE(data->statregs))) {
+ power_supply_changed(data->psy);
+ memcpy(data->statregs, regbuf, ARRAY_SIZE(data->statregs));
+ }
+
+out:
+ return IRQ_HANDLED;
+}
+
+static int bq25630_read_limit(struct bq25630_data *data,
+ const enum bq25630_regfield regfield,
+ const int minval, const int step,
+ const int minregval, int *val)
+{
+ int ret;
+ unsigned int regval;
+
+ ret = regmap_field_read(data->regfields[regfield], ®val);
+ if (ret) {
+ dev_err(data->dev, "Could not read limit (%d)\n", ret);
+ return ret;
+ }
+
+ *val = minval + step * (regval - minregval);
+
+ return 0;
+}
+
+static int bq25630_write_limit(struct bq25630_data *data,
+ const enum bq25630_regfield regfield,
+ const int minval, const int maxval,
+ const int step, const int minregval, int val)
+{
+ int ret;
+ unsigned int regval;
+
+ val = clamp(val, minval, maxval);
+ regval = minregval + ((val - minval) / step);
+ ret = regmap_field_write(data->regfields[regfield], regval);
+ if (ret) {
+ dev_err(data->dev, "Could not write limit (%d)\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static int bq25630_read_charge_type(struct bq25630_data *data, int *val)
+{
+ int ret;
+ unsigned int regval;
+
+ ret = regmap_field_read(data->regfields[BQ25630_REGF_CHG_STAT],
+ ®val);
+ if (ret) {
+ dev_err(data->dev, "Could not read charge type (%d)\n", ret);
+ return ret;
+ }
+
+ switch (regval) {
+ case BQ25630_CHG_STAT_NOT_CHARGING:
+ *val = POWER_SUPPLY_CHARGE_TYPE_NONE;
+ break;
+ case BQ25630_CHG_STAT_TRICKLE_CHARGE:
+ case BQ25630_CHG_STAT_PRE_CHARGE:
+ *val = POWER_SUPPLY_CHARGE_TYPE_TRICKLE;
+ break;
+ case BQ25630_CHG_STAT_FAST_CHARGE:
+ *val = POWER_SUPPLY_CHARGE_TYPE_FAST;
+ break;
+ case BQ25630_CHG_STAT_TAPER_CHARGE:
+ *val = POWER_SUPPLY_CHARGE_TYPE_LONGLIFE;
+ break;
+ case BQ25630_CHG_STAT_TERMINATION:
+ *val = POWER_SUPPLY_CHARGE_TYPE_BYPASS;
+ break;
+ default:
+ *val = POWER_SUPPLY_CHARGE_TYPE_UNKNOWN;
+ }
+
+ return 0;
+}
+
+static int bq25630_read_health(struct bq25630_data *data, int *val)
+{
+ int ret;
+ u8 temp;
+ unsigned int regval;
+
+ ret = regmap_read(data->regmap8, BQ25630_REG_FAULT_STATUS, ®val);
+ if (ret) {
+ dev_err(data->dev, "Could not read fault status (%d)\n", ret);
+ return ret;
+ }
+
+ temp = regval & GENMASK(bq25630_regfields[BQ25630_REGF_TS_STAT].msb,
+ bq25630_regfields[BQ25630_REGF_TS_STAT].lsb);
+ if (regval &
+ GENMASK(bq25630_regfields[BQ25630_REGF_VBUS_FAULT_STAT].msb,
+ bq25630_regfields[BQ25630_REGF_VBUS_FAULT_STAT].lsb)) {
+ *val = POWER_SUPPLY_HEALTH_OVERVOLTAGE;
+ } else if (regval &
+ GENMASK(bq25630_regfields[BQ25630_REGF_BAT_FAULT_STAT].msb,
+ bq25630_regfields[BQ25630_REGF_BAT_FAULT_STAT].lsb)) {
+ /*
+ * We can't differentiate between dead, under voltage or over
+ * voltage.
+ */
+ *val = POWER_SUPPLY_HEALTH_UNSPEC_FAILURE;
+ } else if (regval &
+ GENMASK(bq25630_regfields[BQ25630_REGF_VSYS_FAULT_STAT].msb,
+ bq25630_regfields[BQ25630_REGF_VSYS_FAULT_STAT].lsb)) {
+ /*
+ * We can't differentiate between under voltage or over voltage.
+ */
+ *val = POWER_SUPPLY_HEALTH_UNSPEC_FAILURE;
+ } else if (regval &
+ GENMASK(bq25630_regfields[BQ25630_REGF_OTG_FAULT_STAT].msb,
+ bq25630_regfields[BQ25630_REGF_OTG_FAULT_STAT].lsb)) {
+ /*
+ * We can't differentiate between under voltage or over voltage.
+ */
+ *val = POWER_SUPPLY_HEALTH_UNSPEC_FAILURE;
+ } else if (regval &
+ GENMASK(bq25630_regfields[BQ25630_REGF_TSHUT_STAT].msb,
+ bq25630_regfields[BQ25630_REGF_TSHUT_STAT].lsb)) {
+ /* Temperature shutdown is always due to hot temperatures. */
+ *val = POWER_SUPPLY_HEALTH_HOT;
+ } else if (temp) {
+ switch (temp) {
+ case BQ25630_TS_STAT_COLD:
+ *val = POWER_SUPPLY_HEALTH_COLD;
+ break;
+ case BQ25630_TS_STAT_COOL:
+ *val = POWER_SUPPLY_HEALTH_COOL;
+ break;
+ case BQ25630_TS_STAT_WARM:
+ *val = POWER_SUPPLY_HEALTH_WARM;
+ break;
+ case BQ25630_TS_STAT_HOT:
+ *val = POWER_SUPPLY_HEALTH_HOT;
+ break;
+ default:
+ /* Interpret PRECOOL and PREWARM as NORMAL. */
+ *val = POWER_SUPPLY_HEALTH_GOOD;
+ }
+ } else {
+ *val = POWER_SUPPLY_HEALTH_GOOD;
+ }
+
+ return 0;
+}
+
+static int bq25630_read_vbus(struct bq25630_data *data, int *val)
+{
+ unsigned int regval;
+ int ret;
+
+ ret = regmap_field_read(data->regfields[BQ25630_REGF_VBUS_STAT],
+ ®val);
+ if (ret) {
+ dev_err(data->dev, "Could not read VBUS (%d)\n", ret);
+ return ret;
+ }
+
+ switch (regval) {
+ case BQ25630_VBUS_STAT_NONE:
+ *val = -1;
+ break;
+ case BQ25630_VBUS_STAT_SDP:
+ *val = POWER_SUPPLY_USB_TYPE_SDP;
+ break;
+ case BQ25630_VBUS_STAT_CDP:
+ *val = POWER_SUPPLY_USB_TYPE_CDP;
+ break;
+ case BQ25630_VBUS_STAT_DCP:
+ case BQ25630_VBUS_STAT_HVDCP:
+ *val = POWER_SUPPLY_USB_TYPE_DCP;
+ break;
+ case BQ25630_VBUS_STAT_USB_C_DEFAULT:
+ case BQ25630_VBUS_STAT_USB_C_MEDIUM:
+ case BQ25630_VBUS_STAT_USB_C_HIGH:
+ *val = POWER_SUPPLY_USB_TYPE_C;
+ break;
+ default:
+ *val = POWER_SUPPLY_USB_TYPE_UNKNOWN;
+ }
+
+ return 0;
+}
+
+static int bq25630_get_status(struct bq25630_data *data, int *val)
+{
+ unsigned int regval;
+ int ret;
+
+ ret = regmap_field_read(data->regfields[BQ25630_REGF_PG_STAT], ®val);
+ if (ret) {
+ dev_err(data->dev, "Could not read PG status (%d)", ret);
+ return ret;
+ }
+
+ if (!regval) {
+ /* There is not enough power, battery must be discharging. */
+ *val = POWER_SUPPLY_STATUS_DISCHARGING;
+ return 0;
+ }
+
+ ret = regmap_field_read(data->regfields[BQ25630_REGF_EN_CHG], ®val);
+ if (ret) {
+ dev_err(data->dev, "Could not read charge status (%d)", ret);
+ return ret;
+ }
+
+ if (!regval) {
+ /* Charging is not enabled, battery must be discharging. */
+ *val = POWER_SUPPLY_STATUS_DISCHARGING;
+ return 0;
+ }
+
+ ret = bq25630_read_charge_type(data, val);
+ if (ret)
+ return ret;
+
+ switch (*val) {
+ case POWER_SUPPLY_CHARGE_TYPE_NONE:
+ *val = POWER_SUPPLY_STATUS_NOT_CHARGING;
+ break;
+ case POWER_SUPPLY_CHARGE_TYPE_BYPASS:
+ /* Corresponds to BQ25630_CHG_STAT_TERMINATION. */
+ *val = POWER_SUPPLY_STATUS_FULL;
+ break;
+ default:
+ *val = POWER_SUPPLY_STATUS_CHARGING;
+ }
+
+ return 0;
+}
+
+static int bq25630_reset(struct bq25630_data *data)
+{
+ unsigned int regval = 1;
+ int ret;
+
+ ret = regmap_field_force_write(data->regfields[BQ25630_REGF_REG_RST],
+ regval);
+ if (ret) {
+ dev_err(data->dev,
+ "Could not force write reset register field (%d)\n",
+ ret);
+ return ret;
+ }
+
+ /*
+ * After a successful register reset, the device signals by resetting
+ * this register field to 0. Try reading it for some interrupt cycles.
+ */
+ ret = regmap_field_read_poll_timeout(
+ data->regfields[BQ25630_REGF_REG_RST], regval, regval == 0, 256,
+ 100000);
+ if (ret) {
+ dev_err(data->dev, "Could not read reset register field (%d)\n",
+ ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static int bq25630_setup(struct bq25630_data *data)
+{
+ int ret;
+
+ ret = bq25630_reset(data);
+ if (ret) {
+ dev_err(data->dev, "Could not reset device (%d)\n", ret);
+ return ret;
+ }
+
+ /* Disable the watchdog. */
+ ret = regmap_field_write(data->regfields[BQ25630_REGF_WATCHDOG], 0);
+ if (ret) {
+ dev_err(data->dev, "Could not write watchdog timer (%d)\n",
+ ret);
+ return ret;
+ }
+
+ /*
+ * Set values according to battery info. Warn on missing "dangerous"
+ * properties.
+ */
+ if (data->batinfo->voltage_min_design_uv >= 0) {
+ ret = bq25630_write_limit(data, BQ25630_REGF_VSYSMIN,
+ BQ25630_VSYSMIN_MIN,
+ BQ25630_VSYSMIN_MAX,
+ BQ25630_VSYSMIN_STEP,
+ BQ25630_VSYSMIN_MIN_REGVAL,
+ data->batinfo->voltage_min_design_uv);
+ if (ret)
+ return ret;
+ } else
+ dev_warn(data->dev,
+ "Using default value for minimum voltage\n");
+
+ if (data->batinfo->constant_charge_voltage_max_uv >= 0) {
+ ret = bq25630_write_limit(
+ data, BQ25630_REGF_VREG, BQ25630_VREG_MIN,
+ BQ25630_VREG_MAX, BQ25630_VREG_STEP,
+ BQ25630_VREG_MIN_REGVAL,
+ data->batinfo->constant_charge_voltage_max_uv);
+ if (ret)
+ return ret;
+ } else
+ dev_warn(data->dev,
+ "Using default value for maximum constant charge voltage\n");
+
+ if (data->batinfo->constant_charge_current_max_ua >= 0) {
+ ret = bq25630_write_limit(
+ data, BQ25630_REGF_ICHG, BQ25630_ICHG_MIN,
+ BQ25630_ICHG_MAX, BQ25630_ICHG_STEP,
+ BQ25630_ICHG_MIN_REGVAL,
+ data->batinfo->constant_charge_current_max_ua);
+ if (ret)
+ return ret;
+ } else
+ dev_warn(data->dev,
+ "Using default value for maximum constant charge current\n");
+
+ if (data->batinfo->charge_term_current_ua >= 0) {
+ ret = bq25630_write_limit(
+ data, BQ25630_REGF_ITERM, BQ25630_ITERM_MIN,
+ BQ25630_ITERM_MAX, BQ25630_ITERM_STEP,
+ BQ25630_ITERM_MIN_REGVAL,
+ data->batinfo->charge_term_current_ua);
+ if (ret)
+ return ret;
+ }
+
+ if (data->batinfo->precharge_current_ua >= 0) {
+ ret = bq25630_write_limit(data, BQ25630_REGF_IPRECHG,
+ BQ25630_IPRECHG_MIN,
+ BQ25630_IPRECHG_MAX,
+ BQ25630_IPRECHG_STEP,
+ BQ25630_IPRECHG_MIN_REGVAL,
+ data->batinfo->precharge_current_ua);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
+static int bq25630_charger_get_property(struct power_supply *psy,
+ enum power_supply_property psp,
+ union power_supply_propval *val)
+{
+ struct bq25630_data *data = power_supply_get_drvdata(psy);
+ int ret = 0;
+
+ switch (psp) {
+ case POWER_SUPPLY_PROP_STATUS:
+ ret = bq25630_get_status(data, &val->intval);
+ break;
+ case POWER_SUPPLY_PROP_CHARGE_TYPE:
+ case POWER_SUPPLY_PROP_CHARGE_TYPES:
+ ret = bq25630_read_charge_type(data, &val->intval);
+ break;
+ case POWER_SUPPLY_PROP_HEALTH:
+ ret = bq25630_read_health(data, &val->intval);
+ break;
+ case POWER_SUPPLY_PROP_ONLINE:
+ ret = regmap_field_read(data->regfields[BQ25630_REGF_EN_CHG],
+ &val->intval);
+ if (ret || !val->intval) {
+ /* Charging is not even enabled. */
+ break;
+ }
+
+ ret = bq25630_read_vbus(data, &val->intval);
+ val->intval = val->intval >= 0;
+ break;
+ case POWER_SUPPLY_PROP_VOLTAGE_MIN:
+ ret = bq25630_read_limit(data, BQ25630_REGF_VSYSMIN,
+ BQ25630_VSYSMIN_MIN,
+ BQ25630_VSYSMIN_STEP,
+ BQ25630_VSYSMIN_MIN_REGVAL,
+ &val->intval);
+ break;
+ case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
+ ret = bq25630_read_limit(data, BQ25630_REGF_ICHG,
+ BQ25630_ICHG_MIN, BQ25630_ICHG_STEP,
+ BQ25630_ICHG_MIN_REGVAL, &val->intval);
+ break;
+ case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX:
+ val->intval = BQ25630_ICHG_MAX;
+ break;
+ case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
+ ret = bq25630_read_limit(data, BQ25630_REGF_VREG,
+ BQ25630_VREG_MIN, BQ25630_VREG_STEP,
+ BQ25630_VREG_MIN_REGVAL, &val->intval);
+ break;
+ case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX:
+ val->intval = BQ25630_VREG_MAX;
+ break;
+ case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
+ ret = bq25630_read_limit(data, BQ25630_REGF_IINDPM,
+ BQ25630_IINDPM_MIN,
+ BQ25630_IINDPM_STEP,
+ BQ25630_IINDPM_MIN_REGVAL,
+ &val->intval);
+ break;
+ case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT:
+ ret = bq25630_read_limit(data, BQ25630_REGF_VINDPM,
+ BQ25630_VINDPM_MIN,
+ BQ25630_VINDPM_STEP,
+ BQ25630_VINDPM_MIN_REGVAL,
+ &val->intval);
+ break;
+ case POWER_SUPPLY_PROP_USB_TYPE:
+ ret = bq25630_read_vbus(data, &val->intval);
+ if (!ret && val->intval < 0) {
+ /* Nothing connected. */
+ val->intval = POWER_SUPPLY_USB_TYPE_UNKNOWN;
+ }
+ break;
+ case POWER_SUPPLY_PROP_PRECHARGE_CURRENT:
+ ret = bq25630_read_limit(data, BQ25630_REGF_IPRECHG,
+ BQ25630_IPRECHG_MIN,
+ BQ25630_IPRECHG_STEP,
+ BQ25630_IPRECHG_MIN_REGVAL,
+ &val->intval);
+ break;
+ case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:
+ ret = bq25630_read_limit(data, BQ25630_REGF_ITERM,
+ BQ25630_ITERM_MIN, BQ25630_ITERM_STEP,
+ BQ25630_ITERM_MIN_REGVAL,
+ &val->intval);
+ break;
+ case POWER_SUPPLY_PROP_MODEL_NAME:
+ val->strval = "BQ25630";
+ break;
+ case POWER_SUPPLY_PROP_MANUFACTURER:
+ val->strval = "Texas Instruments";
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ return ret;
+}
+
+static int bq25630_charger_set_property(struct power_supply *psy,
+ enum power_supply_property psp,
+ const union power_supply_propval *val)
+{
+ struct bq25630_data *data = power_supply_get_drvdata(psy);
+ int ret = 0;
+
+ switch (psp) {
+ case POWER_SUPPLY_PROP_ONLINE:
+ ret = regmap_field_write(data->regfields[BQ25630_REGF_EN_CHG],
+ !!val->intval);
+ break;
+ case POWER_SUPPLY_PROP_VOLTAGE_MIN:
+ ret = bq25630_write_limit(
+ data, BQ25630_REGF_VSYSMIN, BQ25630_VSYSMIN_MIN,
+ BQ25630_VSYSMIN_MAX, BQ25630_VSYSMIN_STEP,
+ BQ25630_VSYSMIN_MIN_REGVAL, val->intval);
+ break;
+ case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
+ ret = bq25630_write_limit(data, BQ25630_REGF_ICHG,
+ BQ25630_ICHG_MIN, BQ25630_ICHG_MAX,
+ BQ25630_ICHG_STEP,
+ BQ25630_ICHG_MIN_REGVAL, val->intval);
+ break;
+ case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
+ ret = bq25630_write_limit(data, BQ25630_REGF_VREG,
+ BQ25630_VREG_MIN, BQ25630_VREG_MAX,
+ BQ25630_VREG_STEP,
+ BQ25630_VREG_MIN_REGVAL, val->intval);
+ break;
+ case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
+ ret = bq25630_write_limit(
+ data, BQ25630_REGF_IINDPM, BQ25630_IINDPM_MIN,
+ BQ25630_IINDPM_MAX, BQ25630_IINDPM_STEP,
+ BQ25630_IINDPM_MIN_REGVAL, val->intval);
+ break;
+ case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT:
+ ret = bq25630_write_limit(
+ data, BQ25630_REGF_VINDPM, BQ25630_VINDPM_MIN,
+ BQ25630_VINDPM_MAX, BQ25630_VINDPM_STEP,
+ BQ25630_VINDPM_MIN_REGVAL, val->intval);
+ break;
+ case POWER_SUPPLY_PROP_PRECHARGE_CURRENT:
+ ret = bq25630_write_limit(
+ data, BQ25630_REGF_IPRECHG, BQ25630_IPRECHG_MIN,
+ BQ25630_IPRECHG_MAX, BQ25630_IPRECHG_STEP,
+ BQ25630_IPRECHG_MIN_REGVAL, val->intval);
+ break;
+ case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:
+ ret = bq25630_write_limit(data, BQ25630_REGF_ITERM,
+ BQ25630_ITERM_MIN, BQ25630_ITERM_MAX,
+ BQ25630_ITERM_STEP,
+ BQ25630_ITERM_MIN_REGVAL,
+ val->intval);
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ return ret;
+}
+
+static int bq25630_charger_property_is_writeable(struct power_supply *psy,
+ enum power_supply_property psp)
+{
+ switch (psp) {
+ case POWER_SUPPLY_PROP_ONLINE:
+ case POWER_SUPPLY_PROP_VOLTAGE_MIN:
+ case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
+ case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
+ case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
+ case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT:
+ case POWER_SUPPLY_PROP_PRECHARGE_CURRENT:
+ case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:
+ return true;
+ default:
+ return false;
+ }
+}
+
+static const enum power_supply_property bq25630_charger_properties[] = {
+ POWER_SUPPLY_PROP_STATUS,
+ POWER_SUPPLY_PROP_CHARGE_TYPE,
+ POWER_SUPPLY_PROP_CHARGE_TYPES,
+ POWER_SUPPLY_PROP_HEALTH,
+ POWER_SUPPLY_PROP_ONLINE,
+ POWER_SUPPLY_PROP_VOLTAGE_MIN,
+ POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT,
+ POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX,
+ POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE,
+ POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX,
+ POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT,
+ POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT,
+ POWER_SUPPLY_PROP_USB_TYPE,
+ POWER_SUPPLY_PROP_PRECHARGE_CURRENT,
+ POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT,
+ POWER_SUPPLY_PROP_MODEL_NAME,
+ POWER_SUPPLY_PROP_MANUFACTURER,
+};
+
+static const struct power_supply_desc bq25630_charger_psy_desc = {
+ .name = BQ25630_DRV_NAME,
+ .type = POWER_SUPPLY_TYPE_USB_TYPE_C,
+ .charge_types = BIT(POWER_SUPPLY_CHARGE_TYPE_NONE) |
+ BIT(POWER_SUPPLY_CHARGE_TYPE_TRICKLE) |
+ BIT(POWER_SUPPLY_CHARGE_TYPE_FAST) |
+ BIT(POWER_SUPPLY_CHARGE_TYPE_LONGLIFE) |
+ BIT(POWER_SUPPLY_CHARGE_TYPE_BYPASS) |
+ BIT(POWER_SUPPLY_CHARGE_TYPE_UNKNOWN),
+ .usb_types = BIT(POWER_SUPPLY_USB_TYPE_UNKNOWN) |
+ BIT(POWER_SUPPLY_USB_TYPE_SDP) |
+ BIT(POWER_SUPPLY_USB_TYPE_DCP) |
+ BIT(POWER_SUPPLY_USB_TYPE_CDP) |
+ BIT(POWER_SUPPLY_USB_TYPE_C),
+ .properties = bq25630_charger_properties,
+ .num_properties = ARRAY_SIZE(bq25630_charger_properties),
+ .get_property = bq25630_charger_get_property,
+ .set_property = bq25630_charger_set_property,
+ .property_is_writeable = bq25630_charger_property_is_writeable,
+};
+
+static int bq25630_probe(struct i2c_client *client)
+{
+ struct power_supply_config psy_cfg = {};
+ struct bq25630_data *data;
+ int ret;
+
+ data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
+ if (!data)
+ return -ENOMEM;
+
+ data->dev = &client->dev;
+
+ data->regmap8 = devm_regmap_init_i2c(client, &bq25630_regmap_config8);
+ if (IS_ERR(data->regmap8))
+ return dev_err_probe(data->dev, PTR_ERR(data->regmap8),
+ "Could not initialize regmap8\n");
+
+ ret = bq25630_alloc_regfield_range(data, BQ25630_REGF_WATCHDOG,
+ BQ25630_REGF_TS_STAT,
+ data->regmap8);
+ if (ret)
+ return ret;
+
+ data->regmap16le =
+ devm_regmap_init_i2c(client, &bq25630_regmap_config16le);
+ if (IS_ERR(data->regmap16le))
+ return dev_err_probe(data->dev, PTR_ERR(data->regmap16le),
+ "Could not initialize regmap16le\n");
+
+ ret = bq25630_alloc_regfield_range(data, BQ25630_REGF_ICHG,
+ BQ25630_REGF_ITERM,
+ data->regmap16le);
+ if (ret)
+ return ret;
+
+ data->regmap16be =
+ devm_regmap_init_i2c(client, &bq25630_regmap_config16be);
+ if (IS_ERR(data->regmap16be))
+ return dev_err_probe(data->dev, PTR_ERR(data->regmap16be),
+ "Could not initialize regmap16be\n");
+
+ ret = bq25630_alloc_regfield_range(data, BQ25630_REGF_IBUS_ADC,
+ BQ25630_REGF_VBUS_ADC,
+ data->regmap16be);
+ if (ret)
+ return ret;
+
+ psy_cfg.drv_data = data;
+ psy_cfg.fwnode = dev_fwnode(data->dev);
+ data->psy = devm_power_supply_register(
+ data->dev, &bq25630_charger_psy_desc, &psy_cfg);
+ if (IS_ERR(data->psy))
+ return dev_err_probe(data->dev, PTR_ERR(data->psy),
+ "Could not register power supply\n");
+
+ ret = power_supply_get_battery_info(data->psy, &data->batinfo);
+ if (ret)
+ return dev_err_probe(data->dev, ret,
+ "Could not get battery info\n");
+
+ /*
+ * Device sends active low 256 µs pulse to report status and fault.
+ *
+ * Note that we need to request this *after* registering the power
+ * supply so devm destructs it correctly in the reverse order. Otherwise
+ * spurious interrupts could call power_supply_changed() wrongly with a
+ * uninitialized/deallocated power supply.
+ */
+ ret = devm_request_threaded_irq(data->dev, client->irq, NULL,
+ bq25630_irq_thread,
+ IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ NULL, data);
+ if (ret)
+ return dev_err_probe(data->dev, ret, "Could not request IRQ\n");
+
+ ret = bq25630_setup(data);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
+static const struct of_device_id bq25630_of_match[] = {
+ {
+ .compatible = "ti,bq25630",
+ },
+ {}
+};
+MODULE_DEVICE_TABLE(of, bq25630_of_match);
+
+static struct i2c_driver bq25630_driver = {
+ .driver = {
+ .name = BQ25630_DRV_NAME,
+ .of_match_table = bq25630_of_match,
+ },
+ .probe = bq25630_probe,
+};
+module_i2c_driver(bq25630_driver);
+
+MODULE_AUTHOR("Waqar Hameed <waqar.hameed@axis.com>");
+MODULE_DESCRIPTION("TI BQ25630 charger driver");
+MODULE_LICENSE("GPL");
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread