From: Reinette Chatre <reinette.chatre@intel.com>
To: Peter Newman <peternewman@google.com>,
Fenghua Yu <fenghua.yu@intel.com>,
James Morse <james.morse@arm.com>
Cc: Stephane Eranian <eranian@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Uros Bizjak <ubizjak@gmail.com>, Mike Rapoport <rppt@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Xin Li <xin3.li@intel.com>, Babu Moger <babu.moger@amd.com>,
Shaopeng Tan <tan.shaopeng@fujitsu.com>,
"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>,
Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tycho Andersen <tandersen@netflix.com>,
Nicholas Piggin <npiggin@gmail.com>,
Beau Belgrave <beaub@linux.microsoft.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 5/6] x86/resctrl: Abstract PQR_ASSOC from generic code
Date: Fri, 5 Apr 2024 10:15:07 -0700 [thread overview]
Message-ID: <d410aa13-0060-418d-bafa-c24f9653861c@intel.com> (raw)
In-Reply-To: <20240325172707.73966-6-peternewman@google.com>
Hi Peter,
On 3/25/2024 10:27 AM, Peter Newman wrote:
> While CLOSID and RMID originated in RDT, the concept applies to other
> architectures, as it's standard to write allocation and monitoring IDs
> into per-CPU registers.
>
> - Rename resctrl_pqr_state and pqr_state to be more
> architecturally-neutral.
>
> - Introduce resctrl_arch_update_cpu() to replace the explicit write to
> MSR_IA32_PQR_ASSOC in __resctrl_sched_in(). In the case of MPAM,
> PARTID[_I,D] and PMG are a simple function of closid, rmid, and an
> internal global.
>
> - Update terminology containing explicit references to the PQR_ASSOC
> register.
fyi ... I just noticed this while looking at the MPAM patches that there
is an instance in comments of update_closid_rmid() where this
was misspelled (PGR_ASSOC) and thus not picked up by your rename
script.
Reinette
next prev parent reply other threads:[~2024-04-05 17:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 17:27 [PATCH v1 0/6] x86/resctrl: Avoid searching tasklist during mongrp_reparent Peter Newman
2024-03-25 17:27 ` [PATCH v1 1/6] x86/resctrl: Move __resctrl_sched_in() out-of-line Peter Newman
2024-04-04 23:09 ` Reinette Chatre
2024-04-05 22:04 ` Peter Newman
2024-04-07 19:21 ` Reinette Chatre
2024-04-08 19:05 ` Peter Newman
2024-04-08 20:59 ` Reinette Chatre
2024-04-08 21:41 ` Peter Newman
2024-04-09 3:53 ` Reinette Chatre
2024-03-25 17:27 ` [PATCH v1 2/6] x86/resctrl: Add hook for releasing task_struct references Peter Newman
2024-04-04 23:10 ` Reinette Chatre
2024-03-25 17:27 ` [PATCH v1 3/6] x86/resctrl: Disallow mongroup rename on MPAM Peter Newman
2024-04-04 23:11 ` Reinette Chatre
2024-04-05 22:10 ` Peter Newman
2024-12-05 15:03 ` Peter Newman
2024-12-06 4:14 ` Reinette Chatre
2024-12-06 10:23 ` Peter Newman
2024-12-06 16:14 ` Reinette Chatre
2024-03-25 17:27 ` [PATCH v1 4/6] x86/resctrl: Use rdtgroup pointer to indicate task membership Peter Newman
2024-04-04 23:15 ` Reinette Chatre
2024-03-25 17:27 ` [PATCH v1 5/6] x86/resctrl: Abstract PQR_ASSOC from generic code Peter Newman
2024-04-04 23:16 ` Reinette Chatre
2024-04-05 17:15 ` Reinette Chatre [this message]
2024-04-07 19:21 ` Reinette Chatre
2024-03-25 17:27 ` [PATCH v1 6/6] x86/resctrl: Don't search tasklist in mongroup rename Peter Newman
2024-04-04 23:18 ` Reinette Chatre
2024-04-04 23:09 ` [PATCH v1 0/6] x86/resctrl: Avoid searching tasklist during mongrp_reparent Reinette Chatre
2024-04-05 21:30 ` Peter Newman
2024-04-07 19:13 ` Reinette Chatre
2024-04-11 22:34 ` Moger, Babu
2024-04-11 22:44 ` Peter Newman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d410aa13-0060-418d-bafa-c24f9653861c@intel.com \
--to=reinette.chatre@intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=babu.moger@amd.com \
--cc=beaub@linux.microsoft.com \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=oleg@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=tan.shaopeng@fujitsu.com \
--cc=tandersen@netflix.com \
--cc=tglx@linutronix.de \
--cc=ubizjak@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox