public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: chenzhou <chenzhou10@huawei.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: <tj@kernel.org>, <lizefan.x@bytedance.com>, <hannes@cmpxchg.org>,
	<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse_param()
Date: Thu, 14 Jan 2021 22:08:19 +0800	[thread overview]
Message-ID: <d4ba14b0-ee06-b793-a840-2c2ff369d890@huawei.com> (raw)
In-Reply-To: <YABDWvI2PWQpnv59@blackbook>

Hi Michal,

On 2021/1/14 21:12, Michal Koutný wrote:
> Hello Chen.
>
> On Fri, Dec 18, 2020 at 02:17:55PM +0800, Chen Zhou <chenzhou10@huawei.com> wrote:
>> When mounting a cgroup hierarchy with disabled controller in cgroup v1,
>> all available controllers will be attached.
> Not sure if I understand the situation -- have you observed a v1
> controller attached to a hierarchy while specifying cgroup_no_v1= kernel
> cmdline arg?
Yeah, this is the situation.
In this case, at the beginning of function check_cgroupfs_options(), the mask
ctx->subsys_mask will be 0. And if we mount without 'none' and 'name=' options,
then in check_cgroupfs_options(), the flag ctx->all_ss will be set, that is, select all the subsystems.

Thanks,
Chen Zhou
>
> AFAICS, the disabled controllers are honored thanks to
> check_cgroupfs_options().
>
> Michal


  reply	other threads:[~2021-01-14 14:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18  6:17 [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse_param() Chen Zhou
2020-12-18  7:02 ` Zefan Li
2021-01-14 13:12 ` Michal Koutný
2021-01-14 14:08   ` chenzhou [this message]
2021-01-14 16:54     ` Michal Koutný
2021-01-15  1:55       ` chenzhou
2021-01-15  3:17         ` Tejun Heo
2021-01-15  5:58           ` chenzhou
2021-01-15 10:08         ` Michal Koutný
2021-01-15 11:09           ` chenzhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4ba14b0-ee06-b793-a840-2c2ff369d890@huawei.com \
    --to=chenzhou10@huawei.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox