public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: chenzhou <chenzhou10@huawei.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: <tj@kernel.org>, <lizefan.x@bytedance.com>, <hannes@cmpxchg.org>,
	<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse_param()
Date: Fri, 15 Jan 2021 19:09:23 +0800	[thread overview]
Message-ID: <4abe04f8-e7a9-ab2e-f5d1-bb569e2dc157@huawei.com> (raw)
In-Reply-To: <YAFpt6aYW4nVQoZf@blackbook>

Hi Michal,

On 2021/1/15 18:08, Michal Koutný wrote:
> On Fri, Jan 15, 2021 at 09:55:43AM +0800, chenzhou <chenzhou10@huawei.com> wrote:
>> Yeah, this will select all enabled controllers, but which doesn't the behavior we want.
> I see what the issue is now.
>
>> See above. Just the mount behavior isn't what we what.
> I agree this a bug and your I find your approach correct
>
> Reviewed-by: Michal Koutný <mkoutny@suse.com>
I have sent the v3, which updates the description and add Fixes. 
[v3]: https://lore.kernel.org/patchwork/patch/1365535/
If it is ok for you to add Reviewed-by there.

Thanks,
Chen Zhou
>
>> The behavior was changed since commit f5dfb5315d34 ("cgroup: take
>> options parsing into ->parse_monolithic()"), will add this as Fixes.
> Thanks.
>
> Michal


      reply	other threads:[~2021-01-15 11:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18  6:17 [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse_param() Chen Zhou
2020-12-18  7:02 ` Zefan Li
2021-01-14 13:12 ` Michal Koutný
2021-01-14 14:08   ` chenzhou
2021-01-14 16:54     ` Michal Koutný
2021-01-15  1:55       ` chenzhou
2021-01-15  3:17         ` Tejun Heo
2021-01-15  5:58           ` chenzhou
2021-01-15 10:08         ` Michal Koutný
2021-01-15 11:09           ` chenzhou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4abe04f8-e7a9-ab2e-f5d1-bb569e2dc157@huawei.com \
    --to=chenzhou10@huawei.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox