From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Haichen Feng <2806891994@qq.com>
Cc: Hans de Goede <hansg@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v4] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
Date: Thu, 7 May 2026 15:57:30 +0300 (EEST) [thread overview]
Message-ID: <d50fc9a7-52d4-eda5-0082-8e11f71235fc@linux.intel.com> (raw)
In-Reply-To: <tencent_99A9EA72B4A101066BC4B6F391F41BB8E309@qq.com>
On Tue, 5 May 2026, Haichen Feng wrote:
> The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
> S boards, but requires quirks for correctly switching thermal profile.
>
> Add the DMI board name to victus_s_thermal_profile_boards[] table and
> map it to omen_v1_thermal_params.
>
> Testing on board 8BC2 confirmed that platform profile is registered
> successfully and fan RPMs are readable and controllable.
>
> Signed-off-by: Haichen Feng <2806891994@qq.com>
> ---
> Change in v2:
> - Move code to correct place
>
> Change in v3:
> - Move code to the front of 8BCA
>
> Change in v4:
> - Add explanation about this patch
> - Insert a space at the second parenthesis in 8BC2 line
> ---
> drivers/platform/x86/hp/hp-wmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index d1cc6e7d1..71a2093cc 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -205,6 +205,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
> .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
> .driver_data = (void *)&victus_s_thermal_params,
> },
> + {
> + .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BC2") },
> + .driver_data = (void *)&omen_v1_thermal_params,
> + },
> {
> .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
> .driver_data = (void *)&omen_v1_thermal_params,
>
Hi,
Can you please resend this v4 into a new thread. b4 I use while applying
patches seems to unable to capture it from here and gets the wrong
version.
--
i.
next prev parent reply other threads:[~2026-05-07 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <930ba4a0-91be-03b3-4f71-4f43ea334843@linux.intel.com>
[not found] ` <tencent_6AA70E451B0D40B766785B0909ADC12A7E05@qq.com>
2026-05-05 10:06 ` [PATCH v3] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2) Ilpo Järvinen
2026-05-05 11:44 ` [PATCH v4] " Haichen Feng
2026-05-07 12:57 ` Ilpo Järvinen [this message]
2026-05-07 14:02 Haichen Feng
2026-05-07 14:25 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d50fc9a7-52d4-eda5-0082-8e11f71235fc@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=2806891994@qq.com \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox