* Re: [PATCH v3] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
[not found] ` <tencent_6AA70E451B0D40B766785B0909ADC12A7E05@qq.com>
@ 2026-05-05 10:06 ` Ilpo Järvinen
2026-05-05 11:44 ` [PATCH v4] " Haichen Feng
0 siblings, 1 reply; 5+ messages in thread
From: Ilpo Järvinen @ 2026-05-05 10:06 UTC (permalink / raw)
To: Haichen Feng; +Cc: Hans de Goede, LKML, platform-driver-x86
On Fri, 1 May 2026, Haichen Feng wrote:
> Sorry for write wrong patch. It is my mistake. This patch move 8BC2 to
> the front of 8BCA.
Hi,
Thanks for the update but here you should describe the change. This text
will be directly taken as the commit message of the resulting commit, so
think of reviewers of your patch and those reading kernel's commit history
later and write to those audiences.
I think the previous version had better text here (but this is based on my
memory, I didn't actually go to fetch v2 from archives).
> Signed-off-by: Haichen Feng <2806891994@qq.com>
> ---
> Change in v3:
> - Move 8BC2 to the front of 8BCA
If you want to have extra explanation about the process that got you here
which should be put into the commit message, the place for such text is
after the --- line like you have tha patch changelog (correctly) here.
--
i.
> ---
> drivers/platform/x86/hp/hp-wmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index d1cc6e7d1..a5cda787c 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -205,6 +205,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
> .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
> .driver_data = (void *)&victus_s_thermal_params,
> },
> + {
> + .matches = {DMI_MATCH(DMI_BOARD_NAME, "8BC2")},
> + .driver_data = (void *)&omen_v1_thermal_params,
> + },
> {
> .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
> .driver_data = (void *)&omen_v1_thermal_params,
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v4] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
2026-05-05 10:06 ` [PATCH v3] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2) Ilpo Järvinen
@ 2026-05-05 11:44 ` Haichen Feng
2026-05-07 12:57 ` Ilpo Järvinen
0 siblings, 1 reply; 5+ messages in thread
From: Haichen Feng @ 2026-05-05 11:44 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: 2806891994, hansg, linux-kernel, platform-driver-x86
The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
S boards, but requires quirks for correctly switching thermal profile.
Add the DMI board name to victus_s_thermal_profile_boards[] table and
map it to omen_v1_thermal_params.
Testing on board 8BC2 confirmed that platform profile is registered
successfully and fan RPMs are readable and controllable.
Signed-off-by: Haichen Feng <2806891994@qq.com>
---
Change in v2:
- Move code to correct place
Change in v3:
- Move code to the front of 8BCA
Change in v4:
- Add explanation about this patch
- Insert a space at the second parenthesis in 8BC2 line
---
drivers/platform/x86/hp/hp-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index d1cc6e7d1..71a2093cc 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -205,6 +205,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
.driver_data = (void *)&victus_s_thermal_params,
},
+ {
+ .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BC2") },
+ .driver_data = (void *)&omen_v1_thermal_params,
+ },
{
.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
.driver_data = (void *)&omen_v1_thermal_params,
--
2.54.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v4] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
2026-05-05 11:44 ` [PATCH v4] " Haichen Feng
@ 2026-05-07 12:57 ` Ilpo Järvinen
0 siblings, 0 replies; 5+ messages in thread
From: Ilpo Järvinen @ 2026-05-07 12:57 UTC (permalink / raw)
To: Haichen Feng; +Cc: Hans de Goede, LKML, platform-driver-x86
On Tue, 5 May 2026, Haichen Feng wrote:
> The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
> S boards, but requires quirks for correctly switching thermal profile.
>
> Add the DMI board name to victus_s_thermal_profile_boards[] table and
> map it to omen_v1_thermal_params.
>
> Testing on board 8BC2 confirmed that platform profile is registered
> successfully and fan RPMs are readable and controllable.
>
> Signed-off-by: Haichen Feng <2806891994@qq.com>
> ---
> Change in v2:
> - Move code to correct place
>
> Change in v3:
> - Move code to the front of 8BCA
>
> Change in v4:
> - Add explanation about this patch
> - Insert a space at the second parenthesis in 8BC2 line
> ---
> drivers/platform/x86/hp/hp-wmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index d1cc6e7d1..71a2093cc 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -205,6 +205,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
> .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
> .driver_data = (void *)&victus_s_thermal_params,
> },
> + {
> + .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BC2") },
> + .driver_data = (void *)&omen_v1_thermal_params,
> + },
> {
> .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
> .driver_data = (void *)&omen_v1_thermal_params,
>
Hi,
Can you please resend this v4 into a new thread. b4 I use while applying
patches seems to unable to capture it from here and gets the wrong
version.
--
i.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
@ 2026-05-07 14:02 Haichen Feng
2026-05-07 14:25 ` Ilpo Järvinen
0 siblings, 1 reply; 5+ messages in thread
From: Haichen Feng @ 2026-05-07 14:02 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: 2806891994, hansg, linux-kernel, platform-driver-x86
The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
S boards, but requires quirks for correctly switching thermal profile.
Add the DMI board name to victus_s_thermal_profile_boards[] table and
map it to omen_v1_thermal_params.
Testing on board 8BC2 confirmed that platform profile is registered
successfully and fan RPMs are readable and controllable.
Signed-off-by: Haichen Feng <2806891994@qq.com>
---
Change in v2:
- Move code to correct place
Change in v3:
- Move code to the front of 8BCA
Change in v4:
- Add explanation about this patch
- Insert a space at the second parenthesis in 8BC2 line
---
drivers/platform/x86/hp/hp-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index d1cc6e7d1..71a2093cc 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -205,6 +205,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
.driver_data = (void *)&victus_s_thermal_params,
},
+ {
+ .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BC2") },
+ .driver_data = (void *)&omen_v1_thermal_params,
+ },
{
.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
.driver_data = (void *)&omen_v1_thermal_params,
--
2.54.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v4] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
2026-05-07 14:02 Haichen Feng
@ 2026-05-07 14:25 ` Ilpo Järvinen
0 siblings, 0 replies; 5+ messages in thread
From: Ilpo Järvinen @ 2026-05-07 14:25 UTC (permalink / raw)
To: Haichen Feng; +Cc: hansg, linux-kernel, platform-driver-x86
On Thu, 07 May 2026 22:02:42 +0800, Haichen Feng wrote:
> The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
> S boards, but requires quirks for correctly switching thermal profile.
>
> Add the DMI board name to victus_s_thermal_profile_boards[] table and
> map it to omen_v1_thermal_params.
>
> Testing on board 8BC2 confirmed that platform profile is registered
> successfully and fan RPMs are readable and controllable.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
commit: a59e45221df82e8a6246c617615c1ccc12e3545d
--
i.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-05-07 14:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <930ba4a0-91be-03b3-4f71-4f43ea334843@linux.intel.com>
[not found] ` <tencent_6AA70E451B0D40B766785B0909ADC12A7E05@qq.com>
2026-05-05 10:06 ` [PATCH v3] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2) Ilpo Järvinen
2026-05-05 11:44 ` [PATCH v4] " Haichen Feng
2026-05-07 12:57 ` Ilpo Järvinen
2026-05-07 14:02 Haichen Feng
2026-05-07 14:25 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox