* [PATCH] drm/amd/display: remove duplicated argument
@ 2023-10-29 9:39 José Pekkarinen
2023-10-30 13:54 ` Aurabindo Pillai
2023-11-08 16:32 ` Aurabindo Pillai
0 siblings, 2 replies; 5+ messages in thread
From: José Pekkarinen @ 2023-10-29 9:39 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, skhan
Cc: José Pekkarinen, airlied, daniel, qingqing.zhuo, Jun.Lei,
alex.hung, Zhongwei.Zhang, sunran001, Yao.Wang1, aurabindo.pillai,
amd-gfx, dri-devel, linux-kernel, linux-kernel-mentees
Spotted by coccicheck, there is a redundant check for
v->SourcePixelFormat[k] != dm_444_16. This patch will
remove it. The corresponding output follows.
drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c:5130:86-122: duplicated argument to && or ||
Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
---
drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
index ad741a723c0e..3686f1e7de3a 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
@@ -5128,7 +5128,7 @@ void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
ViewportExceedsSurface = true;
if (v->SourcePixelFormat[k] != dm_444_64 && v->SourcePixelFormat[k] != dm_444_32 && v->SourcePixelFormat[k] != dm_444_16
- && v->SourcePixelFormat[k] != dm_444_16 && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] != dm_rgbe) {
+ && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] != dm_rgbe) {
if (v->ViewportWidthChroma[k] > v->SurfaceWidthC[k] || v->ViewportHeightChroma[k] > v->SurfaceHeightC[k]) {
ViewportExceedsSurface = true;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: remove duplicated argument
2023-10-29 9:39 [PATCH] drm/amd/display: remove duplicated argument José Pekkarinen
@ 2023-10-30 13:54 ` Aurabindo Pillai
2023-11-08 7:36 ` José Pekkarinen
2023-11-08 16:32 ` Aurabindo Pillai
1 sibling, 1 reply; 5+ messages in thread
From: Aurabindo Pillai @ 2023-10-30 13:54 UTC (permalink / raw)
To: José Pekkarinen, harry.wentland, sunpeng.li,
Rodrigo.Siqueira, alexander.deucher, christian.koenig, Xinhui.Pan,
skhan
Cc: airlied, daniel, qingqing.zhuo, Jun.Lei, alex.hung,
Zhongwei.Zhang, sunran001, Yao.Wang1, amd-gfx, dri-devel,
linux-kernel, linux-kernel-mentees
On 10/29/2023 5:39 AM, José Pekkarinen wrote:
> Spotted by coccicheck, there is a redundant check for
> v->SourcePixelFormat[k] != dm_444_16. This patch will
> remove it. The corresponding output follows.
>
> drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c:5130:86-122: duplicated argument to && or ||
>
> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
> ---
> drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> index ad741a723c0e..3686f1e7de3a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> @@ -5128,7 +5128,7 @@ void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
> ViewportExceedsSurface = true;
>
> if (v->SourcePixelFormat[k] != dm_444_64 && v->SourcePixelFormat[k] != dm_444_32 && v->SourcePixelFormat[k] != dm_444_16
> - && v->SourcePixelFormat[k] != dm_444_16 && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] != dm_rgbe) {
> + && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] != dm_rgbe) {
> if (v->ViewportWidthChroma[k] > v->SurfaceWidthC[k] || v->ViewportHeightChroma[k] > v->SurfaceHeightC[k]) {
> ViewportExceedsSurface = true;
> }
Thanks for catching.
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: remove duplicated argument
2023-10-30 13:54 ` Aurabindo Pillai
@ 2023-11-08 7:36 ` José Pekkarinen
2023-11-08 19:00 ` Alex Deucher
0 siblings, 1 reply; 5+ messages in thread
From: José Pekkarinen @ 2023-11-08 7:36 UTC (permalink / raw)
To: Aurabindo Pillai
Cc: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, skhan, airlied, daniel,
qingqing.zhuo, Jun.Lei, alex.hung, Zhongwei.Zhang, sunran001,
Yao.Wang1, amd-gfx, dri-devel, linux-kernel, linux-kernel-mentees
On 2023-10-30 15:54, Aurabindo Pillai wrote:
> On 10/29/2023 5:39 AM, José Pekkarinen wrote:
>> Spotted by coccicheck, there is a redundant check for
>> v->SourcePixelFormat[k] != dm_444_16. This patch will
>> remove it. The corresponding output follows.
>>
>> drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c:5130:86-122:
>> duplicated argument to && or ||
>>
>> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
>> ---
>> drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 2
>> +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
>> b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
>> index ad741a723c0e..3686f1e7de3a 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
>> @@ -5128,7 +5128,7 @@ void
>> dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib
>> *mode_l
>> ViewportExceedsSurface = true;
>> if (v->SourcePixelFormat[k] != dm_444_64 &&
>> v->SourcePixelFormat[k] != dm_444_32 && v->SourcePixelFormat[k] !=
>> dm_444_16
>> - && v->SourcePixelFormat[k] != dm_444_16 &&
>> v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] !=
>> dm_rgbe) {
>> + && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k]
>> != dm_rgbe) {
>> if (v->ViewportWidthChroma[k] > v->SurfaceWidthC[k] ||
>> v->ViewportHeightChroma[k] > v->SurfaceHeightC[k]) {
>> ViewportExceedsSurface = true;
>> }
>
> Thanks for catching.
>
> Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Sorry to bring this up, I just wanted to check whether this
has been applied in the following pulls or not.
Thanks!
José.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: remove duplicated argument
2023-10-29 9:39 [PATCH] drm/amd/display: remove duplicated argument José Pekkarinen
2023-10-30 13:54 ` Aurabindo Pillai
@ 2023-11-08 16:32 ` Aurabindo Pillai
1 sibling, 0 replies; 5+ messages in thread
From: Aurabindo Pillai @ 2023-11-08 16:32 UTC (permalink / raw)
To: José Pekkarinen, harry.wentland, sunpeng.li,
Rodrigo.Siqueira, alexander.deucher, christian.koenig, Xinhui.Pan,
skhan
Cc: airlied, daniel, qingqing.zhuo, Jun.Lei, alex.hung,
Zhongwei.Zhang, sunran001, Yao.Wang1, amd-gfx, dri-devel,
linux-kernel, linux-kernel-mentees
On 2023-10-29 05:39, José Pekkarinen wrote:
> Spotted by coccicheck, there is a redundant check for
> v->SourcePixelFormat[k] != dm_444_16. This patch will
> remove it. The corresponding output follows.
>
> drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c:5130:86-122: duplicated argument to && or ||
>
> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
> ---
> drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> index ad741a723c0e..3686f1e7de3a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> @@ -5128,7 +5128,7 @@ void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
> ViewportExceedsSurface = true;
>
> if (v->SourcePixelFormat[k] != dm_444_64 && v->SourcePixelFormat[k] != dm_444_32 && v->SourcePixelFormat[k] != dm_444_16
> - && v->SourcePixelFormat[k] != dm_444_16 && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] != dm_rgbe) {
> + && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] != dm_rgbe) {
> if (v->ViewportWidthChroma[k] > v->SurfaceWidthC[k] || v->ViewportHeightChroma[k] > v->SurfaceHeightC[k]) {
> ViewportExceedsSurface = true;
> }
Hi José,
Sorry, I've just queued it. Should be merged to amd-staging-drm-next soon.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: remove duplicated argument
2023-11-08 7:36 ` José Pekkarinen
@ 2023-11-08 19:00 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2023-11-08 19:00 UTC (permalink / raw)
To: José Pekkarinen
Cc: Aurabindo Pillai, sunran001, sunpeng.li, qingqing.zhuo,
Xinhui.Pan, Rodrigo.Siqueira, linux-kernel, amd-gfx,
Zhongwei.Zhang, alex.hung, Yao.Wang1, dri-devel, skhan,
alexander.deucher, Jun.Lei, christian.koenig,
linux-kernel-mentees
Applied. Thanks!
On Wed, Nov 8, 2023 at 3:52 AM José Pekkarinen
<jose.pekkarinen@foxhound.fi> wrote:
>
> On 2023-10-30 15:54, Aurabindo Pillai wrote:
> > On 10/29/2023 5:39 AM, José Pekkarinen wrote:
> >> Spotted by coccicheck, there is a redundant check for
> >> v->SourcePixelFormat[k] != dm_444_16. This patch will
> >> remove it. The corresponding output follows.
> >>
> >> drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c:5130:86-122:
> >> duplicated argument to && or ||
> >>
> >> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
> >> ---
> >> drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 2
> >> +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git
> >> a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> >> b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> >> index ad741a723c0e..3686f1e7de3a 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> >> @@ -5128,7 +5128,7 @@ void
> >> dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib
> >> *mode_l
> >> ViewportExceedsSurface = true;
> >> if (v->SourcePixelFormat[k] != dm_444_64 &&
> >> v->SourcePixelFormat[k] != dm_444_32 && v->SourcePixelFormat[k] !=
> >> dm_444_16
> >> - && v->SourcePixelFormat[k] != dm_444_16 &&
> >> v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] !=
> >> dm_rgbe) {
> >> + && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k]
> >> != dm_rgbe) {
> >> if (v->ViewportWidthChroma[k] > v->SurfaceWidthC[k] ||
> >> v->ViewportHeightChroma[k] > v->SurfaceHeightC[k]) {
> >> ViewportExceedsSurface = true;
> >> }
> >
> > Thanks for catching.
> >
> > Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
>
> Sorry to bring this up, I just wanted to check whether this
> has been applied in the following pulls or not.
>
> Thanks!
>
> José.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-08 19:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-29 9:39 [PATCH] drm/amd/display: remove duplicated argument José Pekkarinen
2023-10-30 13:54 ` Aurabindo Pillai
2023-11-08 7:36 ` José Pekkarinen
2023-11-08 19:00 ` Alex Deucher
2023-11-08 16:32 ` Aurabindo Pillai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox