* Re: [PATCH sched_ext/for-7.1-fixes] tools/sched_ext: Add missing -d option in scx_flatcg
[not found] <20260418092247.1541377-1-yphbchou0911@gmail.com>
@ 2026-04-19 16:04 ` Tejun Heo
2026-04-19 16:08 ` Cheng-Yang Chou
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2026-04-19 16:04 UTC (permalink / raw)
To: Cheng-Yang Chou, sched-ext, David Vernet, Andrea Righi,
Changwoo Min
Cc: Ching-Chun Huang, Chia-Ping Tsai, Emil Tsalapatis, linux-kernel
Hello,
-d is dead code - it just sets dump_cgrps which is only echoed in the
status-line printf, nothing actually dumps the cgroup hierarchy. The
right thing to do is remove the whole thing - the 'd' in getopt(), case
'd':, the dump_cgrps variable and its printf - rather than document dead
code as a feature.
Want to spin a removal patch?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH sched_ext/for-7.1-fixes] tools/sched_ext: Add missing -d option in scx_flatcg
2026-04-19 16:04 ` [PATCH sched_ext/for-7.1-fixes] tools/sched_ext: Add missing -d option in scx_flatcg Tejun Heo
@ 2026-04-19 16:08 ` Cheng-Yang Chou
0 siblings, 0 replies; 2+ messages in thread
From: Cheng-Yang Chou @ 2026-04-19 16:08 UTC (permalink / raw)
To: Tejun Heo
Cc: sched-ext, David Vernet, Andrea Righi, Changwoo Min,
Ching-Chun Huang, Chia-Ping Tsai, Emil Tsalapatis, linux-kernel
Hi Tejun,
On Sun, Apr 19, 2026 at 06:04:34AM -1000, Tejun Heo wrote:
> -d is dead code - it just sets dump_cgrps which is only echoed in the
> status-line printf, nothing actually dumps the cgroup hierarchy. The
> right thing to do is remove the whole thing - the 'd' in getopt(), case
> 'd':, the dump_cgrps variable and its printf - rather than document dead
> code as a feature.
>
> Want to spin a removal patch?
Yeah, for sure! Thanks for the explanation, will do!
--
Cheers,
Cheng-Yang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-19 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260418092247.1541377-1-yphbchou0911@gmail.com>
2026-04-19 16:04 ` [PATCH sched_ext/for-7.1-fixes] tools/sched_ext: Add missing -d option in scx_flatcg Tejun Heo
2026-04-19 16:08 ` Cheng-Yang Chou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox