From: Christian Loehle <christian.loehle@arm.com>
To: Kevin Brodsky <kevin.brodsky@arm.com>,
linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH] sched: Remove unused variable in mm_cid_get()
Date: Mon, 20 Oct 2025 11:16:09 +0100 [thread overview]
Message-ID: <d76040f3-40d2-4cc3-bf59-cdd9f6673ad2@arm.com> (raw)
In-Reply-To: <20251017073050.2411988-1-kevin.brodsky@arm.com>
On 10/17/25 08:30, Kevin Brodsky wrote:
> The cpumask variable in mm_cid_get() has never been used, remove it.
>
> This fixes a -Wunused-but-set-variable warning when building with
> W=1.
>
> Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
> ---
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Juri Lelli <juri.lelli@redhat.com>
> ---
> kernel/sched/sched.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 1f5d07067f60..361f9101cef9 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -3740,11 +3740,9 @@ static inline int mm_cid_get(struct rq *rq, struct task_struct *t,
> struct mm_struct *mm)
> {
> struct mm_cid __percpu *pcpu_cid = mm->pcpu_cid;
> - struct cpumask *cpumask;
> int cid;
>
> lockdep_assert_rq_held(rq);
> - cpumask = mm_cidmask(mm);
> cid = __this_cpu_read(pcpu_cid->cid);
> if (mm_cid_is_valid(cid)) {
> mm_cid_snapshot_time(rq, mm);
>
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
Andy also posted this:
https://lore.kernel.org/lkml/20251015091935.2977229-1-andriy.shevchenko@linux.intel.com/
next prev parent reply other threads:[~2025-10-20 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 7:30 [PATCH] sched: Remove unused variable in mm_cid_get() Kevin Brodsky
2025-10-20 10:16 ` Christian Loehle [this message]
2025-10-20 10:34 ` Kevin Brodsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d76040f3-40d2-4cc3-bf59-cdd9f6673ad2@arm.com \
--to=christian.loehle@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=juri.lelli@redhat.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox