From: Reinette Chatre <reinette.chatre@intel.com>
To: Ben Horgan <ben.horgan@arm.com>, <linux-kernel@vger.kernel.org>
Cc: <tony.luck@intel.com>, <Dave.Martin@arm.com>,
<james.morse@arm.com>, <babu.moger@amd.com>, <tglx@kernel.org>,
<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
<x86@kernel.org>, <hpa@zytor.com>, <fenghuay@nvidia.com>,
<tan.shaopeng@fujitsu.com>
Subject: Re: [PATCH v6 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs()
Date: Tue, 5 May 2026 15:43:15 -0700 [thread overview]
Message-ID: <d809813a-945c-4883-a78a-14dd7719eef2@intel.com> (raw)
In-Reply-To: <20260505155741.3591201-2-ben.horgan@arm.com>
Hi Ben,
On 5/5/26 8:57 AM, Ben Horgan wrote:
> The error path in resctrl_mkdir_event_configs() is unnecessarily
> complicated. Simplify it to just return directly on error.
>
> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>
An unfortunate typo here. Without the "---" separator the list of
changes below will stay with the changelog.
I'm actually not sure what would be the best course of action here.
Resubmitting whole series to address this seems like a lot but it
may also be best to avoid any confusion.
> Changes since v5:
> Correct order of the tags
> ---
Reinette
next prev parent reply other threads:[~2026-05-05 22:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 15:57 [PATCH v6 0/7] x86,fs/resctrl: Pave the way for MPAM counter assignment Ben Horgan
2026-05-05 15:57 ` [PATCH v6 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() Ben Horgan
2026-05-05 22:43 ` Reinette Chatre [this message]
2026-05-06 8:14 ` Ben Horgan
2026-05-05 15:57 ` [PATCH v6 2/7] x86,fs/resctrl: Create 'event_filter' files read only if they're not configurable Ben Horgan
2026-05-05 15:57 ` [PATCH v6 3/7] fs/resctrl: Disallow the software controller when MBM counters are assignable Ben Horgan
2026-05-05 15:57 ` [PATCH v6 4/7] fs/resctrl: Add monitor property 'mbm_cntr_assign_fixed' Ben Horgan
2026-05-05 15:57 ` [PATCH v6 5/7] fs/resctrl: Continue counter allocation after failure Ben Horgan
2026-05-05 15:57 ` [PATCH v6 6/7] fs/resctrl: Document that automatic counter assignment is best effort Ben Horgan
2026-05-05 15:57 ` [PATCH v6 7/7] fs/resctrl: Document tasks file behaviour for task id 0 and idle tasks Ben Horgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d809813a-945c-4883-a78a-14dd7719eef2@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tan.shaopeng@fujitsu.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox