public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Samuel Zou <zou_wei@huawei.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: <agk@redhat.com>, <dm-devel@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] dm mpath: Remove unused variable ret
Date: Fri, 8 May 2020 09:06:08 +0800	[thread overview]
Message-ID: <d945a16d-5a9d-252f-2dec-1d654c4f7e77@huawei.com> (raw)
In-Reply-To: <20200507142958.GA12032@redhat.com>

Hi Mike,

You are right.
I did not notice that the macro DMEMIT uses the sz variable.

Thanks.

On 2020/5/7 22:29, Mike Snitzer wrote:
> On Thu, May 07 2020 at  8:26am -0400,
> Samuel Zou <zou_wei@huawei.com> wrote:
> 
>> This patch fixes below warning reported by coccicheck:
>>
>> drivers/md/dm-historical-service-time.c:240:14-16: Unneeded variable: "sz". Return "0" on line 261
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
> 
> Nack.
> 
> DMEMIT() uses the local sz variable.
> 
> 


  reply	other threads:[~2020-05-08  1:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 12:26 [PATCH -next] dm mpath: Remove unused variable ret Samuel Zou
2020-05-07 14:29 ` Mike Snitzer
2020-05-08  1:06   ` Samuel Zou [this message]
2020-05-08  1:47 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d945a16d-5a9d-252f-2dec-1d654c4f7e77@huawei.com \
    --to=zou_wei@huawei.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox