From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Piyush Raj Chouhan <pc1598@mainlining.org>,
linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, andersson@kernel.org,
konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, tony.luck@intel.com, gpiccoli@igalia.com
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8150: Add support for Xiaomi Redmi K20 Pro
Date: Wed, 29 Oct 2025 10:06:50 +0100 [thread overview]
Message-ID: <d99b03f4-ae44-4b7d-b4d0-45e2c3058db0@oss.qualcomm.com> (raw)
In-Reply-To: <5C7DC3D9-8DBB-409C-8672-6388EE01C320@mainlining.org>
On 10/28/25 5:13 PM, Piyush Raj Chouhan wrote:
> Hi, konrad
>
>
>>> +
>>> +&i2c19 {
>>> + /* goodix,gt9886 @5d */
>>
>> I see there's driver support for the GT98*97* - is there a chance you can
>> reuse some of it?
>>
>
> I am currently testing touch on gtx8 driver which currently is in lkml, once its merged we could add support for it.
>
> https://lore.kernel.org/linux-input/20250918-gtx8-v1-0-cba879c84775@mainlining.org
That's great!
[...]
>>> + led@2 {
>>> + reg = <2>;
>>> + color = <LED_COLOR_ID_RED>;
>>> + function = LED_FUNCTION_STATUS;
>>> + function-enumerator = <0>;
>>> + };
>>> +
>>> + led@3 {
>>> + reg = <3>;
>>> + color = <LED_COLOR_ID_RED>;
>>> + function = LED_FUNCTION_STATUS;
>>> + function-enumerator = <1>;
>>> + };
>>
>> Are there really two separate red LEDs?
>
> Yes, it has popup camera with an LED on both side, i have verified functionality of both LEDs.
OK, would you mind adding a label= entry with perhaps "Pop-up camera
front/back"?
Konrad
next prev parent reply other threads:[~2025-10-29 9:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 5:40 [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Redmi K20 Pro (Raphael) Piyush Raj Chouhan
2025-10-22 5:40 ` [PATCH 2/2] arm64: dts: qcom: sm8150: Add support for Xiaomi Redmi K20 Pro Piyush Raj Chouhan
2025-10-26 23:36 ` David Heidelberg
2025-10-27 11:35 ` Konrad Dybcio
2025-10-28 16:13 ` Piyush Raj Chouhan
2025-10-29 9:06 ` Konrad Dybcio [this message]
2025-10-30 4:05 ` kernel test robot
2025-10-26 22:10 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Redmi K20 Pro (Raphael) Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d99b03f4-ae44-4b7d-b4d0-45e2c3058db0@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc1598@mainlining.org \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox