* [PATCH 0/2] clk: samsung: Update PLL locktime and samsung function [not found] <CGME20240926144716epcas5p330d6374d8b647f45e056143f237a55aa@epcas5p3.samsung.com> @ 2024-09-26 14:45 ` Varada Pavani 2024-09-26 14:45 ` [PATCH 2/2] clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom Varada Pavani 2024-09-30 10:38 ` [PATCH 0/2] clk: samsung: Update PLL locktime and samsung function Krzysztof Kozlowski 0 siblings, 2 replies; 6+ messages in thread From: Varada Pavani @ 2024-09-26 14:45 UTC (permalink / raw) To: krzk, aswani.reddy, pankaj.dubey, s.nawrocki, cw00.choi, alim.akhtar, mturquette, sboyd, linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel Cc: gost.dev, Varada Pavani This patch series updates samsung clock driver with common samsung CCF function and defines locktime value for PLL142XX controller. Varada Pavani (2): clk: samsung: Use samsung CCF common function clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom drivers/clk/samsung/clk-exynos4.c | 78 +++++++++++++++++-------------- drivers/clk/samsung/clk-pll.c | 7 ++- 2 files changed, 50 insertions(+), 35 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom 2024-09-26 14:45 ` [PATCH 0/2] clk: samsung: Update PLL locktime and samsung function Varada Pavani @ 2024-09-26 14:45 ` Varada Pavani 2024-09-30 10:37 ` Krzysztof Kozlowski 2024-09-30 10:38 ` [PATCH 0/2] clk: samsung: Update PLL locktime and samsung function Krzysztof Kozlowski 1 sibling, 1 reply; 6+ messages in thread From: Varada Pavani @ 2024-09-26 14:45 UTC (permalink / raw) To: krzk, aswani.reddy, pankaj.dubey, s.nawrocki, cw00.choi, alim.akhtar, mturquette, sboyd, linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel Cc: gost.dev, Varada Pavani, stable Add PLL locktime for PLL142XX controller. Fixes: 4f346005aaed ("clk: samsung: fsd: Add initial clock support") Cc: stable@vger.kernel.org Signed-off-by: Varada Pavani <v.pavani@samsung.com> --- drivers/clk/samsung/clk-pll.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c index 4be879ab917e..d4c5ae20de4f 100644 --- a/drivers/clk/samsung/clk-pll.c +++ b/drivers/clk/samsung/clk-pll.c @@ -206,6 +206,7 @@ static const struct clk_ops samsung_pll3000_clk_ops = { */ /* Maximum lock time can be 270 * PDIV cycles */ #define PLL35XX_LOCK_FACTOR (270) +#define PLL142XX_LOCK_FACTOR (150) #define PLL35XX_MDIV_MASK (0x3FF) #define PLL35XX_PDIV_MASK (0x3F) @@ -272,7 +273,11 @@ static int samsung_pll35xx_set_rate(struct clk_hw *hw, unsigned long drate, } /* Set PLL lock time. */ - writel_relaxed(rate->pdiv * PLL35XX_LOCK_FACTOR, + if (pll->type == pll_142xx) + writel_relaxed(rate->pdiv * PLL142XX_LOCK_FACTOR, + pll->lock_reg); + else + writel_relaxed(rate->pdiv * PLL35XX_LOCK_FACTOR, pll->lock_reg); /* Change PLL PMS values */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom 2024-09-26 14:45 ` [PATCH 2/2] clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom Varada Pavani @ 2024-09-30 10:37 ` Krzysztof Kozlowski 2024-10-01 13:30 ` Varada Pavani 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2024-09-30 10:37 UTC (permalink / raw) To: Varada Pavani, aswani.reddy, pankaj.dubey, s.nawrocki, cw00.choi, alim.akhtar, mturquette, sboyd, linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel Cc: gost.dev, stable On 26/09/2024 16:45, Varada Pavani wrote: > Add PLL locktime for PLL142XX controller. You marked it as fixes. Please describe the observable bug and its impact. See submitting patches and stable kernel rules. > > Fixes: 4f346005aaed ("clk: samsung: fsd: Add initial clock support") > Cc: stable@vger.kernel.org > Signed-off-by: Varada Pavani <v.pavani@samsung.com> > --- Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 2/2] clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom 2024-09-30 10:37 ` Krzysztof Kozlowski @ 2024-10-01 13:30 ` Varada Pavani 0 siblings, 0 replies; 6+ messages in thread From: Varada Pavani @ 2024-10-01 13:30 UTC (permalink / raw) To: 'Krzysztof Kozlowski', aswani.reddy, pankaj.dubey, s.nawrocki, cw00.choi, alim.akhtar, mturquette, sboyd, linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel Cc: gost.dev, stable > -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzk@kernel.org] > Sent: 30 September 2024 16:07 > To: Varada Pavani <v.pavani@samsung.com>; aswani.reddy@samsung.com; > pankaj.dubey@samsung.com; s.nawrocki@samsung.com; > cw00.choi@samsung.com; alim.akhtar@samsung.com; > mturquette@baylibre.com; sboyd@kernel.org; linux-samsung- > soc@vger.kernel.org; linux-clk@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Cc: gost.dev@samsung.com; stable@vger.kernel.org > Subject: Re: [PATCH 2/2] clk: samsung: Fixes PLL locktime for PLL142XX used > on FSD platfom > > On 26/09/2024 16:45, Varada Pavani wrote: > > Add PLL locktime for PLL142XX controller. > > You marked it as fixes. Please describe the observable bug and its impact. > See submitting patches and stable kernel rules. > We marked it fixes because there is a software bug. Both PLL142XX and PLL35XX have same configurations with only change in locktime period which is 150*PDIV . Hence updated locktime as per the defined spec. Will update this information in the commit message and push V2 version. Regards, Varada Pavani > > > > Fixes: 4f346005aaed ("clk: samsung: fsd: Add initial clock support") > > Cc: stable@vger.kernel.org > > Signed-off-by: Varada Pavani <v.pavani@samsung.com> > > --- > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] clk: samsung: Update PLL locktime and samsung function 2024-09-26 14:45 ` [PATCH 0/2] clk: samsung: Update PLL locktime and samsung function Varada Pavani 2024-09-26 14:45 ` [PATCH 2/2] clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom Varada Pavani @ 2024-09-30 10:38 ` Krzysztof Kozlowski 1 sibling, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2024-09-30 10:38 UTC (permalink / raw) To: Varada Pavani, aswani.reddy, pankaj.dubey, s.nawrocki, cw00.choi, alim.akhtar, mturquette, sboyd, linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel Cc: gost.dev On 26/09/2024 16:45, Varada Pavani wrote: > This patch series updates samsung clock driver with common samsung > CCF function and defines locktime value for PLL142XX controller. > > Varada Pavani (2): > clk: samsung: Use samsung CCF common function Where is this patch? > clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CGME20240930112127epcas5p2622025d70a7db472b636a97b0fbd7cf2@epcas5p2.samsung.com>]
* [PATCH 0/2] clk: samsung: Update PLL locktime and samsung function [not found] <CGME20240930112127epcas5p2622025d70a7db472b636a97b0fbd7cf2@epcas5p2.samsung.com> @ 2024-09-30 11:18 ` Varada Pavani 0 siblings, 0 replies; 6+ messages in thread From: Varada Pavani @ 2024-09-30 11:18 UTC (permalink / raw) To: krzk, s.nawrocki, cw00.choi, alim.akhtar, mturquette, sboyd, linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel Cc: aswani.reddy, pankaj.dubey, gost.dev, Varada Pavani This patch series updates samsung clock driver with common samsung CCF function and defines locktime value for PLL142XX controller. Varada Pavani (2): clk: samsung: Use samsung CCF common function This patch is missed in this series https://patchwork.kernel.org/project/linux-clk/cover/20240926144513.71349-1-v.pavani@samsung.com/ hence posting again. clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom Got review comment in this patch will address in next patch series. drivers/clk/samsung/clk-exynos4.c | 78 +++++++++++++++++-------------- drivers/clk/samsung/clk-pll.c | 7 ++- 2 files changed, 50 insertions(+), 35 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-01 14:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20240926144716epcas5p330d6374d8b647f45e056143f237a55aa@epcas5p3.samsung.com>
2024-09-26 14:45 ` [PATCH 0/2] clk: samsung: Update PLL locktime and samsung function Varada Pavani
2024-09-26 14:45 ` [PATCH 2/2] clk: samsung: Fixes PLL locktime for PLL142XX used on FSD platfom Varada Pavani
2024-09-30 10:37 ` Krzysztof Kozlowski
2024-10-01 13:30 ` Varada Pavani
2024-09-30 10:38 ` [PATCH 0/2] clk: samsung: Update PLL locktime and samsung function Krzysztof Kozlowski
[not found] <CGME20240930112127epcas5p2622025d70a7db472b636a97b0fbd7cf2@epcas5p2.samsung.com>
2024-09-30 11:18 ` Varada Pavani
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox