From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Mihai Sain <mihai.sain@microchip.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: microchip: sam9x7: Move i2c address/size to dtsi
Date: Mon, 2 Dec 2024 10:08:25 +0200 [thread overview]
Message-ID: <db8187d8-5ec6-4aaa-bd61-21cd3a806c66@tuxon.dev> (raw)
In-Reply-To: <20241122080523.3941-2-mihai.sain@microchip.com>
Hi, Mihai,
On 22.11.2024 10:05, Mihai Sain wrote:
> Since these properties are common for all i2c subnodes,
> move them to SoC dtsi from board dts.
>
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
> ---
> .../dts/microchip/at91-sam9x75_curiosity.dts | 2 --
> arch/arm/boot/dts/microchip/sam9x7.dtsi | 26 +++++++++++++++++++
> 2 files changed, 26 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
> index 87b6ea97590b..d453800f8e35 100644
> --- a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
> @@ -88,8 +88,6 @@ &flx6 {
> };
>
> &i2c6 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_flx6_default>;
> i2c-analog-filter;
> diff --git a/arch/arm/boot/dts/microchip/sam9x7.dtsi b/arch/arm/boot/dts/microchip/sam9x7.dtsi
> index beb1f34b38d3..aedba0a8318f 100644
> --- a/arch/arm/boot/dts/microchip/sam9x7.dtsi
> +++ b/arch/arm/boot/dts/microchip/sam9x7.dtsi
> @@ -151,6 +151,8 @@ i2c4: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 13>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -220,6 +222,8 @@ i2c5: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 14>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -312,6 +316,8 @@ i2c11: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <32 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 32>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -362,6 +368,8 @@ i2c12: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <33 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 33>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -533,6 +541,8 @@ i2c6: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 9>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -583,6 +593,8 @@ i2c7: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <10 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 10>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -633,6 +645,8 @@ i2c8: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <11 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 11>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -702,6 +716,8 @@ i2c0: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 5>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -771,6 +787,8 @@ i2c1: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <6 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 6>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -840,6 +858,8 @@ i2c2: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <7 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 7>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -909,6 +929,8 @@ i2c3: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <8 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 8>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -984,6 +1006,8 @@ i2c9: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <15 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 15>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
> @@ -1034,6 +1058,8 @@ i2c10: i2c@600 {
> compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c";
> reg = <0x600 0x200>;
> interrupts = <16 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 16>;
> dmas = <&dma0
> (AT91_XDMAC_DT_MEM_IF(0) |
next prev parent reply other threads:[~2024-12-02 8:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 8:05 [PATCH 0/2] Add power monitor support on sam9x75-curiosity board Mihai Sain
2024-11-22 8:05 ` [PATCH 1/2] ARM: dts: microchip: sam9x7: Move i2c address/size to dtsi Mihai Sain
2024-12-02 8:08 ` Claudiu Beznea [this message]
2024-11-22 8:05 ` [PATCH 2/2] ARM: dts: microchip: sam9x75_curiosity: Add power monitor support Mihai Sain
2024-12-02 8:14 ` Claudiu Beznea
2024-12-02 8:32 ` Mihai.Sain
2024-12-03 8:37 ` Claudiu Beznea
2024-12-03 8:47 ` Mihai.Sain
2024-12-08 15:49 ` [PATCH 0/2] Add power monitor support on sam9x75-curiosity board Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db8187d8-5ec6-4aaa-bd61-21cd3a806c66@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.sain@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox