* [PATCH] arm64: tegra: Add uartd serial alias for Jetson TX1 module
@ 2025-04-20 14:35 Aaron Kling via B4 Relay
2025-04-22 14:31 ` Tomasz Maciej Nowak
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aaron Kling via B4 Relay @ 2025-04-20 14:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Tomasz Maciej Nowak
Cc: Thierry Reding, devicetree, linux-tegra, linux-kernel,
Aaron Kling
From: Aaron Kling <webgeek1234@gmail.com>
If a serial-tegra interface does not have an alias, the driver fails to
probe with an error:
serial-tegra 70006300.serial: failed to get alias id, errno -19
This prevents the bluetooth device from being accessible.
Fixes: 6eba6471bbb7 ("arm64: tegra: Wire up Bluetooth on Jetson TX1 module")
Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
index 9b9d1d15b0c7eafd3895f02db1bc747d7cc8923c..1bb1f9640a800af6c10fabf0ee3916f2566a6d4b 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
@@ -11,6 +11,7 @@ aliases {
rtc0 = "/i2c@7000d000/pmic@3c";
rtc1 = "/rtc@7000e000";
serial0 = &uarta;
+ serial3 = &uartd;
};
chosen {
---
base-commit: 119009db267415049182774196e3cce9e13b52ef
change-id: 20250419-tx1-bt-5f202a7e4cac
Best regards,
--
Aaron Kling <webgeek1234@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: tegra: Add uartd serial alias for Jetson TX1 module
2025-04-20 14:35 [PATCH] arm64: tegra: Add uartd serial alias for Jetson TX1 module Aaron Kling via B4 Relay
@ 2025-04-22 14:31 ` Tomasz Maciej Nowak
2025-05-08 21:12 ` Thierry Reding
2025-05-08 21:15 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Tomasz Maciej Nowak @ 2025-04-22 14:31 UTC (permalink / raw)
To: webgeek1234, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Thierry Reding, Jonathan Hunter
Cc: Thierry Reding, devicetree, linux-tegra, linux-kernel
W dniu 20.04.2025 o 16:35, Aaron Kling via B4 Relay pisze:
> From: Aaron Kling <webgeek1234@gmail.com>
>
> If a serial-tegra interface does not have an alias, the driver fails to
> probe with an error:
> serial-tegra 70006300.serial: failed to get alias id, errno -19
> This prevents the bluetooth device from being accessible.
>
> Fixes: 6eba6471bbb7 ("arm64: tegra: Wire up Bluetooth on Jetson TX1 module")
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Tomasz Maciej Nowak <tmn505@gmail.com>
Thanks.
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> index 9b9d1d15b0c7eafd3895f02db1bc747d7cc8923c..1bb1f9640a800af6c10fabf0ee3916f2566a6d4b 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> @@ -11,6 +11,7 @@ aliases {
> rtc0 = "/i2c@7000d000/pmic@3c";
> rtc1 = "/rtc@7000e000";
> serial0 = &uarta;
> + serial3 = &uartd;
> };
>
> chosen {
>
> ---
> base-commit: 119009db267415049182774196e3cce9e13b52ef
> change-id: 20250419-tx1-bt-5f202a7e4cac
>
> Best regards,
Regards
--
TMN
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: tegra: Add uartd serial alias for Jetson TX1 module
2025-04-20 14:35 [PATCH] arm64: tegra: Add uartd serial alias for Jetson TX1 module Aaron Kling via B4 Relay
2025-04-22 14:31 ` Tomasz Maciej Nowak
@ 2025-05-08 21:12 ` Thierry Reding
2025-05-08 21:15 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2025-05-08 21:12 UTC (permalink / raw)
To: webgeek1234
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Hunter,
Tomasz Maciej Nowak, Thierry Reding, devicetree, linux-tegra,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On Sun, Apr 20, 2025 at 09:35:37AM -0500, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
>
> If a serial-tegra interface does not have an alias, the driver fails to
> probe with an error:
> serial-tegra 70006300.serial: failed to get alias id, errno -19
> This prevents the bluetooth device from being accessible.
>
> Fixes: 6eba6471bbb7 ("arm64: tegra: Wire up Bluetooth on Jetson TX1 module")
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 1 +
> 1 file changed, 1 insertion(+)
Huh... seems a bit over the top to fail in the absence of an alias. Oh
well.
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: tegra: Add uartd serial alias for Jetson TX1 module
2025-04-20 14:35 [PATCH] arm64: tegra: Add uartd serial alias for Jetson TX1 module Aaron Kling via B4 Relay
2025-04-22 14:31 ` Tomasz Maciej Nowak
2025-05-08 21:12 ` Thierry Reding
@ 2025-05-08 21:15 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2025-05-08 21:15 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Tomasz Maciej Nowak, Aaron Kling
Cc: devicetree, linux-tegra, linux-kernel
From: Thierry Reding <treding@nvidia.com>
On Sun, 20 Apr 2025 09:35:37 -0500, Aaron Kling wrote:
> If a serial-tegra interface does not have an alias, the driver fails to
> probe with an error:
> serial-tegra 70006300.serial: failed to get alias id, errno -19
> This prevents the bluetooth device from being accessible.
>
>
Applied, thanks!
[1/1] arm64: tegra: Add uartd serial alias for Jetson TX1 module
commit: dfb25484bd73c8590954ead6fd58a1587ba3bbc5
Best regards,
--
Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-08 21:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-20 14:35 [PATCH] arm64: tegra: Add uartd serial alias for Jetson TX1 module Aaron Kling via B4 Relay
2025-04-22 14:31 ` Tomasz Maciej Nowak
2025-05-08 21:12 ` Thierry Reding
2025-05-08 21:15 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox