From: Leon Hwang <leon.hwang@linux.dev>
To: xu.xin16@zte.com.cn
Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,
andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com,
martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
jolsa@kernel.org, emil@etsalapatis.com, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2] bpf: Log error code on trampoline unlink failure
Date: Mon, 27 Jul 2026 13:27:33 +0800 [thread overview]
Message-ID: <de8b0e10-ed86-41f7-98fe-9818df89c4b6@linux.dev> (raw)
In-Reply-To: <20260727103158658fTr4mVbmUdVPeIguhCrHf@zte.com.cn>
On 27/7/26 10:31, xu.xin16@zte.com.cn wrote:
[...]
>>>
>>
>> Would it be better to include this multi_detach() one?
>>
>> WARN_ON_ONCE(__bpf_trampoline_unlink_prog(&mnode->node, mnode->trampoline,
>> NULL, &trampoline_multi_ops, data));
>>
>
> Sure, what about moving WARNing into __bpf_trampoline_unlink_prog and then the failures of
> __bpf_trampoline_unlink_prog everywhere will be logged.
No. I think it's callers' responsibility to log warning.
Thanks,
Leon
prev parent reply other threads:[~2026-07-27 5:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 15:07 [PATCH bpf-next v2] bpf: Log error code on trampoline unlink failure xu.xin16
2026-07-26 15:50 ` Leon Hwang
2026-07-27 2:31 ` xu.xin16
2026-07-27 5:27 ` Leon Hwang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de8b0e10-ed86-41f7-98fe-9818df89c4b6@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=song@kernel.org \
--cc=xu.xin16@zte.com.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox