* [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]
@ 2023-07-14 14:30 Sarah Walker
2023-07-17 8:32 ` Maxime Ripard
2023-07-18 6:19 ` Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Sarah Walker @ 2023-07-14 14:30 UTC (permalink / raw)
To: dri-devel
Cc: frank.binns, donald.robson, boris.brezillon, faith.ekstrand,
airlied, daniel, maarten.lankhorst, mripard, tzimmermann, afd,
hns, matthew.brost, christian.koenig, luben.tuikov, dakr,
linux-kernel
Add the Series AXE GPU node to the AM62 device tree.
Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
---
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index b3e4857bbbe4..ad13414acf18 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -892,4 +892,17 @@ mcasp2: audio-controller@2b20000 {
power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};
+
+ gpu: gpu@fd00000 {
+ compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
+ reg = <0 0x0fd00000 0 0x20000>;
+ power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 187 0>;
+ clock-names = "core";
+ interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "gpu";
+ #cooling-cells = <2>;
+ #cooling-min-level = <0>;
+ #cooling-max-level = <3>;
+ };
};
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]
2023-07-14 14:30 [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE] Sarah Walker
@ 2023-07-17 8:32 ` Maxime Ripard
2023-07-18 6:19 ` Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2023-07-17 8:32 UTC (permalink / raw)
To: Sarah Walker
Cc: dri-devel, frank.binns, donald.robson, boris.brezillon,
faith.ekstrand, airlied, daniel, maarten.lankhorst, tzimmermann,
afd, hns, matthew.brost, christian.koenig, luben.tuikov, dakr,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
Hi,
On Fri, Jul 14, 2023 at 03:30:33PM +0100, Sarah Walker wrote:
> Add the Series AXE GPU node to the AM62 device tree.
>
> Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
Checkpatch complains about that one because you indented the node with
spaces instead of tabs.
Once fixed:
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]
2023-07-14 14:30 [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE] Sarah Walker
2023-07-17 8:32 ` Maxime Ripard
@ 2023-07-18 6:19 ` Krzysztof Kozlowski
2023-07-18 11:52 ` Frank Binns
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-18 6:19 UTC (permalink / raw)
To: Sarah Walker, dri-devel
Cc: matthew.brost, luben.tuikov, tzimmermann, linux-kernel, mripard,
afd, boris.brezillon, dakr, donald.robson, hns, christian.koenig,
faith.ekstrand
On 14/07/2023 16:30, Sarah Walker wrote:
> Add the Series AXE GPU node to the AM62 device tree.
>
> Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index b3e4857bbbe4..ad13414acf18 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -892,4 +892,17 @@ mcasp2: audio-controller@2b20000 {
> power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> status = "disabled";
> };
> +
> + gpu: gpu@fd00000 {
> + compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
> + reg = <0 0x0fd00000 0 0x20000>;
> + power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&k3_clks 187 0>;
> + clock-names = "core";
> + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "gpu";
> + #cooling-cells = <2>;
> + #cooling-min-level = <0>;
> + #cooling-max-level = <3>;
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]
2023-07-18 6:19 ` Krzysztof Kozlowski
@ 2023-07-18 11:52 ` Frank Binns
0 siblings, 0 replies; 4+ messages in thread
From: Frank Binns @ 2023-07-18 11:52 UTC (permalink / raw)
To: dri-devel@lists.freedesktop.org, Sarah Walker, krzk@kernel.org
Cc: luben.tuikov@amd.com, afd@ti.com, Donald Robson,
tzimmermann@suse.de, matthew.brost@intel.com,
linux-kernel@vger.kernel.org, dakr@redhat.com, hns@goldelico.com,
boris.brezillon@collabora.com, christian.koenig@amd.com,
mripard@kernel.org, faith.ekstrand@collabora.com
Hi Krzysztof,
On Tue, 2023-07-18 at 08:19 +0200, Krzysztof Kozlowski wrote:
> On 14/07/2023 16:30, Sarah Walker wrote:
> > Add the Series AXE GPU node to the AM62 device tree.
> >
> > Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
> > ---
> > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index b3e4857bbbe4..ad13414acf18 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -892,4 +892,17 @@ mcasp2: audio-controller@2b20000 {
> > power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> > status = "disabled";
> > };
> > +
> > + gpu: gpu@fd00000 {
> > + compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
> > + reg = <0 0x0fd00000 0 0x20000>;
> > + power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> > + clocks = <&k3_clks 187 0>;
> > + clock-names = "core";
> > + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "gpu";
> > + #cooling-cells = <2>;
> > + #cooling-min-level = <0>;
> > + #cooling-max-level = <3>;
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
Thank you for the tip. I'll have a read through.
Frank
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-18 11:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-14 14:30 [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE] Sarah Walker
2023-07-17 8:32 ` Maxime Ripard
2023-07-18 6:19 ` Krzysztof Kozlowski
2023-07-18 11:52 ` Frank Binns
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox