From: Shuah Khan <skhan@linuxfoundation.org>
To: David Gow <davidgow@google.com>, Brian Norris <briannorris@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maxime Ripard <mripard@kernel.org>,
linux-acpi@vger.kernel.org, Rae Moar <rmoar@google.com>,
Rob Herring <robh@kernel.org>,
linux-kselftest@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3 3/3] drivers: base: test: Add ...find_device_by...(... NULL) tests
Date: Fri, 20 Dec 2024 10:34:48 -0700 [thread overview]
Message-ID: <df114243-822a-44a0-9991-d5d51a0dd91b@linuxfoundation.org> (raw)
In-Reply-To: <CABVgOSkL3iCA9j553GM8pX_SZ80Xx+BWGZ_qaL0jHAY69-WMmg@mail.gmail.com>
On 12/18/24 22:45, David Gow wrote:
> On Tue, 17 Dec 2024 at 04:12, Brian Norris <briannorris@chromium.org> wrote:
>>
>> We recently updated these device_match*() (and therefore, various
>> *find_device_by*()) functions to return a consistent 'false' value when
>> trying to match a NULL handle. Add tests for this.
>>
>> This provides regression-testing coverage for the sorts of bugs that
>> underly commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device
>> only if one actually exists").
>>
>> Reviewed-by: Maxime Ripard <mripard@kernel.org>
>> Signed-off-by: Brian Norris <briannorris@chromium.org>
>> ---
>>
>
> Thanks. This looks good to me.
>
> Reviewed-by: David Gow <davidgow@google.com>
>
>
>
This one also can go through Greg's drivers tree:
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
prev parent reply other threads:[~2024-12-20 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 20:11 [PATCH v3 0/3] drivers: base: Don't match device with NULL of_node/fwnode/etc + tests Brian Norris
2024-12-16 20:11 ` [PATCH v3 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc Brian Norris
2024-12-19 5:45 ` David Gow
2024-12-20 17:33 ` Shuah Khan
2024-12-20 17:44 ` Greg Kroah-Hartman
2024-12-16 20:11 ` [PATCH v3 2/3] drivers: base: test: Enable device model tests with KUNIT_ALL_TESTS Brian Norris
2024-12-17 7:41 ` Maxime Ripard
2024-12-19 5:45 ` David Gow
2024-12-16 20:11 ` [PATCH v3 3/3] drivers: base: test: Add ...find_device_by...(... NULL) tests Brian Norris
2024-12-19 5:45 ` David Gow
2024-12-20 17:34 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df114243-822a-44a0-9991-d5d51a0dd91b@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=briannorris@chromium.org \
--cc=davidgow@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=rafael@kernel.org \
--cc=rmoar@google.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox