public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: sm8450: correct Soundwire wakeup interrupt name
@ 2022-12-23 13:21 Krzysztof Kozlowski
  2022-12-23 13:22 ` Konrad Dybcio
  2023-01-11  5:09 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-23 13:21 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Srinivas Kandagatla, linux-arm-msm,
	devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

The bindings expect second Soundwire interrupt to be "wakeup" (Linux
driver takes by index):

  sm8450-hdk.dtb: soundwire-controller@33b0000: interrupt-names:1: 'wakeup' was expected

Fixes: 14341e76dbc7 ("arm64: dts: qcom: sm8450: add Soundwire and LPASS")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 570475040d95..eb3318516243 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -2263,7 +2263,7 @@ swr2: soundwire-controller@33b0000 {
 			reg = <0 0x33b0000 0 0x2000>;
 			interrupts-extended = <&intc GIC_SPI 496 IRQ_TYPE_LEVEL_HIGH>,
 					      <&intc GIC_SPI 520 IRQ_TYPE_LEVEL_HIGH>;
-			interrupt-names = "core", "wake";
+			interrupt-names = "core", "wakeup";
 
 			clocks = <&vamacro>;
 			clock-names = "iface";
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sm8450: correct Soundwire wakeup interrupt name
  2022-12-23 13:21 [PATCH] arm64: dts: qcom: sm8450: correct Soundwire wakeup interrupt name Krzysztof Kozlowski
@ 2022-12-23 13:22 ` Konrad Dybcio
  2023-01-11  5:09 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2022-12-23 13:22 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, Srinivas Kandagatla, linux-arm-msm,
	devicetree, linux-kernel



On 23.12.2022 14:21, Krzysztof Kozlowski wrote:
> The bindings expect second Soundwire interrupt to be "wakeup" (Linux
> driver takes by index):
> 
>   sm8450-hdk.dtb: soundwire-controller@33b0000: interrupt-names:1: 'wakeup' was expected
> 
> Fixes: 14341e76dbc7 ("arm64: dts: qcom: sm8450: add Soundwire and LPASS")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 570475040d95..eb3318516243 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -2263,7 +2263,7 @@ swr2: soundwire-controller@33b0000 {
>  			reg = <0 0x33b0000 0 0x2000>;
>  			interrupts-extended = <&intc GIC_SPI 496 IRQ_TYPE_LEVEL_HIGH>,
>  					      <&intc GIC_SPI 520 IRQ_TYPE_LEVEL_HIGH>;
> -			interrupt-names = "core", "wake";
> +			interrupt-names = "core", "wakeup";
>  
>  			clocks = <&vamacro>;
>  			clock-names = "iface";

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sm8450: correct Soundwire wakeup interrupt name
  2022-12-23 13:21 [PATCH] arm64: dts: qcom: sm8450: correct Soundwire wakeup interrupt name Krzysztof Kozlowski
  2022-12-23 13:22 ` Konrad Dybcio
@ 2023-01-11  5:09 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-01-11  5:09 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Srinivas Kandagatla, konrad.dybcio,
	devicetree, agross, linux-kernel, linux-arm-msm,
	krzysztof.kozlowski+dt, robh+dt

On Fri, 23 Dec 2022 14:21:21 +0100, Krzysztof Kozlowski wrote:
> The bindings expect second Soundwire interrupt to be "wakeup" (Linux
> driver takes by index):
> 
>   sm8450-hdk.dtb: soundwire-controller@33b0000: interrupt-names:1: 'wakeup' was expected
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sm8450: correct Soundwire wakeup interrupt name
      commit: 5eafe69af43d77cb117f27201076ee50f48363f1

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-11  5:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-23 13:21 [PATCH] arm64: dts: qcom: sm8450: correct Soundwire wakeup interrupt name Krzysztof Kozlowski
2022-12-23 13:22 ` Konrad Dybcio
2023-01-11  5:09 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox