From: Prashanth K <quic_prashk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<cros-qcom-dts-watchers@chromium.org>
Subject: Re: [PATCH v3 00/19] Disable USB U1/U2 entry for QC targets
Date: Wed, 18 Dec 2024 17:18:50 +0530 [thread overview]
Message-ID: <e15bc97d-eef3-4e49-badf-5b3afbc113d9@quicinc.com> (raw)
In-Reply-To: <nvhrhnfls2i4sb6rrlax2dh3hf5thfttrq54bgug2jc7ol26rj@cnk5dtampfes>
On 18-12-24 04:57 pm, Dmitry Baryshkov wrote:
> On Wed, Dec 18, 2024 at 03:56:48PM +0530, Prashanth K wrote:
>> Enabling U1 and U2 power-saving states can lead to stability and
>> performance issues, particularly for latency-sensitive or high-
>> throughput applications. These low-power link states are intended
>> to reduce power consumption by allowing the device to enter partial
>> low-power modes during idle periods. However, they can sometimes
>> result in unexpected behavior. Over the years, some of the issues
>> seen are as follows:
>>
>
> [..]
>
>>
>> This series was earlier started by Krishna Kurapati where he disabled
>> U1/U2 on some SM targets. I'm extending this to more devices including
>> Auto, Compute and IOT platforms. On a side note, this quirk has been
>> already included on some mobile targets like SM8550/8650.
>
> Why are you resending previous patches rather than adding another series
> on top of it?
>
Hi Dmitry,
RFC had only one patch with quirks (to disable u1/u2) only for few
targets (SM8150, 8250, 8350, 8450). It was later decided to split it
into per-file commits as per the review comments. Hence I clubbed
Krishna's changes along with few more targets. Let me know if this needs
to be changed.
>>
>> Changes in v2:
>> - Removed the wrongly added quirks from tcsr_mutex node.
>> - Link to v2: https://lore.kernel.org/all/20241213095237.1409174-1-quic_prashk@quicinc.com/
>
> What was changed in v3?
It was supposed to be "Changes in v3" instead of v2.
>
>>
>> Link to RFC:
>> https://lore.kernel.org/all/20241107073650.13473-1-quic_kriskura@quicinc.com/#Z31arch:arm64:boot:dts:qcom:sm8250.dtsi
>>
>
Regards,
Prashanth K
next prev parent reply other threads:[~2024-12-18 11:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 10:26 [PATCH v3 00/19] Disable USB U1/U2 entry for QC targets Prashanth K
2024-12-18 10:26 ` [PATCH v3 01/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM8350 Prashanth K
2024-12-18 10:26 ` [PATCH v3 02/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM8450 Prashanth K
2024-12-18 10:26 ` [PATCH v3 03/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM8150 Prashanth K
2024-12-18 10:26 ` [PATCH v3 04/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM6125 Prashanth K
2024-12-18 10:26 ` [PATCH v3 05/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM8250 Prashanth K
2024-12-18 10:26 ` [PATCH v3 06/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM6350 Prashanth K
2024-12-18 10:26 ` [PATCH v3 07/19] arm64: dts: qcom: Disable USB U1/U2 entry for SC7280 Prashanth K
2024-12-18 10:26 ` [PATCH v3 08/19] arm64: dts: qcom: Disable USB U1/U2 entry for SA8775P Prashanth K
2024-12-18 10:26 ` [PATCH v3 09/19] arm64: dts: qcom: Disable USB U1/U2 entry for SDM630 Prashanth K
2024-12-18 10:26 ` [PATCH v3 10/19] arm64: dts: qcom: Disable USB U1/U2 entry for SDM845 Prashanth K
2024-12-18 10:26 ` [PATCH v3 11/19] arm64: dts: qcom: Disable USB U1/U2 entry for SDX75 Prashanth K
2024-12-18 10:27 ` [PATCH v3 12/19] ARM: dts: qcom: Disable USB U1/U2 entry for SDX65 Prashanth K
2024-12-18 10:27 ` [PATCH v3 13/19] ARM: dts: qcom: Disable USB U1/U2 entry for SDX55 Prashanth K
2024-12-18 10:27 ` [PATCH v3 14/19] arm64: dts: qcom: Disable USB U1/U2 entry for QCS404 Prashanth K
2024-12-18 10:27 ` [PATCH v3 15/19] arm64: dts: qcom: Disable USB U1/U2 entry for SC7180 Prashanth K
2024-12-18 10:27 ` [PATCH v3 16/19] arm64: dts: qcom: Disable USB U1/U2 entry for X1E80100 Prashanth K
2024-12-18 10:27 ` [PATCH v3 17/19] arm64: dts: qcom: Disable USB U1/U2 entry for QDU1000 Prashanth K
2024-12-18 10:27 ` [PATCH v3 18/19] arm64: dts: qcom: Disable USB U1/U2 entry for SC8280XP Prashanth K
2024-12-18 10:27 ` [PATCH v3 19/19] arm64: dts: qcom: Disable USB U1/U2 entry for SC8180X Prashanth K
2024-12-18 11:27 ` [PATCH v3 00/19] Disable USB U1/U2 entry for QC targets Dmitry Baryshkov
2024-12-18 11:48 ` Prashanth K [this message]
2024-12-19 3:07 ` Dmitry Baryshkov
2024-12-19 4:17 ` Prashanth K
2024-12-19 13:14 ` Dmitry Baryshkov
2024-12-20 4:24 ` Prashanth K
2024-12-23 14:39 ` Konrad Dybcio
2024-12-26 4:43 ` Bjorn Andersson
2024-12-26 4:55 ` Prashanth K
2024-12-30 13:33 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e15bc97d-eef3-4e49-badf-5b3afbc113d9@quicinc.com \
--to=quic_prashk@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox