From: Konrad Dybcio <konradybcio@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Andrew Halaney <ahalaney@redhat.com>,
Elliot Berman <quic_eberman@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rudraksha Gupta <guptarud@gmail.com>,
"Linux regression tracking (Thorsten Leemhuis)"
<regressions@leemhuis.info>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 2/2] firmware: qcom: scm: fall back to kcalloc() for no SCM device bound
Date: Mon, 9 Sep 2024 22:10:57 +0200 [thread overview]
Message-ID: <e30dd3e9-4ccb-4da6-ba90-958ce1a6708a@kernel.org> (raw)
In-Reply-To: <20240909-tzmem-null-ptr-v1-2-96526c421bac@linaro.org>
On 9.09.2024 8:38 PM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Older platforms don't have an actual SCM device tied into the driver
> model and so there's no struct device which to use with the TZ Mem API.
> We need to fall-back to kcalloc() when allocating the buffer for
> additional SMC arguments on such platforms which don't even probe the SCM
> driver and never create the TZMem pool.
>
> Fixes: 449d0d84bcd8 ("firmware: qcom: scm: smc: switch to using the SCM allocator")
> Reported-by: Rudraksha Gupta <guptarud@gmail.com>
> Closes: https://lore.kernel.org/lkml/692cfe9a-8c05-4ce4-813e-82b3f310019a@gmail.com/<S-Del>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
Considering all SoCs that would be allowed on a roller coaster by age now
are supposed not to need this patch.. perhaps this isn't a hot enough
path for static branches, but I'd say some likely() hints could be used
here..
Konrad
next prev parent reply other threads:[~2024-09-09 20:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 18:38 [PATCH 0/2] firmware: qcom: scm: fix SMC calls on ARM32 Bartosz Golaszewski
2024-09-09 18:38 ` [PATCH 1/2] firmware: qcom: scm: fix a NULL-pointer dereference Bartosz Golaszewski
2024-09-09 20:06 ` Konrad Dybcio
2024-09-10 6:45 ` Rudraksha Gupta
2024-09-09 18:38 ` [PATCH 2/2] firmware: qcom: scm: fall back to kcalloc() for no SCM device bound Bartosz Golaszewski
2024-09-09 20:10 ` Konrad Dybcio [this message]
2024-09-09 21:04 ` Elliot Berman
2024-09-10 8:37 ` Bartosz Golaszewski
2024-09-10 11:06 ` Dmitry Baryshkov
2024-09-11 11:41 ` Bartosz Golaszewski
2024-09-11 11:55 ` Dmitry Baryshkov
2024-09-11 18:01 ` Rudraksha Gupta
2024-09-11 19:44 ` Bartosz Golaszewski
2024-09-10 6:46 ` Rudraksha Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e30dd3e9-4ccb-4da6-ba90-958ce1a6708a@kernel.org \
--to=konradybcio@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=dmitry.baryshkov@linaro.org \
--cc=guptarud@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_eberman@quicinc.com \
--cc=regressions@leemhuis.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox