* Re: [PATCH] sched/doc: Fix stale em_pd_energy() reference in sched-energy
2026-07-07 8:53 [PATCH] sched/doc: Fix stale em_pd_energy() reference in sched-energy luoliang
@ 2026-07-08 1:08 ` Alex Shi
2026-07-09 2:12 ` luoliang
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Alex Shi @ 2026-07-08 1:08 UTC (permalink / raw)
To: luoliang, Jonathan Corbet
Cc: Shuah Khan, Alex Shi, Yanteng Si, Dongliang Mu, linux-doc,
linux-kernel
On 2026/7/7 16:53, luoliang@kylinos.cn wrote:
> From: Liang Luo<luoliang@kylinos.cn>
>
> The scheduler energy-aware placement documentation refers to the
> em_pd_energy() API, which was renamed to em_cpu_energy() in commit
> f0b5694791ce ("PM / EM: change name of em_pd_energy to em_cpu_energy").
> Update the reference to the current name.
>
> em_cpu_energy() is the EM helper that compute_energy() in
> kernel/sched/fair.c calls to estimate a performance domain's energy
> consumption (defined in include/linux/energy_model.h).
>
> Sync the zh_CN translation, which carries the same stale name.
>
> Signed-off-by: Liang Luo<luoliang@kylinos.cn>
Reviewed-by: Alex Shi <alexs@kernel.org>
> ---
> Documentation/scheduler/sched-energy.rst | 2 +-
> Documentation/translations/zh_CN/scheduler/sched-energy.rst | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-energy.rst b/Documentation/scheduler/sched-energy.rst
> index 4e47aaf103eb..83bac0da4869 100644
> --- a/Documentation/scheduler/sched-energy.rst
> +++ b/Documentation/scheduler/sched-energy.rst
> @@ -141,7 +141,7 @@ in its previous activation.
> find_energy_efficient_cpu() uses compute_energy() to estimate what will be the
> energy consumed by the system if the waking task was migrated. compute_energy()
> looks at the current utilization landscape of the CPUs and adjusts it to
> -'simulate' the task migration. The EM framework provides the em_pd_energy() API
> +'simulate' the task migration. The EM framework provides the em_cpu_energy() API
> which computes the expected energy consumption of each performance domain for
> the given utilization landscape.
>
> diff --git a/Documentation/translations/zh_CN/scheduler/sched-energy.rst b/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> index fdbf6cfeea93..03dedc69839a 100644
> --- a/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> +++ b/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> @@ -119,7 +119,7 @@ EAS覆盖了CFS的任务唤醒平衡代码。在唤醒平衡时,它使用平
>
> 如果唤醒的任务被迁移,find_energy_efficient_cpu()使用compute_energy()来估算
> 系统将消耗多少能量。compute_energy()检查各CPU当前的利用率情况,并尝试调整来
> -“模拟”任务迁移。EM框架提供了API em_pd_energy()计算每个性能域在给定的利用率条件
> +“模拟”任务迁移。EM框架提供了API em_cpu_energy()计算每个性能域在给定的利用率条件
> 下的预期能量消耗。
>
> 下面详细介绍一个优化能量消耗的任务放置决策的例子。
> -- 2.43.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sched/doc: Fix stale em_pd_energy() reference in sched-energy
2026-07-07 8:53 [PATCH] sched/doc: Fix stale em_pd_energy() reference in sched-energy luoliang
2026-07-08 1:08 ` Alex Shi
@ 2026-07-09 2:12 ` luoliang
2026-07-09 11:37 ` Lukasz Luba
2026-07-09 11:41 ` Dongliang Mu
3 siblings, 0 replies; 5+ messages in thread
From: luoliang @ 2026-07-09 2:12 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Lukasz Luba, Rafael J . Wysocki, Ingo Molnar, Peter Zijlstra,
Vincent Guittot, Alex Shi, Shuah Khan, Yanteng Si, Dongliang Mu,
linux-pm, linux-doc, linux-kernel
Adding the EM and scheduler maintainers to the loop, since this patch
touches a name defined in the Energy Model framework and used by the
scheduler code.
No changes needed - just making sure the relevant subsystem people are
aware of this small doc fix. The referenced rename happened in:
commit f0b5694791ce ("PM / EM: change name of em_pd_energy to em_cpu_energy")
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sched/doc: Fix stale em_pd_energy() reference in sched-energy
2026-07-07 8:53 [PATCH] sched/doc: Fix stale em_pd_energy() reference in sched-energy luoliang
2026-07-08 1:08 ` Alex Shi
2026-07-09 2:12 ` luoliang
@ 2026-07-09 11:37 ` Lukasz Luba
2026-07-09 11:41 ` Dongliang Mu
3 siblings, 0 replies; 5+ messages in thread
From: Lukasz Luba @ 2026-07-09 11:37 UTC (permalink / raw)
To: luoliang
Cc: Shuah Khan, Jonathan Corbet, Alex Shi, Yanteng Si, Dongliang Mu,
linux-doc, linux-kernel, Rafael J. Wysocki
On 7/7/26 09:53, luoliang@kylinos.cn wrote:
> From: Liang Luo <luoliang@kylinos.cn>
>
> The scheduler energy-aware placement documentation refers to the
> em_pd_energy() API, which was renamed to em_cpu_energy() in commit
> f0b5694791ce ("PM / EM: change name of em_pd_energy to em_cpu_energy").
> Update the reference to the current name.
>
> em_cpu_energy() is the EM helper that compute_energy() in
> kernel/sched/fair.c calls to estimate a performance domain's energy
> consumption (defined in include/linux/energy_model.h).
>
> Sync the zh_CN translation, which carries the same stale name.
>
> Signed-off-by: Liang Luo <luoliang@kylinos.cn>
> ---
> Documentation/scheduler/sched-energy.rst | 2 +-
> Documentation/translations/zh_CN/scheduler/sched-energy.rst | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-energy.rst b/Documentation/scheduler/sched-energy.rst
> index 4e47aaf103eb..83bac0da4869 100644
> --- a/Documentation/scheduler/sched-energy.rst
> +++ b/Documentation/scheduler/sched-energy.rst
> @@ -141,7 +141,7 @@ in its previous activation.
> find_energy_efficient_cpu() uses compute_energy() to estimate what will be the
> energy consumed by the system if the waking task was migrated. compute_energy()
> looks at the current utilization landscape of the CPUs and adjusts it to
> -'simulate' the task migration. The EM framework provides the em_pd_energy() API
> +'simulate' the task migration. The EM framework provides the em_cpu_energy() API
> which computes the expected energy consumption of each performance domain for
> the given utilization landscape.
>
> diff --git a/Documentation/translations/zh_CN/scheduler/sched-energy.rst b/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> index fdbf6cfeea93..03dedc69839a 100644
> --- a/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> +++ b/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> @@ -119,7 +119,7 @@ EAS覆盖了CFS的任务唤醒平衡代码。在唤醒平衡时,它使用平
>
> 如果唤醒的任务被迁移,find_energy_efficient_cpu()使用compute_energy()来估算
> 系统将消耗多少能量。compute_energy()检查各CPU当前的利用率情况,并尝试调整来
> -“模拟”任务迁移。EM框架提供了API em_pd_energy()计算每个性能域在给定的利用率条件
> +“模拟”任务迁移。EM框架提供了API em_cpu_energy()计算每个性能域在给定的利用率条件
> 下的预期能量消耗。
>
> 下面详细介绍一个优化能量消耗的任务放置决策的例子。
Good catch Liang. I've missed that doc bit back then, thank you.
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sched/doc: Fix stale em_pd_energy() reference in sched-energy
2026-07-07 8:53 [PATCH] sched/doc: Fix stale em_pd_energy() reference in sched-energy luoliang
` (2 preceding siblings ...)
2026-07-09 11:37 ` Lukasz Luba
@ 2026-07-09 11:41 ` Dongliang Mu
3 siblings, 0 replies; 5+ messages in thread
From: Dongliang Mu @ 2026-07-09 11:41 UTC (permalink / raw)
To: luoliang, Jonathan Corbet
Cc: Shuah Khan, Alex Shi, Yanteng Si, linux-doc, linux-kernel
On 7/7/26 4:53 PM, luoliang@kylinos.cn wrote:
> From: Liang Luo <luoliang@kylinos.cn>
>
> The scheduler energy-aware placement documentation refers to the
> em_pd_energy() API, which was renamed to em_cpu_energy() in commit
> f0b5694791ce ("PM / EM: change name of em_pd_energy to em_cpu_energy").
> Update the reference to the current name.
>
> em_cpu_energy() is the EM helper that compute_energy() in
> kernel/sched/fair.c calls to estimate a performance domain's energy
> consumption (defined in include/linux/energy_model.h).
>
> Sync the zh_CN translation, which carries the same stale name.
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
>
> Signed-off-by: Liang Luo <luoliang@kylinos.cn>
> ---
> Documentation/scheduler/sched-energy.rst | 2 +-
> Documentation/translations/zh_CN/scheduler/sched-energy.rst | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-energy.rst b/Documentation/scheduler/sched-energy.rst
> index 4e47aaf103eb..83bac0da4869 100644
> --- a/Documentation/scheduler/sched-energy.rst
> +++ b/Documentation/scheduler/sched-energy.rst
> @@ -141,7 +141,7 @@ in its previous activation.
> find_energy_efficient_cpu() uses compute_energy() to estimate what will be the
> energy consumed by the system if the waking task was migrated. compute_energy()
> looks at the current utilization landscape of the CPUs and adjusts it to
> -'simulate' the task migration. The EM framework provides the em_pd_energy() API
> +'simulate' the task migration. The EM framework provides the em_cpu_energy() API
> which computes the expected energy consumption of each performance domain for
> the given utilization landscape.
>
> diff --git a/Documentation/translations/zh_CN/scheduler/sched-energy.rst b/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> index fdbf6cfeea93..03dedc69839a 100644
> --- a/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> +++ b/Documentation/translations/zh_CN/scheduler/sched-energy.rst
> @@ -119,7 +119,7 @@ EAS覆盖了CFS的任务唤醒平衡代码。在唤醒平衡时,它使用平
>
> 如果唤醒的任务被迁移,find_energy_efficient_cpu()使用compute_energy()来估算
> 系统将消耗多少能量。compute_energy()检查各CPU当前的利用率情况,并尝试调整来
> -“模拟”任务迁移。EM框架提供了API em_pd_energy()计算每个性能域在给定的利用率条件
> +“模拟”任务迁移。EM框架提供了API em_cpu_energy()计算每个性能域在给定的利用率条件
> 下的预期能量消耗。
>
> 下面详细介绍一个优化能量消耗的任务放置决策的例子。
^ permalink raw reply [flat|nested] 5+ messages in thread